Demo Discussion
Forum Config Examples Contributions Vulnerabilities
  Discussion forum about ELOG  Not logged in ELOG logo
 Back  |  Find  |  Login  |  Help 
icon5.gif   Timstamp button in ckedit inserts an incorrect string ( elogd 3.1.0-2), posted by David Wallis on Thu May 28 17:28:20 2015 
    icon2.gif   ELOG Forum: drafts cannot be deleted, posted by Andreas Luedeke on Fri May 29 09:46:11 2015 
       icon2.gif   ELOG Forum: drafts cannot be deleted, posted by Stefan Ritt on Tue Jun 9 17:09:22 2015 
          icon2.gif   ELOG Forum: drafts cannot be deleted, posted by Andreas Luedeke on Wed Jun 10 10:43:02 2015 
             icon2.gif   ELOG Forum: drafts cannot be deleted, posted by Stefan Ritt on Wed Jun 10 10:55:00 2015 
    icon2.gif   Re: Timstamp button in ckedit inserts an incorrect string ( elogd 3.1.0-2), posted by David Wallis on Thu Jun 4 18:12:43 2015 
       icon2.gif   Re: ckeditor "Insert Timestamp" bug (was: Three problems with elogd 3.1.0-2), posted by Andreas Luedeke on Fri Jun 5 19:08:17 2015 
          icon2.gif   Re: ckeditor "Insert Timestamp" bug (was: Three problems with elogd 3.1.0-2), posted by David Wallis on Fri Jun 5 23:02:06 2015 
             icon2.gif   Re: ckeditor "Insert Timestamp" bug (was: Three problems with elogd 3.1.0-2), posted by Stefan Ritt on Mon Jun 8 12:02:30 2015 
Message ID: 67967     Entry time: Mon Jun 8 12:02:30 2015     In reply to: 67963
Icon: Reply  Author: Stefan Ritt  Author Email: stefan.ritt@psi.ch 
Category: Question  OS: Linux  ELOG Version: 3.1.0-2 
Subject: Re: ckeditor "Insert Timestamp" bug (was: Three problems with elogd 3.1.0-2) 

Indeed the "str" variable at the gettimedate function had the wrong string size, so that all date strings got truncated at 8 characters. That's what you've seen. Also the ../../?cmd=gettimedate was wrong and it should be ./?cmd=gettimedate. I committed the fix to GIT so it will be contained in the next release ofe log.

David Wallis wrote:

Andreas,

I too was able to track the problem down to the "gettimedate" function in elogd.c. It looks like the code is using a variable named "str" for several different purposes. I haven't had a chance to do any testing, but my suspsicion is that the size of the dynamically allocated variable is ending up too small for the time stamp string, so it gets truncated.

 

Your point about the topic title is a good one - I'll split this into separate issues, thanks!

Andreas Luedeke wrote:
I can confirm that there is currently a problem with the ckeditor "Insert Timestamp" button.
It apparently calls javascript code in ckeditor/plugins/timestamp/plugin.js
to catch a string from the URL "../../?cmd=gettimedate"
(I think this is one too many "../", but anyway). if you try this for the Forum:
https://midas.psi.ch/elogs/Forum/?cmd=gettimedate
it returns the wrong string. It is "Forum" instead of the date.

PS to David: The subject "Three problems ..." is not giving any indication what it is about. I would find it better in this case to post three entries to the Forum, each with a striking title :-)

David Wallis wrote:

Additional info:

"Time format = %Y" results in "2015" being pasted into the edit window when I hit the "time stamp" button.

"Time format = %m/%Y" results in the string "06/2015"

"TIme format = %m/%d/%Y" results in the string "06/04"

"Time format = %m/%d %H" results in the string "06/04 "

David Wallis wrote:

I just updated to the latest official release (V3.1.0-2411f95) and have these problems:

  1. The Time Stamp button pastes the logbook name when "Time format" is not specified in elogd.cfg, and when it is set to "%m/%d/%Y %H:%M", it adds the string "5/28/."
  2. Drag and drop for attachments dosn't work on either Chrome 37.0.2062.94 (64-bit) or FIrefox 31.5.3 (both on Linux). D&D works on the midas.psi.ch demo page. On my logbooks, the "drop attachements here" area does not have a dashed line border
  3. Auto-saving does not seem to be working.

The "Syntax of elogd.cfg" help file doesn't seem to reflect some of these features... it took me a while to find the settings for LDAP authentication. Am I just missing some settings for these features?

My users are loving the new functionality added in 3.1!

 

 

 

 

ELOG V3.1.5-3fb85fa6