ELOG

I was just playing around with gcc6's new feature for warning about misleading indentation (which can often hide real bugs) and I think it found one in elog-3.1.1-1 at src/elogd.c:22538. Here there is an if statement, which looks as though it should be inside a loop, but it isn't. The code is:

      for (i = 0; i < MAX_ATTACHMENTS; i++)

         generate_subdir_name(att_file[i], subdir, sizeof(subdir));

         if (att_file[i][0] && strlen(shell_cmd) + strlen(lbs->data_dir) + strl$

             < sizeof(shell_cmd) + 1) {

            strcpy(p, "\"");

            strcat(p, lbs->data_dir);

            strlcat(str, subdir, sizeof(str));

            strlcpy(str, att_file[i], sizeof(str));

            str_escape(str, sizeof(str));

            strcat(p, str);

            strcat(p, "\" ");

            p += strlen(p);

         }

and the if statment is accessing the loop variable i but it is actually outside the loop. Presumably, there should be some more curly brackets here. gcc6 gave the warning:

src/elogd.c: In function ‘execute_shell’:

src/elogd.c:22538:10: warning: statement is indented as if it were guarded by... [-Wmisleading-indentation]

          if (att_file[i][0] && strlen(shell_cmd) + strlen(lbs->data_dir) + strlen(subdir) + strlen(att_file[i])

          ^~

src/elogd.c:22536:7: note: ...this ‘for’ clause, but it is not

       for (i = 0; i < MAX_ATTACHMENTS; i++)

       ^~~