Re: init_resize sometimes not defined, posted by Stefan Ritt on Wed Aug 5 13:36:44 2009
|
Richard Stamper wrote: |
Under some circumstances the New/Edit entry screen can invoke the init_resize() function in the onload handler for the <body> tag, but the init_resize() function is not defined. In my case there is a log where the encoding is plain text (Default encoding = 1) and the message height is restricted (Message height = 4). Creating or editing entries in this log generates warnings in the Firefox error console and alert boxes in IE about init_resize being undefined.
I think there is some missing logic. In revision 2246 of elogd.c
- at line 9924, if enc_selected = 1 then init_resize() is included in the onload handler, but
- at line 9801, if enc_selected = 1 but at least one of the "Message height" or "Message width" attributes is set then the code defining init_resize() is not include
I think you need to duplicate the checks on the Message height and Message width attributes at lines 9924, so that the init_resize() function is only included when defined.
Richard S
|
Perfect! Not only your analysis but also your suggested solution. I implemented that in revision 2249.
Stefan |
Re: increasing the height of the attribute display field, posted by Stefan Ritt on Thu Jan 20 17:40:33 2005
|
> Was wondering if it was possible to increase the height that the text box
> for an attribute is displayed as.
What you ask for is multi-line attributes. This is not implemented, but on the
wishlist since some time, where I added your vote.
Best regards,
Stefan |
Re: increasing the height of the attribute display field, posted by John Habermann on Thu Jan 20 23:59:19 2005
|
Sorry I didn't see the wishlist but I see what you mean. I have just found out
that pasting content that contains more than 1 line into an attribute field
crashes elog.
I have a play with the Preset text setting and see what I can come up with. By the
way there is a spelling mistake in the config.html page. In the Conditional
Attributes section you use the Preset text setting as an example but have spelt it
as "Prset text ="
Thank you for you help
John
> > Was wondering if it was possible to increase the height that the text box
> > for an attribute is displayed as.
>
> What you ask for is multi-line attributes. This is not implemented, but on the
> wishlist since some time, where I added your vote.
>
> Best regards,
>
> Stefan |
Re: increasing the height of the attribute display field, posted by Stefan Ritt on Fri Jan 21 10:43:21 2005
|
> I have a play with the Preset text setting and see what I can come up with. By the
> way there is a spelling mistake in the config.html page. In the Conditional
> Attributes section you use the Preset text setting as an example but have spelt it
> as "Prset text ="
Thanks, fixed. |
Re: inactive users, posted by Stefano Lacaprara on Wed May 31 11:45:06 2017
|
Hi,
I reopen this old thread since I'm having a similar problem.
I'm running ELOG V3.1.1-0767eb0 on ubuntu with webserver authentication, and I'd like to remove 'active' checkbox as well.
The problem that we found is that if any user click on the [Set None] button at the bottom of the Config page in order to unsubscribe from all mail notification, *all* the checkbox are toggled, not only those for the email notification. And this includes
also the "active user" as well.
Moreover, if an user click directly on the "active user" checkbox, a warning dialog box appears, asking for confirmation, but this is not the case is [Set none] is pressed: so, in that case, a user deactivate itself without warning.
Looking at the web page as well as at the code, I did not find a possibility, but maybe someone knows better.
Thanks in advance,
Stefano
> Hello,
>
> Is it possible to remove the "active" checkbox a user sees when they click on "config"? Alternatively, is it possible to have a new user arrive directly at the logbook they chose, rather than starting out at the config screen?
>
> We are running elog-3.1.1 on SL6 with webserver authentication. For the most part this works great, but somehow a few users become inactive after they login for the first time. They claim they didn't un-check "active," but I can't think of any other
way this would happen.
>
> Many thanks,
> Devin |
Re: inactive users, posted by Andreas Luedeke on Wed May 31 13:28:51 2017
|
> Hi,
> I reopen this old thread since I'm having a similar problem.
>
> I'm running ELOG V3.1.1-0767eb0 on ubuntu with webserver authentication, and I'd like to remove 'active' checkbox as well.
>
> The problem that we found is that if any user click on the [Set None] button at the bottom of the Config page in order to unsubscribe from all mail notification,
> *all* the checkbox are toggled, not only those for the email notification. And this includes also the "active user" as well.
I can confirm that this bug is present even in this forum and in my current version (ELOG V3.1.3-aded4ae).
And I am positive that this is a bug: it was certainly not the intended behaviour. |
Re: inactive users, posted by Stefano Lacaprara on Wed May 31 16:02:46 2017
|
Hi,
a possible solution is to change the current SetAll() and SetNone() javascript functions to something like:
<!--
function SetNone()
{
for(var i=0,els=document.querySelectorAll('[name^="sub_lb"]'); i<els.length; i++)
{
els[i].checked = false;
}
}
function SetAll()
{
for(var i=0,els=document.querySelectorAll('[name^="sub_lb"]'); i<els.length; i++)
{
els[i].checked = true;
}
}
//-->
It works on Chromium 58.x and Firefox 53.x, I don't know about other browsers.
The javascript snippet is generated in function elogd.c: void show_config_page(LOGBOOK * lbs) (line 13960-984 on my version of the source code).
Best,
Stefano |
Re: inactive users, posted by Stefano Lacaprara on Mon Feb 26 18:16:35 2018
|
Hi,
sorry to bother again on this issue, but it is causing me some trouble, as many of my users are using the "SetNone" button in their config page, and doing so they deactivate their account, which I have to re-activate manually.
The warning about "Are you sure you want to deactivate your own account ..." is actually triggered only when someone toggle the "active" radio button, but not when the "SetNone" function is used. In that case no warning is present, and the user just deactivate his/her account. I'm sure that this is not the intended behavior.
I attach a modified version of elogd.c (based on git c1866af75bb2fe62aa868c4cf562f43a08e4b499 ) with the modified javascript I proposed earlier in this thread.
best,
Stefano |
|