ID |
Date |
Icon |
Author |
Author Email |
Category |
OS |
ELOG Version |
Subject |
1926
|
Wed Sep 6 12:02:52 2006 |
| Gerald Ebberink | g.h.p.ebberink@nclr.nl | Bug report | Linux | 2.6.2-1706 | Re: reply option in elog client not working | Today I found, I have the same problem with editing the log (with the -e option) |
1927
|
Thu Sep 7 08:01:37 2006 |
| Gerald Ebberink | g.h.p.ebberink@nclr.nl | Bug report | Linux | 2.6.2-1706 | Re: reply option in elog client not working | I have made patch witch solves the problem partialy.
If there are not no attachments this patch works.... (But since I have attachments I'll have to dig in deeper in the code.
Attached you will find the diff. |
Attachment 1: elog.c.diff
|
Index: src/elog.c
===================================================================
--- src/elog.c (revision 1714)
+++ src/elog.c (working copy)
@@ -351,8 +351,11 @@
strcpy(request, "GET /");
if (subdir[0])
sprintf(request + strlen(request), "%s/%d?cmd=download", subdir, message_id);
- if (experiment[0])
- sprintf(request + strlen(request), "%s/%d?cmd=download", experiment, message_id);
+ if (experiment[0]) {
+ strcpy(str,experiment);
+ url_encode(str, sizeof(str));
+ sprintf(request + strlen(request), "%s/%d?cmd=download", str, message_id);
+ }
strcat(request, " HTTP/1.0\r\n");
sprintf(request + strlen(request), "User-Agent: ELOG\r\n");
|
1928
|
Thu Sep 7 17:17:17 2006 |
| Gerald Ebberink | g.h.p.ebberink@nclr.nl | Bug report | Linux | 2.6.2-1714 | Re: reply option in elog client not working |
Gerald Ebberink wrote: | I have made patch witch solves the problem partialy.
If there are not no attachments this patch works.... (But since I have attachments I'll have to dig in deeper in the code.
Attached you will find the diff. |
Now I am digging deeper, and I have a question:
In the function retrive_elog near line 427 a start is made with putting the attributes in an array.
As far as I can see there is no exception for the Attachment attribute. Where this attribute can be very large (e.g. many files attached) and overrun to the boundary variable (in the function submit_elog function). At least that is where I find end of my attachment string.
Could Mr. Ritt please shine some light on this, becouse I |
1931
|
Mon Sep 11 16:32:52 2006 |
| Stefan Ritt | stefan.ritt@psi.ch | Question | Linux | 2.6.2-1714 | Re: Auto-refresh ELog display |
Alan Stone wrote: | We have multiple LCDs at a console, and usually one is dedicated to displaying a browser
with the local ELog. Meanwhile, others are making entries from another machine. If
no one clicks on refresh, the ELog display becomes stale. Is there a method to have
the ELog reload every X minutes?
Thanks, Alan |
The JavaScript is one possibility as Steve mentioned correctly. Another possibility is to use the RSS feed capability of ELOG. Use any RSS reader, and it will notify you immediately if there is a new entry in ELOG. Have a look at http://midas.psi.ch/elog/config.html and search for RSS on how to configure this. |
1932
|
Mon Sep 11 17:25:54 2006 |
| Stefan Ritt | stefan.ritt@psi.ch | Question | Linux | 2.6 | Re: Unsubscribe from logbooks |
Chris Warner wrote: | Is there a way for user to unsubscribe from a logbook? Can a user delete their own account? |
Yes. Yes.
Just click on "Config", and you will see a page where you can unsubscribe from each logbook and a button to remove your account. |
1934
|
Mon Sep 18 15:21:56 2006 |
| Stefan Ritt | stefan.ritt@psi.ch | Question | All | 2.6.2-1714 | Re: Why are Preset fields blanked out? |
Steve Jones wrote: | The snippet of code below sets an attribute to a date depending on the selection. Problem is, if attribute ApprovedDate was previously set, selecting any other value for CRStatus will blank out ApprovedDate (the same occurs for CompletedDate). Why would this be occurring when the conditionals are mutually exclusive?
##################################################
# Define CRState
#
Options CRState = PENDING{a}, APPROVED{b}, HOLD{a}, REJECTED{a}, COMPLETED{c}
{a}
{b} Preset ApprovedDate = $date
{c} Preset CompletedDate = $date
|
I don't understand your problem. If I use following config file:
[demo]
Theme = default
Attributes = Author, CRState, ApprovedDate, CompletedDate
Options CRState = PENDING{a}, APPROVED{b}, HOLD{a}, REJECTED{a}, COMPLETED{c}
{a}
{b} Preset ApprovedDate = $date
{c} Preset CompletedDate = $date
and make an entry, then edit it, selecting approved, then submit, then edit again, then select completed, then I get following:

which looks ok to me (the previous ApprovedDate does not get blanked out). Can you reproduce that behaviour? |
1936
|
Mon Sep 18 18:19:44 2006 |
| Steve Jones | steve.jones@freescale.com | Question | All | 2.6.2-1714 | Re: Re: Why are Preset fields blanked out? |
Stefan Ritt wrote: |
Steve Jones wrote: | The snippet of code below sets an attribute to a date depending on the selection. Problem is, if attribute ApprovedDate was previously set, selecting any other value for CRStatus will blank out ApprovedDate (the same occurs for CompletedDate). Why would this be occurring when the conditionals are mutually exclusive?
##################################################
# Define CRState
#
Options CRState = PENDING{a}, APPROVED{b}, HOLD{a}, REJECTED{a}, COMPLETED{c}
{a}
{b} Preset ApprovedDate = $date
{c} Preset CompletedDate = $date
|
I don't understand your problem. If I use following config file:
[demo]
Theme = default
Attributes = Author, CRState, ApprovedDate, CompletedDate
Options CRState = PENDING{a}, APPROVED{b}, HOLD{a}, REJECTED{a}, COMPLETED{c}
{a}
{b} Preset ApprovedDate = $date
{c} Preset CompletedDate = $date
and make an entry, then edit it, selecting approved, then submit, then edit again, then select completed, then I get following:

which looks ok to me (the previous ApprovedDate does not get blanked out). Can you reproduce that behaviour? |
Quote: |
I think I found it. Try this:
Locked Attributes = ApprovedDate, CompletedDate
##################################################
# Define CRState
#
Options CRState = PENDING{a}, APPROVED{b}, HOLD{a}, REJECTED{a}, COMPLETED{c}
{a}
{b} Preset ApprovedDate = $date
{c} Preset CompletedDate = $date
In my config when I remove the two attributes from "LOCKED ATTRIBUTES" the fields do not get blanked out.
|
|
1938
|
Mon Sep 18 18:56:19 2006 |
| Steve Jones | steve.jones@freescale.com | Question | All | 2.6.2-1714 | Re: "Supress Email Notification" checkbox |
Steve Jones wrote: | Is there a way to allow email notification but have the "Suppress Email Notification" checked by default? We had complaints about the enormous amount of email so I turned off email notification for edits/replys, but there are times that I would like to allow email to be sent out -- this would imply allowing email by unchecking the "Suppress" box. |
What I think would be needed is:
Suppress Email on edit = 0|1|2
^
Where a '2' denotes that the "Suppress Email Notification" shows up but *checked* |
|