ID |
Date |
Icon |
Author |
Author Email |
Category |
OS |
ELOG Version |
Subject |
68243
|
Fri Jan 22 10:12:33 2016 |
| Stefan Ritt | stefan.ritt@psi.ch | Bug report | Linux | 3.1.1 | Re: entry does not appear in list while it is being edited | I have a question here. You say "previsous releases didn't have this problems". Well, they did not have the auto-save feature. You can turn this off if you like with "autosave = 0". This also removes the "Save" button so elog behaves exactly as before.
I decided NOT to show draft entries in the list, because these are entries currently under editing, and maybe the editor does not want others to see a half finished entry. Actually I had this feature initially and people complained about seing half finished messages in the list. Previously, when there was no "Save" button, new entries where not visible on the list because nothing was submitted at all, and I guess that was ok with you. So would reverting to the old functionality via "autosave = 0" make you happy? Of course you then loose the autosave functionality. So if people enter a long entry, and surf away from the page or the browser crashes, the entry is lost.
Devin Bougie wrote: |
Thanks, Andreas. I was aware of the "pending draft" menu, and I am aware that you can manually browse to an entry even if it doesn't appear in the list. However, for our operations group it is a requirement that any saved entry appears in the list, even if it's in the process of being edited. We won't be able to upgrade until this is possible.
Previous releases didn't have this problem, so hopefully it won't be too difficult to address with a new configuration option. Please let me know if there's something I should do to submit an official feature request / bug report.
Thanks again,
Devin
Andreas Luedeke wrote: |
Hi Devin,
this is the intended bevaviour, there is nothing wrong with that.
Only a submitted entry should be visible to the world.
If you would have played a little bit longer, you would have found out yourself how you'll get access again to this so-called "draft" entry after closing the browser window:
as soon as you attempt to create - as the same user - an new entry, you'll be asked if you want to continue editing your old draft entry instead.
I've attached a screenshot of this "pending draft" menu, as it has been shown for this entry before I've submitted it.
Kind Regards, Andreas
PS: You gave a very clear "failure" description: what you did, what you expected to happen and what you've observed what happened instead. Well done: that deserves a swift answer! 
Devin Bougie wrote: |
When an entry is being edited, it does not appear in the list once it's been autosaved or the editor manually clicks on "Save." This has been reproduced in the "Linux Demo" forum on this site, as well as on a clean installation of the 3.1.1 binary on EL6.
It would be great if there was a configuraiton option to control this, but I haven't found it yet. To reproduce:
- edit an existing entry
- click on "Save"
- view the list for that logbook, and the entry will be hidden until you click "Submit"
Obviously this becomes a problem when a user edits an entry, but navigates away from the browser window before submitting the changes.
Any suggestions would be greatly appreciated.
Many thanks,
Devin
|
|
|
|
68244
|
Fri Jan 22 18:02:44 2016 |
| Devin Bougie | devin.bougie@cornell.edu | Bug report | Linux | 3.1.1 | Re: entry does not appear in list while it is being edited | Thanks, Stefan! Yes, the old behavior is an acceptable workaround. Although you need to use "Save drafts = 0" for this instead of "autosave = 0".
Ideally, our machine studies group would like to have the ability to save / autosave an entry *and* have it remain in the list. We'd be very grateful to see that as an option in a future release.
Thanks again,
Devin
Stefan Ritt wrote: |
I have a question here. You say "previsous releases didn't have this problems". Well, they did not have the auto-save feature. You can turn this off if you like with "autosave = 0". This also removes the "Save" button so elog behaves exactly as before.
I decided NOT to show draft entries in the list, because these are entries currently under editing, and maybe the editor does not want others to see a half finished entry. Actually I had this feature initially and people complained about seing half finished messages in the list. Previously, when there was no "Save" button, new entries where not visible on the list because nothing was submitted at all, and I guess that was ok with you. So would reverting to the old functionality via "autosave = 0" make you happy? Of course you then loose the autosave functionality. So if people enter a long entry, and surf away from the page or the browser crashes, the entry is lost.
Devin Bougie wrote: |
Thanks, Andreas. I was aware of the "pending draft" menu, and I am aware that you can manually browse to an entry even if it doesn't appear in the list. However, for our operations group it is a requirement that any saved entry appears in the list, even if it's in the process of being edited. We won't be able to upgrade until this is possible.
Previous releases didn't have this problem, so hopefully it won't be too difficult to address with a new configuration option. Please let me know if there's something I should do to submit an official feature request / bug report.
Thanks again,
Devin
Andreas Luedeke wrote: |
Hi Devin,
this is the intended bevaviour, there is nothing wrong with that.
Only a submitted entry should be visible to the world.
If you would have played a little bit longer, you would have found out yourself how you'll get access again to this so-called "draft" entry after closing the browser window:
as soon as you attempt to create - as the same user - an new entry, you'll be asked if you want to continue editing your old draft entry instead.
I've attached a screenshot of this "pending draft" menu, as it has been shown for this entry before I've submitted it.
Kind Regards, Andreas
PS: You gave a very clear "failure" description: what you did, what you expected to happen and what you've observed what happened instead. Well done: that deserves a swift answer! 
Devin Bougie wrote: |
When an entry is being edited, it does not appear in the list once it's been autosaved or the editor manually clicks on "Save." This has been reproduced in the "Linux Demo" forum on this site, as well as on a clean installation of the 3.1.1 binary on EL6.
It would be great if there was a configuraiton option to control this, but I haven't found it yet. To reproduce:
- edit an existing entry
- click on "Save"
- view the list for that logbook, and the entry will be hidden until you click "Submit"
Obviously this becomes a problem when a user edits an entry, but navigates away from the browser window before submitting the changes.
Any suggestions would be greatly appreciated.
Many thanks,
Devin
|
|
|
|
|
68245
|
Wed Jan 27 21:33:53 2016 |
| Devin Bougie | devin.bougie@cornell.edu | Bug report | Linux | 3.1.1 | attachments created using "Image" button can not be clicked-on and do not appear in the attachment table. | This has been confirmed usign the Demo forum on this server. For example, please see https://midas.psi.ch/elogs/Linux+Demo/8
When an image is attached using the "Image" button in the CKEditor, that image does not appear in the attachment table for that entry. In addition, the image can not be clicked on to view the full image.
This was not the case in v2.9.2, at least.
Is there some configuration option I could toggle to change this behaviour? By default, we would like any attachment (whether it's made using drag and drop, the Image button, or the "Choose File" button) to appear in the attachment table *and* be clickable to view the full image.
Thanks,
Devin |
68246
|
Thu Jan 28 20:02:06 2016 |
| Devin Bougie | devin.bougie@cornell.edu | Bug report | Linux | 3.1.1 | Re: attachments created using "Image" button can not be clicked-on and do not appear in the attachment table. | As there appears to be some inconsistencies, I thought I'd document the behaviour of each of the attachment options.
------
1. Click on the "Image" button in the CKEditor, click on "Choose File" and browse to the file, click on "Send it to the Server", and click "OK".
- The image appears inline at the configured "Thumbnail size", but it is not clickable and it does not appear in the attachment table when viewing the entry.
2. Drag and drop an image into the body of the message.
- The image appears inline at the configured "Thumbnail size" and is clickable. As with "1," however, it does not appear in the attachment table when viewing the entry.
3. Drag and drop an image into the "Drop attachments here ..." section.
- The image appears in the attachment table at the configured Thumbnail Size, and is clickable.
4. From the attachment table, click on "Choose File" and then click on "Upload."
- The image appears in the attachment table at the configured Thumbnail Size, and is clickable.
------
We need to make sure the images are always clickable so that you can always view the full-sized image. Any suggestions for fixing this, short of reverting to v2.9.2, would be greatly appreciated.
Thanks again,
Devin
Devin Bougie wrote: |
This has been confirmed usign the Demo forum on this server. For example, please see https://midas.psi.ch/elogs/Linux+Demo/8
When an image is attached using the "Image" button in the CKEditor, that image does not appear in the attachment table for that entry. In addition, the image can not be clicked on to view the full image.
This was not the case in v2.9.2, at least.
Is there some configuration option I could toggle to change this behaviour? By default, we would like any attachment (whether it's made using drag and drop, the Image button, or the "Choose File" button) to appear in the attachment table *and* be clickable to view the full image.
Thanks,
Devin
|
|
68269
|
Fri Feb 26 17:20:52 2016 |
| Devin Bougie | devin.bougie@cornell.edu | Bug report | Linux | 3.1.1 | Links to images in notification message | We see two problems with the notificaiton email when attaching an image inline using drag-and-drop.
- The thumbnail does not appear in its proper location inline. There is a ? placeholder where the thumbnail should be, and the thumbnail then appears at the end of the message.
- Neither the ? placeholder nor the thumbnail that do appear are clickable.
Our v2.9.2 test installation exhibits the desired behavior.
- The thumbnail appears in its correct location inline.
- If you click on the thumbnail, you arrive at a URL displaying the full size image.
I am not able to drag-and-drop into the body of this message to test the behavior here. I am attaching a screenshot showing an example of the problem from our server.
Any suggestions would be greatly appreciated.
Many thanks,
Devin
|
Attachment 1: screenshot.png
|
|
68270
|
Fri Feb 26 17:35:54 2016 |
| Juergen Diefenbach | diefenba@uni-mainz.de | Bug report | Linux | 3.1.1 | Execute new|edit doesn't seem to work | I am trying to use the "Execute new|edit|delete" feature to track changes to an elog using git.
When a new entry is created a shell script should be executed (certain attributes of the logbook entry should be passed as arguments to it). The script will then automatically stage all changes and create an appropriate git commit message. For a "new" entry in the logbook the commit message is a bit more verbose. When editing or deleting a message only a short commit message like "Edit message 25" should be created. Therefore I really need to distinguish between "new", "edit", and "delete".
However, I experienced unreproducible behavior when creating "new" entries. Sometimes the command specified by "Execute new=" is called, sometimes the one specified by "Execute edit=" is executed. Most of the time it doesn't work as expected. 
What I did so far to understand what goes wrong is I looked into elogd.c and found invoid submit_elog(LOGBOOK * lbs) that bedit is sometimes true and sometimes false, when creating a new entry, although it should be false then (right?).
This is why elogd then sometimes retrieves the wrong shell command from getcfg(lbs->name, "Execute edit"...) instead of getcfg(lbs->name, "Execute new"...) around line 23610 (not exact due to some eprintf()s inserted here and there to look at bedit and so on).
When deleting an entry, everything works fine: the shell command defined via "Execute delete=" is run, but this happens somewhere else in the code so it's not a surprise.
Do you have an idea how to fix this or can you point me in some direction to further track it down? Thank you! |
68271
|
Fri Feb 26 18:11:14 2016 |
| Devin Bougie | devin.bougie@cornell.edu | Bug report | Linux | 3.1.1 | Re: Links to images in notification message | From the notification I received, it looks like "2" is a problem with this server. In the email notification, we would like images to be a link to a URL displaying the full-size image (as they are in v2.9.2).
Thanks,
Devin |
68272
|
Sun Feb 28 18:24:58 2016 |
| Andreas Luedeke | andreas.luedeke@psi.ch | Bug report | Linux | 3.1.1 | Re: Execute new|edit doesn't seem to work |
Juergen Diefenbach wrote: | I am trying to use the "Execute new|edit|delete" feature to track changes to an elog using git.
[...]
However, I experienced unreproducible behavior when creating "new" entries. Sometimes the command specified by "Execute new=" is called, sometimes the one specified by "Execute edit=" is executed. Most of the time it doesn't work as expected. 
[...]
Do you have an idea how to fix this or can you point me in some direction to further track it down? Thank you! |
I'm just guessing, but you could try to disable the "save drafts" feature and see if the behaviour changes:
Save drafts = 0
If that is the case then Stefan will know where to look 
Cheers
Andreas |
|