Demo Discussion
Forum Config Examples Contributions Vulnerabilities
  Discussion forum about ELOG, Page 375 of 808  Not logged in ELOG logo
 Find |  Login |  Help 
 Full | Summary | Threaded | Hide attachments  Show only new entries    6457 Entries 
Goto page Previous  1, 2, 3 ... 374, 375, 376 ... 806, 807, 808   Next  
ID Date Icon Author Author Email Category OSdown ELOG Version Subject
  1286   Wed Jul 20 22:28:14 2005 Reply Stefan Rittstefan.ritt@psi.chBug reportLinuxrev 1.703Re: Display Subject and HTML tags, regression

Emiliano Gabrielli wrote:
rev 1.703 makes the following code not to work:
Display Subject               = <b>$subject</b>

the <b> tag is displayed and not interpreted, as it was in previous revisions..


rev. 1.707 makes it work again Big grin
  1287   Wed Jul 20 22:39:05 2005 Reply Stefan Rittstefan.ritt@psi.chBug reportLinuxrev 1.703Re: Display Subject and HTML tags, regression

Emiliano Gabrielli wrote:

Emiliano Gabrielli wrote:
rev 1.703 makes the following code not to work:
Display Subject               = <b>$subject</b>

the <b> tag is displayed and not interpreted, as it was in previous revisions..


this patch should fix the problem .. a little bug still remain, if you insert some allowed HTML tags in the subject this is detected by is_html() so the Display Attribute and the Link is not applied .. the result is that the HTML is working but no elog featur is applied


Your line
if (p && strchr(str, '>') && p >= str && *(p-1) != '\\')

in the code does not work. If the pattern is at the beginning of the string (p == str), then (p-1) points to an invalid location and can cause a segmentation fault. The correct patch is in CVS.
  1288   Wed Jul 20 23:24:59 2005 Reply Stefan Rittstefan.ritt@psi.chRequestLinuxV2.6.0Re: hide attributes when view the logbook

Juliana Peng wrote:
but it seems only effective when adding the new entry. All the attributes will show in logbook. Is there a way to hide some of the attributes? It would be good to let each user to choose what to see what not to see, create their own view. Can you put it on your to-do list or wishlist?


I implemented your request and committed to CVS. Please test if it does what you want, since I did not have much time to test it.
  1293   Thu Jul 21 11:00:47 2005 Reply Emiliano GabrielliAlberT@SuperAlberT.itBug reportLinuxrev 1.703Re: Display Subject and HTML tags, regression

Stefan Ritt wrote:

Emiliano Gabrielli wrote:
rev 1.703 makes the following code not to work:
Display Subject               = <b>$subject</b>

the <b> tag is displayed and not interpreted, as it was in previous revisions..


rev. 1.707 makes it work again Big grin


ok, nice Smile
  1294   Thu Jul 21 11:02:44 2005 Reply Emiliano GabrielliAlberT@SuperAlberT.itBug reportLinuxrev 1.703Re: Display Subject and HTML tags, regression

Stefan Ritt wrote:

Emiliano Gabrielli wrote:

Emiliano Gabrielli wrote:
rev 1.703 makes the following code not to work:
Display Subject               = <b>$subject</b>

the <b> tag is displayed and not interpreted, as it was in previous revisions..


this patch should fix the problem .. a little bug still remain, if you insert some allowed HTML tags in the subject this is detected by is_html() so the Display Attribute and the Link is not applied .. the result is that the HTML is working but no elog featur is applied


Your line
if (p && strchr(str, '>') && p >= str && *(p-1) != '\\')

in the code does not work. If the pattern is at the beginning of the string (p == str), then (p-1) points to an invalid location and can cause a segmentation fault. The correct patch is in CVS.


ehhe, I used "should" infact Tongue
  1298   Fri Jul 22 17:21:15 2005 Reply Juliana Pengjpeng@yorku.caRequestLinuxV2.6.0Re: hide attributes when view the logbook

Stefan Ritt wrote:

Juliana Peng wrote:
but it seems only effective when adding the new entry. All the attributes will show in logbook. Is there a way to hide some of the attributes? It would be good to let each user to choose what to see what not to see, create their own view. Can you put it on your to-do list or wishlist?


I implemented your request and committed to CVS. Please test if it does what you want, since I did not have much time to test it.


Thanks so much. But the new feature seems not working. If my conf is:

Options OS = SunOs{1}, Linux{2}, Aix
{1} Show Attributes = Name, SysAdmin, OS, Manufacturer, Model, Serial Number, Description

When I choose linux OS, is it supposed to get only the attributes in "Show Attributes"? All the attributes show up. Or you implemented it in other way?
  1299   Fri Jul 22 17:54:41 2005 Reply Juliana Pengjpeng@yorku.caRequestLinuxV2.6.0Re: hide attributes when view the logbook

Juliana Peng wrote:

Stefan Ritt wrote:

Juliana Peng wrote:
but it seems only effective when adding the new entry. All the attributes will show in logbook. Is there a way to hide some of the attributes? It would be good to let each user to choose what to see what not to see, create their own view. Can you put it on your to-do list or wishlist?


I implemented your request and committed to CVS. Please test if it does what you want, since I did not have much time to test it.


Thanks so much. But the new feature seems not working. If my conf is:

Options OS = SunOs{1}, Linux{2}, Aix
{1} Show Attributes = Name, SysAdmin, OS, Manufacturer, Model, Serial Number, Description

When I choose linux OS, is it supposed to get only the attributes in "Show Attributes"? All the attributes show up. Or you implemented it in other way?


Sorry, I mean choose SunOs
  1300   Fri Jul 22 22:45:37 2005 Reply Stefan Rittstefan.ritt@psi.chRequestLinuxV2.6.0Re: hide attributes when view the logbook

Juliana Peng wrote:
Thanks so much. But the new feature seems not working.


Are you sure you got the latest CVS version and recompiled correctly?

I tried with following config:
[global]
port = 8080

[demo]
Attributes = Name, SysAdmin, OS, Manufacturer, Model, Serial Number, Description, Main Function, Location, Memory, CPU Speed, Num CPU, Owner, Contact Name, Contact Phone, Contact Email, Bought From, Bought Date, Maintenance, Network Drop, Console Drop
Options OS = SunOs{1}, Linux{2}, Aix
{1} Show Attributes = Name, SysAdmin, OS, Manufacturer, Model, Serial Number, Description

Then I added two entries, where OS = SunOS and Aix. As soon as I select SunOS, the attributes except those listed in {1} disappear. The same is true then for the single entry display. Here is the one with the Aix:



and here with SunOS:



So can you reproduce this?
Goto page Previous  1, 2, 3 ... 374, 375, 376 ... 806, 807, 808   Next  
ELOG V3.1.5-3fb85fa6