Demo Discussion
Forum Config Examples Contributions Vulnerabilities
  Discussion forum about ELOG, Page 59 of 808  Not logged in ELOG logo
ID Date Icon Author Author Email Category OS ELOG Version Subject
  69404   Mon Oct 25 13:34:06 2021 Reply Stefan Rittstefan.ritt@psi.chQuestionLinux3.1.4 Re: Too many open files - issue?

The code segements you show are from the command line tool elog.c, not the server elogd.c. The tool is called to submit a new message from the command line. Even if there would be a file not properly closed, it will be closed by the operating system once the program finishes. So no problem of too many open files there.

Rob Calkins wrote:

Has anyone had issues with having too many files open? I'll setup my server and let it go but after a while, I end up with a lot of "cannot create socket: Too many open files" errors being reported.  I have a sync to another e-log going which I suspect is part of the cause since that e-log server hasn't had this issue. I suspect that there are files being opened, going into some return loop code and then never getting closed. I'm not a C programmer but I see lines like :

fh = open(tmp_filename, O_RDONLY);
      if (fh > 0) {
         read(fh, result, size - 1);
         close(fh);
      }

      /* remove temporary file */
      remove(tmp_filename);

This looks like it opens the file but unless the remove function closes the file, it will remain open even through the file has been deleted. Maybe this isn't the correct behaviour of 'remove' and I am mistaken?

There are also parts like :

 fh = open(textfile, O_RDONLY | O_BINARY);
      if (fh < 0) {
         printf("Message file \"%s\" does not exist.\n", textfile);
         return 1;
      }

      size = (INT) lseek(fh, 0, SEEK_END);
      lseek(fh, 0, SEEK_SET);

      if (size > (INT) (sizeof(text) - 1)) {
         printf("Message file \"%s\" is too long (%zd bytes max).\n", textfile, sizeof(text));
         return 1;
      }

This looks like for the second error, it will complain that the file is too long, return an error message but not close the file and would leave it open. Is this a reasonable avenue to pursue or am I mis-reading the code?   Thanks.

 

  1489   Fri Oct 28 12:15:33 2005 Question Yoshio ImaiQuestionLinux2.6.0beta5Display last page by default
Hi again!
I have one question concerning the logbook configuration. Normally, clicking on "List" takes me to the first page of the list view. Is it possible to configure the logbook so that "List" takes me to the last page instead?

Yoshio
  1489   Fri Oct 28 12:15:33 2005 Question Yoshio ImaiQuestionLinux2.6.0beta5Display last page by default
Hi again!
I have one question concerning the logbook configuration. Normally, clicking on "List" takes me to the first page of the list view. Is it possible to configure the logbook so that "List" takes me to the last page instead?

Yoshio
  1489   Fri Oct 28 12:15:33 2005 Question Yoshio ImaiQuestionLinux2.6.0beta5Display last page by default
Hi again!
I have one question concerning the logbook configuration. Normally, clicking on "List" takes me to the first page of the list view. Is it possible to configure the logbook so that "List" takes me to the last page instead?

Yoshio
  1489   Fri Oct 28 12:15:33 2005 Question Yoshio ImaiQuestionLinux2.6.0beta5Display last page by default
Hi again!
I have one question concerning the logbook configuration. Normally, clicking on "List" takes me to the first page of the list view. Is it possible to configure the logbook so that "List" takes me to the last page instead?

Yoshio
  1489   Fri Oct 28 12:15:33 2005 Question Yoshio ImaiQuestionLinux2.6.0beta5Display last page by default
Hi again!
I have one question concerning the logbook configuration. Normally, clicking on "List" takes me to the first page of the list view. Is it possible to configure the logbook so that "List" takes me to the last page instead?

Yoshio
  1489   Fri Oct 28 12:15:33 2005 Question Yoshio ImaiQuestionLinux2.6.0beta5Display last page by default
Hi again!
I have one question concerning the logbook configuration. Normally, clicking on "List" takes me to the first page of the list view. Is it possible to configure the logbook so that "List" takes me to the last page instead?

Yoshio
  1489   Fri Oct 28 12:15:33 2005 Question Yoshio ImaiQuestionLinux2.6.0beta5Display last page by default
Hi again!
I have one question concerning the logbook configuration. Normally, clicking on "List" takes me to the first page of the list view. Is it possible to configure the logbook so that "List" takes me to the last page instead?

Yoshio
ELOG V3.1.5-3fb85fa6