| ID |
Date |
Icon |
Author |
Author Email |
Category |
OS |
ELOG Version |
Subject |
|
1379
|
Fri Aug 5 02:27:15 2005 |
 | Chris Green | greenc@fnal.gov | Bug report | Linux | 2.6.0-CVS | Top Groups, Show Top Groups, password file and Protect Selection page have nasty interaction | Hi,
Just as our ELOG went into production, I tripped over a couple of related (I think) bugs.
First, the easy one: line 21368 of src/elogd.c has a compile warning which looks non-benign. I fixed it in my local copy with:
Index: elogd.c
===================================================================
RCS file: /usr/local/cvsroot/elog/src/elogd.c,v
retrieving revision 1.739
diff -r1.739 elogd.c
21368,21369c21368
< sprintf(str, "?fail=1", user);
< redirect(lbs, str);
---
> redirect(lbs, "?fail=1");
Regardless (ie if I use the original CVS code or the patched version), a hard-to trace problem occurs with my configuration whereby users are denied access after password entry at the logbook selection page (even when details are verifiably correct), and users are dropped through to the next (non-protected) Top Group page. This problem goes away if "Protect Selection Page" is turned off.
A kind of "shadow" of this problem occurs if you create a new logbook from the Change Config File page, whereby after creating the new logbook one is dropped through to the next Top Group's selection page after saving the configuration (and the url has ?fail=1 added to it, althoguh line 21368 above is hardly the only place where this could have occurred).
I think all these things are linked. I'd be grateful if you could review this section of this code for possible causes of these problems. While we can operate for now with non-logged-in users able to see our list of logbooks, that is not something we want for the long term.
Thanks for your help,
Chris. |
|
1385
|
Fri Aug 5 12:06:47 2005 |
 | Stefan Ritt | stefan.ritt@psi.ch | Bug report | Linux | 2.6.0-CVS | Re: Top Groups, Show Top Groups, password file and Protect Selection page have nasty interaction |
| Chris Green wrote: | Index: elogd.c
===================================================================
RCS file: /usr/local/cvsroot/elog/src/elogd.c,v
retrieving revision 1.739
diff -r1.739 elogd.c
21368,21369c21368
< sprintf(str, "?fail=1", user);
< redirect(lbs, str);
---
> redirect(lbs, "?fail=1");
|
Thanks, applied.
| Chris Green wrote: | | Regardless (ie if I use the original CVS code or the patched version), a hard-to trace problem occurs with my configuration whereby users are denied access after password entry at the logbook selection page (even when details are verifiably correct), and users are dropped through to the next (non-protected) Top Group page. This problem goes away if "Protect Selection Page" is turned off. |
I hope I have fixed this problem, at least it works ok here when I tried with your config file.
One note I would like to make however: "Top groups" were invented for having completely separate logbook groups. Before the invention of top groups, one had to run several instances of elogd for different departments for example, where one department should not see the other department's logbooks. But having many departments means having to maintain many elogd daemons. This led to the invention of top groups, so one daemon can serve several independent groups, each having their own [global] section, with probably their own administrator.
In your case however, it would be more applicable not to use top groups, but use nested groups. Like
Group MiniBooNE = Analysis, Miscellaneous
Group Analysis = Charged Current Pi Plus, Neutral Current Coherent Pions
Group Miscellaneous = demo
I presume this is more what you want, and you can avoid some problems which arise from top groups.
| Chris Green wrote: | | A kind of "shadow" of this problem occurs if you create a new logbook from the Change Config File page, whereby after creating the new logbook one is dropped through to the next Top Group's selection page after saving the configuration (and the url has ?fail=1 added to it, althoguh line 21368 above is hardly the only place where this could have occurred). |
I have not tested this one, but it could well be that the modification I made also fixes this. |
|
1388
|
Fri Aug 5 16:15:04 2005 |
 | Chris Green | greenc@fnal.gov | Bug report | Linux | 2.6.0-CVS | Re: Top Groups, Show Top Groups, password file and Protect Selection page have nasty interaction |
| Stefan Ritt wrote: | One note I would like to make however: "Top groups" were invented for having completely separate logbook groups. Before the invention of top groups, one had to run several instances of elogd for different departments for example, where one department should not see the other department's logbooks. But having many departments means having to maintain many elogd daemons. This led to the invention of top groups, so one daemon can serve several independent groups, each having their own [global] section, with probably their own administrator.
In your case however, it would be more applicable not to use top groups, but use nested groups. Like
Group MiniBooNE = Analysis, Miscellaneous
Group Analysis = Charged Current Pi Plus, Neutral Current Coherent Pions
Group Miscellaneous = demo
I presume this is more what you want, and you can avoid some problems which arise from top groups.
|
The quick attempt I just made to use this doesn't do what I want, which is to require password protection for the Analysis logbook selection page. If you think that *is* possible and I just didn't configure it properly, I'd appreciate pointers. In the meantime though, your bug fixes appear to have solved my top group / password problem and I think I'll proceed with that for now.
Thanks again,
Chris. |
|
1392
|
Fri Aug 5 16:51:02 2005 |
| Stefan Ritt | stefan.ritt@psi.ch | Bug report | Linux | 2.6.0-CVS | Re: Top Groups, Show Top Groups, password file and Protect Selection page have nasty interaction |
| Chris Green wrote: | | The quick attempt I just made to use this doesn't do what I want, which is to require password protection for the Analysis logbook selection page. |
This indeed is not possible and you have to use top groups for that. |
|
1506
|
Tue Nov 15 08:35:33 2005 |
 | Oleg Solovyanov | Oleg.Solovyanov@ihep.ru | Bug report | Linux | 2.6.0-4 | page2?cmd=List does not show next page | Maybe I'm doing something wrong, but the following does not work on a Elog with multiple pages:
1. View message
2. Click List
3. Click Next or page number
4. Only the last page is shown
It looks like the URL pageN?cmd=List does not work, while pageN works.
Any hints?
Same behaviour can be seen also with Discussion forum on Elog site. |
|
1507
|
Tue Nov 15 08:40:31 2005 |
| Stefan Ritt | stefan.ritt@psi.ch | Bug report | Linux | 2.6.0-4 | Re: page2?cmd=List does not show next page |
| Oleg Solovyanov wrote: | Maybe I'm doing something wrong, but the following does not work on a Elog with multiple pages:
1. View message
2. Click List
3. Click Next or page number
4. Only the last page is shown
It looks like the URL pageN?cmd=List does not work, while pageN works.
Any hints?
Same behaviour can be seen also with Discussion forum on Elog site. |
I don't understand. I tried on the Discussion forum:
1. View message, for example http://midas.psi.ch/elogs/Forum/1506
2. Click List, which takes me to http://midas.psi.ch/elogs/Forum/
3. Click Next, which takes me to http://midas.psi.ch/elogs/Forum/page2
Then I really see page2, not the last page. So what do you do differently? |
|
1510
|
Wed Nov 16 15:24:53 2005 |
| Oleg Solovyanov | Oleg.Solovyanov@ihep.ru | Bug report | Linux | 2.6.0-4 | Re: page2?cmd=List does not show next page |
| Stefan Ritt wrote: |
| Oleg Solovyanov wrote: | Maybe I'm doing something wrong, but the following does not work on a Elog with multiple pages:
1. View message
2. Click List
3. Click Next or page number
4. Only the last page is shown
It looks like the URL pageN?cmd=List does not work, while pageN works.
Any hints?
Same behaviour can be seen also with Discussion forum on Elog site. |
I don't understand. I tried on the Discussion forum:
1. View message, for example http://midas.psi.ch/elogs/Forum/1506
2. Click List, which takes me to http://midas.psi.ch/elogs/Forum/
3. Click Next, which takes me to http://midas.psi.ch/elogs/Forum/page2
Then I really see page2, not the last page. So what do you do differently? |
Somehow in my logbooks List command would add cmd=List to the URL
And this does not work... |
|
1511
|
Wed Nov 16 15:27:40 2005 |
| Stefan Ritt | stefan.ritt@psi.ch | Bug report | Linux | 2.6.0-4 | Re: page2?cmd=List does not show next page |
| Oleg Solovyanov wrote: | Somehow in my logbooks List command would add cmd=List to the URL
And this does not work... |
You use an old version of elog. Please upgrade to the 2.6.0-beta5 which you can obtain from
http://savannah.psi.ch/viewcvs/trunk/src/elogd.c?root=elog&rev=1541 |
|