| ID |
Date |
Icon |
Author |
Author Email |
Category |
OS |
ELOG Version |
Subject |
|
1379
|
Fri Aug 5 02:27:15 2005 |
 | Chris Green | greenc@fnal.gov | Bug report | Linux | 2.6.0-CVS | Top Groups, Show Top Groups, password file and Protect Selection page have nasty interaction | Hi,
Just as our ELOG went into production, I tripped over a couple of related (I think) bugs.
First, the easy one: line 21368 of src/elogd.c has a compile warning which looks non-benign. I fixed it in my local copy with:
Index: elogd.c
===================================================================
RCS file: /usr/local/cvsroot/elog/src/elogd.c,v
retrieving revision 1.739
diff -r1.739 elogd.c
21368,21369c21368
< sprintf(str, "?fail=1", user);
< redirect(lbs, str);
---
> redirect(lbs, "?fail=1");
Regardless (ie if I use the original CVS code or the patched version), a hard-to trace problem occurs with my configuration whereby users are denied access after password entry at the logbook selection page (even when details are verifiably correct), and users are dropped through to the next (non-protected) Top Group page. This problem goes away if "Protect Selection Page" is turned off.
A kind of "shadow" of this problem occurs if you create a new logbook from the Change Config File page, whereby after creating the new logbook one is dropped through to the next Top Group's selection page after saving the configuration (and the url has ?fail=1 added to it, althoguh line 21368 above is hardly the only place where this could have occurred).
I think all these things are linked. I'd be grateful if you could review this section of this code for possible causes of these problems. While we can operate for now with non-logged-in users able to see our list of logbooks, that is not something we want for the long term.
Thanks for your help,
Chris. |
|
1380
|
Fri Aug 5 09:19:02 2005 |
 | Emiliano Gabrielli | AlberT@SuperAlberT.it | Bug report | Linux | 2.5.9+r16 | Re: problem with list display attribute |
| Stefan Ritt wrote: |
| John Habermann wrote: | I not sure if this has been found and fixed as I did find something to do with the list display attribute in the forums but wasn't sure if it was the same thing.
There seems to be a bug with the List Display attribute in that it drops the last attribute of the list. So in my example if I want to display the Subject in my list I have to add a dummy attribute after it otherwise the Subject will not be displayed. The comma after Subject is not enough, but all you have to do is to add 1 letter and then you will see the subject in List view. If you don't all I see is the Date and Author fields and then the Text field in my Summary view in the log book.
List Display = Date,Author,Subject,t
I am running elog 2.5.9+r1674-1 on Debian sarge. |
I tried with the current 2.6.0-beta3 and it worked fine. Can you send me your full elogd.cfg in order to reproduce the problem? |
it is the pippo bug...
it was fixed in revision 1.675, just the next he was using...
it is discussed in elog:1170 |
|
1385
|
Fri Aug 5 12:06:47 2005 |
| Stefan Ritt | stefan.ritt@psi.ch | Bug report | Linux | 2.6.0-CVS | Re: Top Groups, Show Top Groups, password file and Protect Selection page have nasty interaction |
| Chris Green wrote: | Index: elogd.c
===================================================================
RCS file: /usr/local/cvsroot/elog/src/elogd.c,v
retrieving revision 1.739
diff -r1.739 elogd.c
21368,21369c21368
< sprintf(str, "?fail=1", user);
< redirect(lbs, str);
---
> redirect(lbs, "?fail=1");
|
Thanks, applied.
| Chris Green wrote: | | Regardless (ie if I use the original CVS code or the patched version), a hard-to trace problem occurs with my configuration whereby users are denied access after password entry at the logbook selection page (even when details are verifiably correct), and users are dropped through to the next (non-protected) Top Group page. This problem goes away if "Protect Selection Page" is turned off. |
I hope I have fixed this problem, at least it works ok here when I tried with your config file.
One note I would like to make however: "Top groups" were invented for having completely separate logbook groups. Before the invention of top groups, one had to run several instances of elogd for different departments for example, where one department should not see the other department's logbooks. But having many departments means having to maintain many elogd daemons. This led to the invention of top groups, so one daemon can serve several independent groups, each having their own [global] section, with probably their own administrator.
In your case however, it would be more applicable not to use top groups, but use nested groups. Like
Group MiniBooNE = Analysis, Miscellaneous
Group Analysis = Charged Current Pi Plus, Neutral Current Coherent Pions
Group Miscellaneous = demo
I presume this is more what you want, and you can avoid some problems which arise from top groups.
| Chris Green wrote: | | A kind of "shadow" of this problem occurs if you create a new logbook from the Change Config File page, whereby after creating the new logbook one is dropped through to the next Top Group's selection page after saving the configuration (and the url has ?fail=1 added to it, althoguh line 21368 above is hardly the only place where this could have occurred). |
I have not tested this one, but it could well be that the modification I made also fixes this. |
|
1388
|
Fri Aug 5 16:15:04 2005 |
 | Chris Green | greenc@fnal.gov | Bug report | Linux | 2.6.0-CVS | Re: Top Groups, Show Top Groups, password file and Protect Selection page have nasty interaction |
| Stefan Ritt wrote: | One note I would like to make however: "Top groups" were invented for having completely separate logbook groups. Before the invention of top groups, one had to run several instances of elogd for different departments for example, where one department should not see the other department's logbooks. But having many departments means having to maintain many elogd daemons. This led to the invention of top groups, so one daemon can serve several independent groups, each having their own [global] section, with probably their own administrator.
In your case however, it would be more applicable not to use top groups, but use nested groups. Like
Group MiniBooNE = Analysis, Miscellaneous
Group Analysis = Charged Current Pi Plus, Neutral Current Coherent Pions
Group Miscellaneous = demo
I presume this is more what you want, and you can avoid some problems which arise from top groups.
|
The quick attempt I just made to use this doesn't do what I want, which is to require password protection for the Analysis logbook selection page. If you think that *is* possible and I just didn't configure it properly, I'd appreciate pointers. In the meantime though, your bug fixes appear to have solved my top group / password problem and I think I'll proceed with that for now.
Thanks again,
Chris. |
|
1392
|
Fri Aug 5 16:51:02 2005 |
| Stefan Ritt | stefan.ritt@psi.ch | Bug report | Linux | 2.6.0-CVS | Re: Top Groups, Show Top Groups, password file and Protect Selection page have nasty interaction |
| Chris Green wrote: | | The quick attempt I just made to use this doesn't do what I want, which is to require password protection for the Analysis logbook selection page. |
This indeed is not possible and you have to use top groups for that. |
|
1397
|
Wed Aug 10 18:32:14 2005 |
 | Oleg Solovyanov | Oleg.Solovyanov@ihep.ru | Bug report | Linux | 2.6.0-b4 | Comment tooltip shows comment from other logbook | I have several logbooks with Comment lines,
but the tooltip shows sometimes the correct comment,
sometimes the comment from other logbook...
I see the same behaviour also on this very page...
I use Mozilla 1.7.10.
Tried with Konqueror -> same problem. |
|
1400
|
Wed Aug 31 22:02:46 2005 |
 | Martin Lindjärv | martin.lindjarv@emta.ee | Bug report | Windows | V2.5.9-4 | password forgot kills elogd | Hi!
At first, thanx for this software!
But i found a bug or something like that. I installed elog on win2003 and winxp with default settings. And everywhere i had same problem - when forgot password is used it kills elogd. Error what is reported in EventLog is "Faulting application elogd.exe, version 0.0.0.0, faulting module elogd.exe, version 0.0.0.0, fault address 0x0002f1ee." and thats all. For testing tried newest beta too but it seems to have same problem.
i can insert my email address and when i click submit it wait's for some time and then gives 404.
Any kind of info would be good... |
|
1401
|
Wed Aug 31 22:03:04 2005 |
| Martin Lindjärv | martin.lindjarv@emta.ee | Bug report | Windows | V2.5.9-4 | password forgot kills elogd | Hi!
At first, thanx for this software!
But i found a bug or something like that. I installed elog on win2003 and winxp with default settings. And everywhere i had same problem - when forgot password is used it kills elogd. Error what is reported in EventLog is "Faulting application elogd.exe, version 0.0.0.0, faulting module elogd.exe, version 0.0.0.0, fault address 0x0002f1ee." and thats all. For testing tried newest beta too but it seems to have same problem.
i can insert my email address and when i click submit it wait's for some time and then gives 404.
But tried under linux (gentoo) and everything works like charm.
Any kind of info would be good... |
|