Demo Discussion
Forum Config Examples Contributions Vulnerabilities
  Discussion forum about ELOG, Page 632 of 808  Not logged in ELOG logo
ID Date Icon Author Author Email Category OS ELOG Versiondown Subject
  1189   Thu Jun 9 15:20:04 2005 Warning Heiko Scheith.scheit@mpi-hd.mpg.deBug reportLinux2.5.9Re: elog crashes when admin tries to register new users

Stefan Ritt wrote:

Heiko Scheit wrote:
When pasting the URL for the registration of new users (with 'Self register = 3') elog
crashes with segmentation fault. I don't have the time currently to give you more
debuging information but maybe you can have a look the same. It crashes after
the user is registered. The Email is sent, too.


I cannot reproduce this problem either. The only difference I see is that I use thunderbird as my email client, where I don't have to copy/paste the activation URL into my browser, but just click on it. If maybe the copy/paste operation adds an additional CR/LF or so, that could be a problem. Can you check again? A stack trace of the crashed elogd would help as well.


The following appended after the base (!) URL results in a segmentation fault
?cmd=Activate&new_user_name=test1&new_full_name=Test1

It works fine, if a specific logbook is given. So
http://my.ho.st/?cmd=Activate&new_user_name=test1&new_full_name=Test1
is not OK, while
http://my.ho.st/myLogBook/?cmd=Activate&new_user_name=test1&new_full_name=Test1
is OK.
  1195   Thu Jun 16 22:37:06 2005 Reply Stefan Rittstefan.ritt@psi.chBug reportLinux2.5.9Re: reverse sort option does not work for quick filter
I finally found some time to fix this problem. The fix is under CVS.
  1198   Fri Jun 17 22:33:29 2005 Reply Stefan Rittstefan.ritt@psi.chBug reportLinux2.5.9Re: elog crashes when admin tries to register new users

Heiko Scheit wrote:
The following appended after the base (!) URL results in a segmentation fault
?cmd=Activate&new_user_name=test1&new_full_name=Test1

It works fine, if a specific logbook is given. So
http://my.ho.st/?cmd=Activate&new_user_name=test1&new_full_name=Test1
is not OK, while
http://my.ho.st/myLogBook/?cmd=Activate&new_user_name=test1&new_full_name=Test1
is OK.


Thanks for that info. It helped me debugging things. The problem is that the "activation" URL does not contain a logbook if there is a global password file. I have never tried that so of course it crashes Crying

I tried to fix this and committed the changes to CVS. Can you try with that version?
  1206   Tue Jun 21 19:24:58 2005 Reply Heiko Scheith.scheit@mpi-hd.mpg.deBug reportLinux2.5.9Re: elog crashes when admin tries to register new users

Quote:

Thanks for that info. It helped me debugging things. The problem is that the "activation" URL does not contain a logbook if there is a global password file. I have never tried that so of course it crashes Crying

I tried to fix this and committed the changes to CVS. Can you try with that version?


Not really, unless you have a fixed 2.5.9 version. Version 2.6 has
way too many new features, which I don't want at the moment. Or is
there a config option to get the old behavior?

I also saw that the format of the email notification has changed. As
I have scripts (bash, akw, procmail) that depend on this format I
would need much more time than I currently have to actually test
everything.

Maybe you should consider supporting two branches, say 'stable' (2.5.9
currently) and 'experimental' (2.6 currently)? For 'stable' only
severe bugs and security issues are fixed and in 'experimental' new
features are introduced. What do you say?

For me the risk of upgrading to 2.6 now seems to high, as many people
depend on the logbook.
  1207   Tue Jun 21 19:38:06 2005 Reply Heiko Scheith.scheit@mpi-hd.mpg.deBug reportLinux2.5.9email flagged as spam

Heiko Scheit wrote:

I also saw that the format of the email notification has changed. As
I have scripts (bash, akw, procmail) that depend on this format I
would need much more time than I currently have to actually test
everything.


By the way, the emails I get from the forum are now all flagged as
spam. SpamAssassin is used and Spam-score header is

X-Spam-Score: 4.875 (****) ADDRESS_IN_SUBJECT, BAYES_00,HTML_40_50,
HTML_IMAGE_ONLY_24, HTML_MESSAGE, MIME_HEADER_CTYPE_ONLY,
MIME_HTML_ONLY, MSGID_FROM_MTA_HEADER, MSGID_FROM_MTA_ID,
NO_REAL_NAME, SPF_FAIL, SPF_HELO_PASS, TO_MALFORMED

Maybe you can see what the problem is.
  1212   Fri Jun 24 21:02:05 2005 Reply Stefan Rittstefan.ritt@psi.chBug reportLinux2.5.9Re: elog crashes when admin tries to register new users

Heiko Scheit wrote:
Not really, unless you have a fixed 2.5.9 version. Version 2.6 has
way too many new features, which I don't want at the moment. Or is
there a config option to get the old behavior?

Maybe you should consider supporting two branches, say 'stable' (2.5.9
currently) and 'experimental' (2.6 currently)? For 'stable' only
severe bugs and security issues are fixed and in 'experimental' new
features are introduced. What do you say?


I think elog is such a small project that supporting several branches makes no sense. You can do this if you have several developers, one taking care of each branch. But as you know I'm alone. But what I can do is the following:

  • Have a default switch for the Encoding. So if "default encoding = plain", the "plain" radio button is on by default, so people tend to write plain text rather than ELCoded text.
  • Have either a switch for the email notification, to revert back to the old text format, or have a multipart email message. I saw that outlook sometime does that. One email can contain a "plain" part and an "HTML" part. So you can select in your email reader which one to display. At least thunderbird supports that. But I don't know what your bash scripts say to that, please let me know.


Heiko Scheit wrote:
For me the risk of upgrading to 2.6 now seems to high, as many people
depend on the logbook.


Well, that's why it's called "beta". I first want to make sure that the transition to the new version goes smooth, and nobody's installation gets problems. So the old logbooks should be still readable without any modification, and once I implemented the "dual plain/html" email notification, you should be fine to upgrade. Is that correct?

- Stefan
  1213   Fri Jun 24 21:15:14 2005 Reply Stefan Rittstefan.ritt@psi.chBug reportLinux2.5.9email flagged as spam

Heiko Scheit wrote:

X-Spam-Score: 4.875 (****) ADDRESS_IN_SUBJECT, BAYES_00,HTML_40_50,
HTML_IMAGE_ONLY_24, HTML_MESSAGE, MIME_HEADER_CTYPE_ONLY,
MIME_HTML_ONLY, MSGID_FROM_MTA_HEADER, MSGID_FROM_MTA_ID,
NO_REAL_NAME, SPF_FAIL, SPF_HELO_PASS, TO_MALFORMED

Maybe you can see what the problem is.


Apparently the problem is in the HMTL contents of the email message. I use SpamAssassin 3.0.2 and do not get more than three points, that's why I haven't seen that problem before. It looks to me like reverting back to plain text will remove most of the hits, although not all. What happens if you write an HTML email to yourself, is this then flagged as spam, too? The TO_MALFORMED I have no chance, since I send each notification just once, it contains now ~300 email destination addresses. Since I don't want that everyone sees these addresses, I put a dummy "To:" there ("Omit Email to = 1"), but this is then of course a fake "To:" and triggers the spam filter.
  1259   Mon Jul 11 19:04:38 2005 Warning Heiko Scheith.scheit@mpi-hd.mpg.deBug fixLinux2.5.9elog utility for submission used wrong 'Host:' in POST header
The 'elog' utility for commandline submission used wrong 'Host:' in POST header.
The host listed after 'Host:' should be the host where the server runs, not the 
localhost (see patch below).

$ diff -u elog.c_20050711  elog.c
--- elog.c_20050711     Mon Jul 11 18:54:20 2005
+++ elog.c      Mon Jul 11 18:55:31 2005
@@ -421,7 +421,7 @@
       sprintf(request + strlen(request), "%s/%d?cmd=download", experiment, message_id);
    strcat(request, " HTTP/1.0\r\n");
 
-   sprintf(request + strlen(request), "Host: %s\r\n", host_name);
+   sprintf(request + strlen(request), "Host: %s\r\n", host);
    sprintf(request + strlen(request), "User-Agent: ELOG\r\n");
 
    first = 1;
@@ -872,7 +872,7 @@
    strcat(request, " HTTP/1.0\r\n");
 
    sprintf(request + strlen(request), "Content-Type: multipart/form-data; boundary=%s\r\n", boundary);
-   sprintf(request + strlen(request), "Host: %s\r\n", host_name);
+   sprintf(request + strlen(request), "Host: %s\r\n", host);
    sprintf(request + strlen(request), "User-Agent: ELOG\r\n");
    sprintf(request + strlen(request), "Content-Length: %d\r\n", content_length);
ELOG V3.1.5-3fb85fa6