> Logins work OK if the username/password is valid.  However, if I try to login
> with invalid authentication, the server crashes.  If I turn off the protect
> selection page, then invalid authentication does not crash elogd.

Ok, it's me, Speedy Gonzales again (as Emiliano says... (;-))

I fixed that as well and committed the changes.

Greetings to JLab (I once worked at UVa in Charlottesville...). Is David Abbott
still there?

- Stefan

> > Using 2.5.8, if I set "Protect Selection page" to 1, then elogd seg faults
> > as soon as it is accessed.
> 
> Thanks for reporting this bug. I fixed it and committed the change to CVS.
> 
> - Stefan

That was fast!  I put the elogd.c from the cvs on top of 2.5.8 and now I can run
the server with Protect Selection page=1 again.

Logins work OK if the username/password is valid.  However, if I try to login
with invalid authentication, the server crashes.  If I turn off the protect
selection page, then invalid authentication does not crash elogd.

Thanks, Steve

> > Using 2.5.8, if I set "Protect Selection page" to 1, then elogd seg faults
> > as soon as it is accessed.
> 
> Thanks for reporting this bug. I fixed it and committed the change to CVS.
> 
> - Stefan

wow, who's Speedy Gonzales ?!? :-P

> > Using 2.5.8, if I set "Protect Selection page" to 1, then elogd seg faults
> > as soon as it is accessed.
> 
> Thanks for reporting this bug. I fixed it and committed the change to CVS.
> 
> - Stefan

wow, who's Speedy Gonzales ?!? :-P

> > When an attached image name contains a space in its filename and attachment
> > display is enabled elog builds a wrong url to the image:
> > 
> > http://arcolog.roma2.infn.it:8080/ARCO/050309_170709/peeling+002.jpg
> > 
> > instead of the correct one:
> > 
> > http://arcolog.roma2.infn.it:8080/ARCO/050309_170709_peeling+002.jpg
> 
> This is on purpose. If you want to save an attachment locally and right click on
> the attachment, and select "Save link as..." in your browser, then the default
> file name is taken from the link. If your original file namw was "peeling
> 002.jpg", then you want again the same name, and not "050309_170709_peeling
> 002.jpg, because you would have to delete the date/time part of the file name
> each time which would be annoying. That's why I have chosen to put an artificial
> "/" between the date/time and the original file name. On the elog side, it's
> converted correctly back to the file name.
> 

yes I notice this after posting :-) sorry

> The problem with blanks in attachment names I could not reproduce. See this
> post, which contains an attachment with a blank in it. As you can see, this does
> not crash the server. 

Ok I can confirm this.
The problem arises, for me, when upgrading to the new version of elog having yes
some old entries with attached filenames containing spaces and/or uppercase extensions.

It seems that uploading files with spaces in the name *now* works well... so the
problem should be somewhere in the handling of existing attachments, not rised when
the attachment is uploaded with the current version of elog ... it's quite strange

> Using 2.5.8, if I set "Protect Selection page" to 1, then elogd seg faults
> as soon as it is accessed.

Thanks for reporting this bug. I fixed it and committed the change to CVS.

- Stefan

Using 2.5.8, if I set "Protect Selection page" to 1, then elogd seg faults
as soon as it is accessed.

Under 2.5.7, a login page will come up, and the logbook will work, but only
if a valid username/password is given.  If an invalid login is given, then
elogd crashes.  We have a cron job that periodically restarts elogd if it is
has crashed.

Steve

[global]
logbook tabs = 0
port = 8080
Protect Selection page = 1
Password file = user.info
Admin user = saw
 

> When an attached image name contains a space in its filename and attachment
> display is enabled elog builds a wrong url to the image:
> 
> http://arcolog.roma2.infn.it:8080/ARCO/050309_170709/peeling+002.jpg
> 
> instead of the correct one:
> 
> http://arcolog.roma2.infn.it:8080/ARCO/050309_170709_peeling+002.jpg

This is on purpose. If you want to save an attachment locally and right click on
the attachment, and select "Save link as..." in your browser, then the default
file name is taken from the link. If your original file namw was "peeling
002.jpg", then you want again the same name, and not "050309_170709_peeling
002.jpg, because you would have to delete the date/time part of the file name
each time which would be annoying. That's why I have chosen to put an artificial
"/" between the date/time and the original file name. On the elog side, it's
converted correctly back to the file name.

The problem with blanks in attachment names I could not reproduce. See this
post, which contains an attachment with a blank in it. As you can see, this does
not crash the server.