Demo Discussion
Forum Config Examples Contributions Vulnerabilities
  Discussion forum about ELOG, Page 695 of 807  Not logged in ELOG logo
ID Date Icon Author Author Email Category OSdown ELOG Version Subject
  66492   Wed Aug 5 01:07:04 2009 Warning Richard Stamperr.stamper@rl.ac.ukBug reportAll2.7.7-2246init_resize sometimes not defined

Under some circumstances the New/Edit entry screen can invoke the init_resize() function in the onload handler for the <body> tag, but the init_resize() function is not defined.  In my case there is a log where the encoding is plain text (Default encoding = 1) and the message height is restricted (Message height = 4).  Creating or editing entries in this log generates warnings in the Firefox error console and alert boxes in IE about init_resize being undefined.

I think there is some missing logic.  In revision 2246 of elogd.c

  • at line 9924, if enc_selected = 1 then init_resize() is included in the onload handler, but
  • at line 9801, if enc_selected = 1 but at least one of the  "Message height" or "Message width" attributes is set then the code defining init_resize() is not include

I think you need to duplicate the checks on the Message height and Message width attributes at lines 9924, so that the init_resize() function is only included when defined.

Richard S

  66493   Wed Aug 5 13:36:44 2009 Reply Stefan Rittstefan.ritt@psi.chBug reportAll2.7.7-2246Re: init_resize sometimes not defined

Richard Stamper wrote:

Under some circumstances the New/Edit entry screen can invoke the init_resize() function in the onload handler for the <body> tag, but the init_resize() function is not defined.  In my case there is a log where the encoding is plain text (Default encoding = 1) and the message height is restricted (Message height = 4).  Creating or editing entries in this log generates warnings in the Firefox error console and alert boxes in IE about init_resize being undefined.

I think there is some missing logic.  In revision 2246 of elogd.c

  • at line 9924, if enc_selected = 1 then init_resize() is included in the onload handler, but
  • at line 9801, if enc_selected = 1 but at least one of the  "Message height" or "Message width" attributes is set then the code defining init_resize() is not include

I think you need to duplicate the checks on the Message height and Message width attributes at lines 9924, so that the init_resize() function is only included when defined.

Richard S

Perfect! Not only your analysis but also your suggested solution. I implemented that in revision 2249.

Stefan 

  66494   Wed Aug 5 19:05:01 2009 Question Dennis Seitzdseitz@berkeley.eduRequestAll2.7.6alphabetize Quick Filter items?

 Hi Stefan,

I'd like to request a feature: automatic alphabetization of the items in the Quick Filter menus.

We track quite a few detector assemblies, which are produced with non-sequential designations. It would be useful if the Quick Filter list was automatically sorted alphabetically to make it more convenient for folks to find a particular item.

I know people can always search by designation but it would be handy to have this alpha sorting feature. Would it be possible to include that in a future release?

Thanks again for a *very* useful logging system!

Dennis

  66495   Thu Aug 6 08:00:22 2009 Reply Stefan Rittstefan.ritt@psi.chRequestAll2.7.6Re: alphabetize Quick Filter items?

Dennis Seitz wrote:

 Hi Stefan,

I'd like to request a feature: automatic alphabetization of the items in the Quick Filter menus.

We track quite a few detector assemblies, which are produced with non-sequential designations. It would be useful if the Quick Filter list was automatically sorted alphabetically to make it more convenient for folks to find a particular item.

I know people can always search by designation but it would be handy to have this alpha sorting feature. Would it be possible to include that in a future release?

Thanks again for a *very* useful logging system!

Dennis

The order of items in a Quick Filter menu is exactly as in the configuration file. Like if you have items

Options Type = C, D, A, B

they are shown like that in the quick filter menu. If you want to sort them, just do the sorting yourself in the configuration file like

Options Type = A, B, C, D

I have not implemented automatic sorting since some people want a different order, like some main topics at top. So by following the order from the configuration file, everybody can be satisfied just by chaning the order in the config file.

- Stefan 

  66500   Thu Aug 6 22:29:12 2009 Entry Erik Iversoneiverson@ornl.govQuestionAll2.7.3Pre-populate Attachments in URL
Is there a way to pre-populate the new entry window with one or more attachments? Per the documentation, this is easy to do with attributes, i.e., http://localhost:8070/demo/?cmd=New&pauthor=joe&ptype=Info as a URL or bookmark will do it. I'd like to do the same thing with attachments, for example http://localhost:8070/demo/?cmd=New&pauthor=joe&ptype=Photograph&attfile1=picture1.jpg&attfile2=picture2.jpg might prepopulate two attachments, giving me an edit window all ready to enter the brief description represented by the two pictures.
  66501   Fri Aug 7 08:36:19 2009 Reply Stefan Rittstefan.ritt@psi.chQuestionAll2.7.3Re: Pre-populate Attachments in URL

Erik Iverson wrote:
Is there a way to pre-populate the new entry window with one or more attachments? Per the documentation, this is easy to do with attributes, i.e., http://localhost:8070/demo/?cmd=New&pauthor=joe&ptype=Info as a URL or bookmark will do it. I'd like to do the same thing with attachments, for example http://localhost:8070/demo/?cmd=New&pauthor=joe&ptype=Photograph&attfile1=picture1.jpg&attfile2=picture2.jpg might prepopulate two attachments, giving me an edit window all ready to enter the brief description represented by the two pictures.


That would be nice, I want this, too! But unfortunately your browser does not allow this for security reasons, and I found no way around. Assume you look to a page on the internet, and it pre-populates a file selector with something like /etc/passwd or any other sensitive file. Then this box gets hidden by some CSS style so you don't see it. So as soon as you click on something on that page, your sensitive files gets submitted, and you don't want that. Therefore it's impossible to pre-populate file selector boxes.

- Stefan
  66502   Fri Aug 7 23:09:42 2009 Reply Dennis Seitzdseitz@berkeley.eduRequestAll2.7.6Re: alphabetize Quick Filter items?

Stefan Ritt wrote:

Dennis Seitz wrote:

 Hi Stefan,

I'd like to request a feature: automatic alphabetization of the items in the Quick Filter menus.

We track quite a few detector assemblies, which are produced with non-sequential designations. It would be useful if the Quick Filter list was automatically sorted alphabetically to make it more convenient for folks to find a particular item.

I know people can always search by designation but it would be handy to have this alpha sorting feature. Would it be possible to include that in a future release?

Thanks again for a *very* useful logging system!

Dennis

The order of items in a Quick Filter menu is exactly as in the configuration file. Like if you have items

Options Type = C, D, A, B

they are shown like that in the quick filter menu. If you want to sort them, just do the sorting yourself in the configuration file like

Options Type = A, B, C, D

I have not implemented automatic sorting since some people want a different order, like some main topics at top. So by following the order from the configuration file, everybody can be satisfied just by chaning the order in the config file.

- Stefan 

 Yes, I have been manually sorting and resorting. We have extendable attributes and the list keeps growing so I have to resort every so often. I thought perhaps a simple alphanumeric sort as an option would be popular with most users so I thought I'd ask for it. It would really simplify things for me. Users who want to sort manually could do so by disabling the option. It never hurts to ask!

 

  66503   Mon Aug 10 17:14:48 2009 Reply Stefan Rittstefan.ritt@psi.chRequestAll2.7.6Re: alphabetize Quick Filter items?

Dennis Seitz wrote:

Stefan Ritt wrote:

Dennis Seitz wrote:

 Hi Stefan,

I'd like to request a feature: automatic alphabetization of the items in the Quick Filter menus.

We track quite a few detector assemblies, which are produced with non-sequential designations. It would be useful if the Quick Filter list was automatically sorted alphabetically to make it more convenient for folks to find a particular item.

I know people can always search by designation but it would be handy to have this alpha sorting feature. Would it be possible to include that in a future release?

Thanks again for a *very* useful logging system!

Dennis

The order of items in a Quick Filter menu is exactly as in the configuration file. Like if you have items

Options Type = C, D, A, B

they are shown like that in the quick filter menu. If you want to sort them, just do the sorting yourself in the configuration file like

Options Type = A, B, C, D

I have not implemented automatic sorting since some people want a different order, like some main topics at top. So by following the order from the configuration file, everybody can be satisfied just by chaning the order in the config file.

- Stefan 

 Yes, I have been manually sorting and resorting. We have extendable attributes and the list keeps growing so I have to resort every so often. I thought perhaps a simple alphanumeric sort as an option would be popular with most users so I thought I'd ask for it. It would really simplify things for me. Users who want to sort manually could do so by disabling the option. It never hurts to ask!

 

Ok, I implemented

Sort attribute options = 1

in the current SVN revision. 

ELOG V3.1.5-3fb85fa6