ID |
Date |
Icon |
Author |
Author Email |
Category |
OS |
ELOG Version |
Subject |
68668
|
Mon Aug 21 12:16:05 2017 |
| Andreas Luedeke | andreas.luedeke@psi.ch | Bug report | All | 3.1.3-aded4ae | Re: Bug with Drafts and Language German | I've quickly checked: there are a couple more commands in the source code that are not language encoded. I guess some of them needs correction.
> egrep -n "cmd=[A-Za-z]" elogd.c
10293: rsprintf(" r.open('GET', '?jcmd=Unlock&edit_id=%d', true);\n", message_id);
11784: ("<label for=\"ELCode\"><a target=\"_blank\" href=\"?cmd=HelpELCode\">ELCode</a> </label>\n");
13663: "\r\n%s URL : %s?cmd=Config&cfg_user=%s&unm=%s\r\n", loc("Logbook"),
14562: redirect(lbs, "?cmd=Config");
14625: sprintf(str, "../%s/?cmd=Config", getparam("lbname"));
14678: sprintf(str, "../%s/?cmd=Config", lbn);
15703: combine_url(lbs, host, "?cmd=GetMD5", url, sizeof(url), &ssl);
16378: strcat(str, "?cmd=GetConfig"); // request complete config file
16380: strcat(str, "?cmd=Download"); // request config section of logbook
16570: strcat(str, "?cmd=GetPwdFile"); // request password file
17575: rsprintf("<br><b><a href=\"../%s/?cmd=Synchronize&confirm=1\">", lbs->name_enc);
17577: rsprintf("<br><b><a href=\"%s/?cmd=Synchronize&confirm=1\">", lbs->name_enc);
17579: rsprintf("<br><b><a href=\"../%s/?cmd=Synchronize&confirm=1\">", lbs->name_enc);
18959: if (strstr(ref, "cmd=Search&"))
18960: strlcpy(strstr(ref, "cmd=Search&"), strstr(ref, "cmd=Search&") + 11, sizeof(str));
26728: rsprintf("<a href=\"?cmd=Synchronize\">%s</a></td>\n", loc("Synchronize all logbooks"));
Andreas Luedeke wrote: |
Hi Stefan,
when one creates a new entry, and a draft entry exists for the logbook, then a menu appears (see attachment).
If one select "Neuen Eintrag anlegen" then it should ignore the draft and create a new entry.
This feat is done by adding a "&ignore=1" to the "new" command: "<URL>/?cmd=New&ignore=1".
The problem is, that it should not be "cmd=New&..." but "cmd=Neu", since the commands are part of the translation.
Due to this, no new entry can be created as long as a draft exists; at least not in any language other than english.
This problem apparently existed since the beginning of drafts, but it only created problems at our site recently.
Kind Regards
Andreas
PS: Here's a patch that works:
diff elogd.c elogd.c-orig
9575,9576c9575,9576
< rsprintf("<input type=button value=\"%s\" onClick=\"window.location.href='?cmd=%s&ignore=1';\">\n", loc("Create new entry"),
< loc("New"));
---
> rsprintf("<input type=button value=\"%s\" onClick=\"window.location.href='%s';\">\n", loc("Create new entry"),
> "?cmd=New&ignore=1");
|
|
68669
|
Mon Aug 21 14:27:50 2017 |
| Andreas Luedeke | andreas.luedeke@psi.ch | Request | All | V3.1.3-aded4ae | CSS reference in Email for private logbooks | We operate ELOG in an intranet. Many logbooks do send out emails; several use HTML content formatting.
If I watch HTML formatted emails from the intranet, then everything is fine.
If I try to read them from home, my email client hangs when it tries to read the CSS file from out intranet (URL: https://elog-gfa.psi.ch/SLS/elog.css).
Is there a way to set a URL for the email CSS?
Then I could simply copy the CSS file to the internet accessible location and the emails would be properly formatted in the intranet and from home.
I've tried to use "Use Email URL = ", but it turned out that this will change all base URL's in the email BUT the one in the CSS :-(
So I would need a config "Email CSS URL = " to set this.
Here is a patch that does what I want, but it might have some side-effects I'm not yet aware of:
7636,7643c7636,7638
< if (absolute_link) {
< if (lbs != NULL && getcfg(lbs->name, "Email CSS URL", str, sizeof(str)))
< strlcpy(css_base, str, sizeof(css_base));
< else if (lbs == NULL && getcfg("global", "Email CSS URL", str, sizeof(str)))
< strlcpy(css_base, str, sizeof(css_base));
< if (css_base[0] == 0)
< compose_base_url(lbs, css_base, sizeof(css_base), FALSE);
< } else
---
> if (absolute_link)
> compose_base_url(lbs, css_base, sizeof(css_base), FALSE);
> else
Cheers
Andreas |
68771
|
Mon Mar 26 16:32:43 2018 |
| Stefan Ritt | stefan.ritt@psi.ch | Info | All | 3.1.2-0914a6 | New elog setting for large attachments | Most mail delivery systems have a maximum size for attachments. In the past, if an elog attachment was larger than this size, the email server refused to accept this email and no notification is sent. Now one can specify the maximum allowed email attachment size with
Max email attachment size = <n>
where <n> is the number of bytes. If an email attachment is larger than <n>, the attachment is not sent with the email notification, but rather replaced by a link to the elog server for that attachment. By clicking on the link in the email notification, a browser will then open and download the large attachment. For each each elog installation, the admin has to figure out what the maximum attachment size of their SMTP server is, and then put this number into the elogd.cfg setting above. For most installations, the default of 10 MB will just work fine.
Stefan |
68879
|
Fri Dec 21 14:04:41 2018 |
| Stefan Ritt | stefan.ritt@psi.ch | Request | All | V3.1.3-aded4ae | Re: CSS reference in Email for private logbooks | I changed the code ot include the CSS file directly in the email body. So no need any more for external CSS files. I dropped the "Email CSS URL" option as well.
Stefan
Andreas Luedeke wrote: |
We operate ELOG in an intranet. Many logbooks do send out emails; several use HTML content formatting.
If I watch HTML formatted emails from the intranet, then everything is fine.
If I try to read them from home, my email client hangs when it tries to read the CSS file from out intranet (URL: https://elog-gfa.psi.ch/SLS/elog.css).
Is there a way to set a URL for the email CSS?
Then I could simply copy the CSS file to the internet accessible location and the emails would be properly formatted in the intranet and from home.
I've tried to use "Use Email URL = ", but it turned out that this will change all base URL's in the email BUT the one in the CSS :-(
So I would need a config "Email CSS URL = " to set this.
Here is a patch that does what I want, but it might have some side-effects I'm not yet aware of:
7636,7643c7636,7638
< if (absolute_link) {
< if (lbs != NULL && getcfg(lbs->name, "Email CSS URL", str, sizeof(str)))
< strlcpy(css_base, str, sizeof(css_base));
< else if (lbs == NULL && getcfg("global", "Email CSS URL", str, sizeof(str)))
< strlcpy(css_base, str, sizeof(css_base));
< if (css_base[0] == 0)
< compose_base_url(lbs, css_base, sizeof(css_base), FALSE);
< } else
---
> if (absolute_link)
> compose_base_url(lbs, css_base, sizeof(css_base), FALSE);
> else
Cheers
Andreas
|
|
68909
|
Mon Mar 11 11:18:02 2019 |
| Heinz Junkes | junkes@fhi-berlin.mpg.de | Bug report | All | elogd 3.1.4 | elog program does not respect "Allow edit" list | submissions via the elog - program can overwrite entries even if the user has no edit rights |
68935
|
Wed Apr 24 09:43:02 2019 |
| Heinz Junkes | junkes@fhi-berlin.mpg.de | Bug report | All | elogd 3.1.4 | Re: elog program does not respect "Allow edit" list | Since there's no answer to that.
I am the only one with the problem? Did I just configure something wrong?
Thanks Heinz
Heinz Junkes wrote: |
submissions via the elog - program can overwrite entries even if the user has no edit rights
|
|
68936
|
Wed Apr 24 10:15:23 2019 |
| Stefan Ritt | stefan.ritt@psi.ch | Bug report | All | elogd 3.1.4 | Re: elog program does not respect "Allow edit" list | There are two ways:
1) Use different password files for different logbooks. Each password file contains only those users which have access to that logbook.
2) Use "Login user = <usr list>" to restrict access to certain users in that list.
Stefan
Heinz Junkes wrote: |
Since there's no answer to that.
I am the only one with the problem? Did I just configure something wrong?
Thanks Heinz
Heinz Junkes wrote: |
submissions via the elog - program can overwrite entries even if the user has no edit rights
|
|
|
68937
|
Wed Apr 24 10:21:58 2019 |
| Heinz Junkes | junkes@fhi-berlin.mpg.de | Bug report | All | elogd 3.1.4 | Re: elog program does not respect "Allow edit" list | Thanks for the answer. The real problem is that you can overwrite existing entries even if you have set an entry to "read only", i.e. you have forbidden further editing.
Heinz
Stefan Ritt wrote: |
There are two ways:
1) Use different password files for different logbooks. Each password file contains only those users which have access to that logbook.
2) Use "Login user = <usr list>" to restrict access to certain users in that list.
Stefan
Heinz Junkes wrote: |
Since there's no answer to that.
I am the only one with the problem? Did I just configure something wrong?
Thanks Heinz
Heinz Junkes wrote: |
submissions via the elog - program can overwrite entries even if the user has no edit rights
|
|
|
|
|