Re: a bug and a question, posted by Stefan Ritt on Thu Jul 11 10:36:09 2002
|
> If you have only one entry in the logbook and have it set up in threaded
> mode like: ?cmd=Search&mode=threaded&reverse=1, when you click on the icon
> of the entry or the number of the entry to see it, it does not allow you
> to. If there is more than one entry, it works fine.
Ok, has been fixed. Will come in 2.0.5
> Also I wanted to make a submit page from where you could either go back
> to the logbook which you just entered a message for or type a new entry for
> that logbook. First of all, is there a way to have only one file called
> submitpage.html in which I can define this for all logbooks or do i need it
> for ever logbook. And also, is there a way I can even set a link that will
> allow to create a new entry. I tried:
> <a href="demo/?cmd=new">Enter</a> another message<p>
>
> but for some reason it does not work. Is there a way to implement this?
The documentation was wrong about that which has been corrected. The proper
file contents should be
<h1>You successfully submitted a message</h1>
<a href="?cmd=Back">Back</a> to the logbook<p>
<a href="?cmd=New">Enter</a> another message
This way one only needs one file for all logbooks. |
|
Re: a bug and a question, posted by Stefan Ritt on Thu Jul 11 10:36:09 2002
|
> If you have only one entry in the logbook and have it set up in threaded
> mode like: ?cmd=Search&mode=threaded&reverse=1, when you click on the icon
> of the entry or the number of the entry to see it, it does not allow you
> to. If there is more than one entry, it works fine.
Ok, has been fixed. Will come in 2.0.5
> Also I wanted to make a submit page from where you could either go back
> to the logbook which you just entered a message for or type a new entry for
> that logbook. First of all, is there a way to have only one file called
> submitpage.html in which I can define this for all logbooks or do i need it
> for ever logbook. And also, is there a way I can even set a link that will
> allow to create a new entry. I tried:
> <a href="demo/?cmd=new">Enter</a> another message<p>
>
> but for some reason it does not work. Is there a way to implement this?
The documentation was wrong about that which has been corrected. The proper
file contents should be
<h1>You successfully submitted a message</h1>
<a href="?cmd=Back">Back</a> to the logbook<p>
<a href="?cmd=New">Enter</a> another message
This way one only needs one file for all logbooks. |
|
Re: a bug and a question, posted by Stefan Ritt on Thu Jul 11 10:36:09 2002
|
> If you have only one entry in the logbook and have it set up in threaded
> mode like: ?cmd=Search&mode=threaded&reverse=1, when you click on the icon
> of the entry or the number of the entry to see it, it does not allow you
> to. If there is more than one entry, it works fine.
Ok, has been fixed. Will come in 2.0.5
> Also I wanted to make a submit page from where you could either go back
> to the logbook which you just entered a message for or type a new entry for
> that logbook. First of all, is there a way to have only one file called
> submitpage.html in which I can define this for all logbooks or do i need it
> for ever logbook. And also, is there a way I can even set a link that will
> allow to create a new entry. I tried:
> <a href="demo/?cmd=new">Enter</a> another message<p>
>
> but for some reason it does not work. Is there a way to implement this?
The documentation was wrong about that which has been corrected. The proper
file contents should be
<h1>You successfully submitted a message</h1>
<a href="?cmd=Back">Back</a> to the logbook<p>
<a href="?cmd=New">Enter</a> another message
This way one only needs one file for all logbooks. |
|
Re: a bug and a question, posted by Stefan Ritt on Thu Jul 11 10:36:09 2002
|
> If you have only one entry in the logbook and have it set up in threaded
> mode like: ?cmd=Search&mode=threaded&reverse=1, when you click on the icon
> of the entry or the number of the entry to see it, it does not allow you
> to. If there is more than one entry, it works fine.
Ok, has been fixed. Will come in 2.0.5
> Also I wanted to make a submit page from where you could either go back
> to the logbook which you just entered a message for or type a new entry for
> that logbook. First of all, is there a way to have only one file called
> submitpage.html in which I can define this for all logbooks or do i need it
> for ever logbook. And also, is there a way I can even set a link that will
> allow to create a new entry. I tried:
> <a href="demo/?cmd=new">Enter</a> another message<p>
>
> but for some reason it does not work. Is there a way to implement this?
The documentation was wrong about that which has been corrected. The proper
file contents should be
<h1>You successfully submitted a message</h1>
<a href="?cmd=Back">Back</a> to the logbook<p>
<a href="?cmd=New">Enter</a> another message
This way one only needs one file for all logbooks. |
convert: unrecognized option '-set', posted by Devin Bougie on Mon Jan 26 22:01:07 2009
|
Hello,
We are now running elog-2.7.5 in a Scientific Linux 4 (RHEL4) system, which uses ImageMagick 6.0.7.1. After uploading an image, the image
manipulation buttons don't work and complain:
convert: unrecognized option '-set'
We are using an RPM built from source, and it looks like I should be able to just change "-set comment ..." to "-comment" as in:
------
[dab66@lnx100 tmp]% diff elogd.c elogd.c.new
22601c22601
< sprintf(cmd, "convert '%s' -rotate %d -thumbnail %d -set comment ' %d' '%s'", file_name, new_rot,
---
> sprintf(cmd, "convert '%s' -rotate %d -thumbnail %d -comment ' %d' '%s'", file_name, new_rot,
22607c22607
< sprintf(cmd, "convert '%s' -rotate %d -thumbnail %d -set comment ' %d' '%s'", file_name, new_rot,
---
> sprintf(cmd, "convert '%s' -rotate %d -thumbnail %d -comment ' %d' '%s'", file_name, new_rot,
22618c22618
< sprintf(cmd, "convert '%s' -rotate %d -thumbnail %d -set comment ' %d' '%s'", file_name, cur_rot,
---
> sprintf(cmd, "convert '%s' -rotate %d -thumbnail %d -comment ' %d' '%s'", file_name, cur_rot,
22624c22624
< sprintf(cmd, "convert '%s' -rotate %d -thumbnail %d -set comment ' %d' '%s'", file_name, cur_rot,
---
> sprintf(cmd, "convert '%s' -rotate %d -thumbnail %d -comment ' %d' '%s'", file_name, cur_rot,
------
Is there any better way for us to fix this, or is anything else needed?
Thanks,
Devin |
|
Re: convert: unrecognized option '-set', posted by Stefan Ritt on Tue Jan 27 09:19:22 2009
|
> Hello,
>
> We are now running elog-2.7.5 in a Scientific Linux 4 (RHEL4) system, which uses ImageMagick 6.0.7.1. After uploading an image, the image
> manipulation buttons don't work and complain:
> convert: unrecognized option '-set'
>
> We are using an RPM built from source, and it looks like I should be able to just change "-set comment ..." to "-comment" as in:
> ------
> [dab66@lnx100 tmp]% diff elogd.c elogd.c.new
> 22601c22601
> < sprintf(cmd, "convert '%s' -rotate %d -thumbnail %d -set comment ' %d' '%s'", file_name, new_rot,
> ---
> > sprintf(cmd, "convert '%s' -rotate %d -thumbnail %d -comment ' %d' '%s'", file_name, new_rot,
> 22607c22607
> < sprintf(cmd, "convert '%s' -rotate %d -thumbnail %d -set comment ' %d' '%s'", file_name, new_rot,
> ---
> > sprintf(cmd, "convert '%s' -rotate %d -thumbnail %d -comment ' %d' '%s'", file_name, new_rot,
> 22618c22618
> < sprintf(cmd, "convert '%s' -rotate %d -thumbnail %d -set comment ' %d' '%s'", file_name, cur_rot,
> ---
> > sprintf(cmd, "convert '%s' -rotate %d -thumbnail %d -comment ' %d' '%s'", file_name, cur_rot,
> 22624c22624
> < sprintf(cmd, "convert '%s' -rotate %d -thumbnail %d -set comment ' %d' '%s'", file_name, cur_rot,
> ---
> > sprintf(cmd, "convert '%s' -rotate %d -thumbnail %d -comment ' %d' '%s'", file_name, cur_rot,
> ------
>
> Is there any better way for us to fix this, or is anything else needed?
Well, I believe your modification won't work. I just tried it with ImageMagick 6.3.8 and it failed. Try to rotate your picture four times, and
it should be back to the old position. When I use "-comment" instead "-set comment" on a PNG file, this did not work. From the man page it
tells me:
Version: ImageMagick 6.3.8 01/25/08 Q16 http://www.imagemagick.org
Copyright: Copyright (C) 1999-2008 ImageMagick Studio LLC
Usage: convert [options ...] file [ [options ...] file ...] [options ...] file
Image Settings:
...
-comment string annotate image with comment
...
Image Operators:
...
-set property value set an image property
...
So indeed "-comment" and "-set comment" are two different things. I'm afraid you have to upgrade your ImageMagick package in order to make
this work. |
Long cookie content is not handled properly., posted by Simon Patton on Tue Apr 14 22:51:15 2009
|
I discovered the infinite loop in 2.7.5 which can happen when a cookie's content is longer that the cookie array
designed to hold it. I also note that this issue has been addressed in 2.7.6, but the solution does not appear
to be correct and it can end up completely confusing the cookie extraction.
In 2.7.5 the code was:
for (i = 0; *p && *p != ';' && *p != '\r' && *p != '\n' ; )
if (i < (int) sizeof(cookie)-1)
cookie[i++] = *p++;
While in 2.7.6 is became:
for (i = 0; *p && *p != ';' && *p != '\r' && *p != '\n';)
if (i < (int) sizeof(cookie) - 1)
cookie[i++] = *p++;
else
break;
This leaves 'p' pointing to the middle of the cookie's content and I can not see that this is corrected in the loop (sorry if I've missed that).
The solution I used to patch 2.7.5 was the following:
for (i = 0; *p && *p != ';' && *p != '\r' && *p != '\n' ; ++p)
if (i < (int) sizeof(cookie)-1)
cookie[i++] = *p;
which simply truncates the contents of the cookie (which is assumed not to be an elogd cookie) but leaves 'p' in the right place to extract the next one. |
|
Re: Long cookie content is not handled properly., posted by Stefan Ritt on Wed Apr 15 09:26:37 2009
|
| Simon Patton wrote: | I discovered the infinite loop in 2.7.5 which can happen when a cookie's content is longer that the cookie array
designed to hold it. I also note that this issue has been addressed in 2.7.6, but the solution does not appear
to be correct and it can end up completely confusing the cookie extraction.
In 2.7.5 the code was:
for (i = 0; *p && *p != ';' && *p != '\r' && *p != '\n' ; )
if (i < (int) sizeof(cookie)-1)
cookie[i++] = *p++;
While in 2.7.6 is became:
for (i = 0; *p && *p != ';' && *p != '\r' && *p != '\n';)
if (i < (int) sizeof(cookie) - 1)
cookie[i++] = *p++;
else
break;
This leaves 'p' pointing to the middle of the cookie's content and I can not see that this is corrected in the loop (sorry if I've missed that).
The solution I used to patch 2.7.5 was the following:
for (i = 0; *p && *p != ';' && *p != '\r' && *p != '\n' ; ++p)
if (i < (int) sizeof(cookie)-1)
cookie[i++] = *p;
which simply truncates the contents of the cookie (which is assumed not to be an elogd cookie) but leaves 'p' in the right place to extract the next one. |
You're absolutely right about that. I incorporated your patch into revision #2192. |
|