Re: [patch]: fixed wrong extention check, posted by Stefan Ritt on Sat Feb 12 17:45:39 2005
|
> current version uses strstr() to check if the file has the expected ascii
> text extension ... this is buggy becouse this way a file named
> ".txt_hidden_file" or "foo.config.dat" are both seen as .txt files.
I added your routine chkext() to the code, but actually use it differently. I
display now ASCII files not by their extension, but the code checks for each file
to contain non-printable characters. If it contains all printable letters, and does
not have the extension PDF, PS or EPS, it's shown inline. |
Re: [patch]: fixed wrong extention check, posted by Emiliano Gabrielli on Wed Feb 16 08:48:52 2005
|
> > current version uses strstr() to check if the file has the expected ascii
> > text extension ... this is buggy becouse this way a file named
> > ".txt_hidden_file" or "foo.config.dat" are both seen as .txt files.
>
> I added your routine chkext() to the code, but actually use it differently. I
> display now ASCII files not by their extension, but the code checks for each file
> to contain non-printable characters. If it contains all printable letters, and does
> not have the extension PDF, PS or EPS, it's shown inline.
I totally agree with you choice :-) |
Re: [Not] Submit on pressing enter key, posted by Stefan Ritt on Tue Jan 21 13:17:52 2014
|
Daniel Campora wrote: |
Hello community,
I have a feature request for the form of the ELOG.
For some users, especially coming from a MAC background, it is very inconvenient to press enter (ie. on the subject field) and post a message (or get prompted to do so). Instead, enter in these fields should work as a tab.
Cheers, keep up the good work,
Daniel
|
Have a look at this forum. If you press <enter> on the subject field, you get asked "do you really want to submit this entry" and you have the chance to cancel and continue editing. You should get the same with the current elog version. |
Re: [BUG] show only new entries, posted by Stefan Ritt on Fri Jun 24 22:44:03 2005
|
Emiliano Gabrielli wrote: | the new link "show only new entries" is very useful but seems to still have some problems:
- I can't find any simple way to return to the "every entries" display .. may be the link has to be switched to a checkbox to be actived or not
- I found a way (at least)... following the "config" link, doing nothing and coming back restores the view .. this is a feature now, but when a less tricky mechanism will be implemented will become a bug

|
I added a "Show all entries" link to go back.
Emiliano Gabrielli wrote: | another entry for my wishlist:
writeing the above code I noticed that the elcode buttons are lacking of a "[ *]" shortcut .. it will be very usefull  |
I added that to elcode.js . So if you click on the list button, the (LIST) tag and the the first (*) are inserted.
Emiliano Gabrielli wrote: | Writeing the wish above I noticed that the [ *] is interpreted as an item also otside the LIST tag .. so .. or the LIST tag is optional, or the [ *] should not be interpreted outside of it ... it's another bug ? P |
Well, the ELCode stuff if a poor man's version of HTML. So each [ LIST] gets converted into a <UL> tag, and each [ *] gets converted into a <LI> tag. This makes the interpretation very simple, but the code does have no clue if your are inside a [ LIST] or not. Common bulletin boards have exactly the same problem. To fix it, you would really have to interprete all the ELCode, and I don't want to write my own parser. |
Re: [BUG] show only new entries, posted by Emiliano Gabrielli on Mon Jun 27 15:09:12 2005
|
Stefan Ritt wrote: |
Emiliano Gabrielli wrote: | the new link "show only new entries" is very useful but seems to still have some problems:
- I can't find any simple way to return to the "every entries" display .. may be the link has to be switched to a checkbox to be actived or not
- I found a way (at least)... following the "config" link, doing nothing and coming back restores the view .. this is a feature now, but when a less tricky mechanism will be implemented will become a bug

|
I added a "Show all entries" link to go back.
|
I think you only committed the changes to elcode.js but not the ones relative to elogd.c ... the Attribute quick filter is now empty, and no "show all entries" is ever displayed |
Re: [BUG] show only new entries, posted by Emiliano Gabrielli on Mon Jul 4 12:16:13 2005
|
Emiliano Gabrielli wrote: |
Stefan Ritt wrote: |
I added a "Show all entries" link to go back.
|
I think you only committed the changes to elcode.js but not the ones relative to elogd.c ... the Attribute quick filter is now empty, and no "show all entries" is ever displayed |
Just tested the rev 1.686 .. now the link is displayed, but following the "Show only last" link the "attach=1" setting in the URL I use is removed, not being able to have inline attachment in full view. They are displayed again when turning back to "Show all entries" |
Re: [BUG] show only new entries, posted by Stefan Ritt on Mon Jul 4 22:44:03 2005
|
Emiliano Gabrielli wrote: | Just tested the rev 1.686 .. now the link is displayed, but following the "Show only last" link the "attach=1" setting in the URL I use is removed, not being able to have inline attachment in full view. They are displayed again when turning back to "Show all entries" |
I tried to fix this in the current CVS. Can you give it a try? |
Re: [BUG] show only new entries, posted by Emiliano Gabrielli on Tue Jul 5 11:32:34 2005
|
Stefan Ritt wrote: |
Emiliano Gabrielli wrote: | Just tested the rev 1.686 .. now the link is displayed, but following the "Show only last" link the "attach=1" setting in the URL I use is removed, not being able to have inline attachment in full view. They are displayed again when turning back to "Show all entries" |
I tried to fix this in the current CVS. Can you give it a try? |
the following patch has to be applied over the one of you to complete it 
diff -u -r1.691 elogd.c
--- src/elogd.c 4 Jul 2005 21:12:58 -0000 1.691
+++ src/elogd.c 5 Jul 2005 09:29:57 -0000
@@ -16728,7 +16728,7 @@
/*---- apply last login cut ----*/
- if (isparam("new_entries") && isparam("unm"))
+ if (isparam("new_entries") && atoi(getparam("new_entries")) == 1 && isparam("unm"))
get_user_line(lbs, getparam("unm"), NULL, NULL, NULL, NULL, <ime_start);
/*---- assemble message list ----*/ |