Demo Discussion
Forum Config Examples Contributions Vulnerabilities
  Discussion forum about ELOG, Page 651 of 808  Not logged in ELOG logo
ID Date Icon Author Author Email Category OS ELOG Versiondown Subject
  918   Tue Feb 8 13:00:40 2005 Warning Emiliano GabrielliAlberT@SuperAlberT.itBug reportLinux2.5.6erroneus encoding
elog sends wrong HTTP headers, charset is empty and not separed from the
next one "Connection: Keep-Alive ... this bug tells the browser that the
encoding is "connection:" ... that is wrong.

root@emc2:/home/albert# GET -USde http://midas.psi.ch/elogs/Forum/
GET http://midas.psi.ch/elogs/Forum/
User-Agent: lwp-request/2.06

GET http://midas.psi.ch/elogs/Forum/ --> 200 Document follows
Connection: close
Date: Tue, 08 Feb 2005 11:54:40 GMT
Pragma: no-cache
Server: ELOG HTTP 2.5.6-2
Content-Type: text/html;charset=Connection: Keep-Alive
Expires: Fri, 01 Jan 1983 00:00:00 GMT
.....
....


this is the problem from validator point of viev:
http://validator.w3.org/check?uri=http%3A%2F%2Fmidas.psi.ch%2Felogs%2FForum%2F&charset=%28detect+automatically%29&doctype=%28detect+automatically%29&ss=1&verbose=1
  920   Tue Feb 8 13:11:30 2005 Warning Emiliano GabrielliAlberT@SuperAlberT.itBug reportAll2.5.6Re: HTML 4.1 transitional validation fails
> as this url shows http://www.htmlhelp.com/tools/validator/problems.html#amp

> it should be used an HTML entity instead of the ampersand sign.<p> another problem with validation: required attribute "ALT" not specified in every <img> tag used in the elog (icons) here is an example of the validator results: http://validator.w3.org/check?uri=http%3A%2F%2Fmidas.psi.ch%2Felogs%2FLinux+Demo%2F&charset=iso-8859-1+%28Western+Europe%29&verbose=1
  921   Tue Feb 8 13:13:22 2005 Blink Emiliano GabrielliAlberT@SuperAlberT.itBug reportLinux2.5.6Re: preselected values and conditional options
 up :-)
  924   Tue Feb 8 15:41:55 2005 Agree Emiliano GabrielliAlberT@SuperAlberT.itBug fixLinux2.5.6Re: erroneus encoding
the following patch corrects the problem, plz apply :


--- elogd.c     2005-02-03 16:46:10.000000000 +0100
+++ elogd_albert.c      2005-02-08 15:40:36.000000000 +0100
@@ -6178,7 +6178,7 @@
    if (getcfg("global", "charset", str, sizeof(str)))
       rsprintf("Content-Type: text/html;charset=%s\r\n", str);
    else
-      rsprintf("Content-Type: text/html;charset=%S\r\n", DEFAULT_HTTP_CHARSET);
+      rsprintf("Content-Type: text/html;charset=%s\r\n", DEFAULT_HTTP_CHARSET);

    if (use_keepalive) {
       rsprintf("Connection: Keep-Alive\r\n");
@@ -11267,7 +11267,7 @@
    rsprintf("Server: ELOG HTTP %s\r\n", VERSION);
    rsprintf("Accept-Ranges: bytes\r\n");
    rsprintf("Connection: close\r\n");
-   rsprintf("Content-Type: text/plain;charset=%S\r\n", DEFAULT_HTTP_CHARSET);
+   rsprintf("Content-Type: text/plain;charset=%s\r\n", DEFAULT_HTTP_CHARSET);
    rsprintf("Pragma: no-cache\r\n");
    rsprintf("Expires: Fri, 01 Jan 1983 00:00:00 GMT\r\n\r\n");
  930   Sat Feb 12 17:06:44 2005 Reply Stefan Rittstefan.ritt@psi.chBug reportLinux2.5.6Re: preselected values and conditional options
> ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
> Attributes = Author, Type, Category, Subject
> Required Attributes = Author, Type, Subject
> Options Type = Deposition{1}, Arc Studies{1}, Conditioning{1}, Vacuum{2},
> Other{3}
> Preset Type = Deposition

The "Preset xxx" option actually never was ment to be used with conditional
attributes. I added that functionality in rev. 1.553. Please give it a try.
  931   Sat Feb 12 17:08:32 2005 Warning Stefan Rittstefan.ritt@psi.chRequestLinux2.5.6Re: images attached shown as inline
> the following should do the job:
> 
> <div style="width: 200px">
> <img src="IMG_3133.jpg" style="width: 100%" />
> </div>
> 
> the configurable parameter should be with obviously :-)

Unfortunately not. Please find attached the screen dump from such a try, together with the HTML code.
As you can see, the little elog icon is stretched to the same width as the upper (large) picture.
Attachment 1: scaling.gif
scaling.gif
  932   Sat Feb 12 17:31:46 2005 Reply Stefan Rittstefan.ritt@psi.chBug reportLinux2.5.6Re: erroneus encoding
> elog sends wrong HTTP headers, charset is empty and not separed from the
> next one "Connection: Keep-Alive ... this bug tells the browser that the
> encoding is "connection:" ... that is wrong.

This has to do with the "%S" vs. "%s" bug described elsewhere in this forum. 
I fixed that. The validator link above now also reports error free.
  933   Sat Feb 12 17:40:55 2005 Reply Stefan Rittstefan.ritt@psi.chBug reportAll2.5.6Re: HTML 4.1 transitional validation fails
I added ths missing tags. The validator at least does not complain any more.
ELOG V3.1.5-3fb85fa6