| ID |
Date |
Icon |
Author |
Author Email |
Category |
OS |
ELOG Version |
Subject |
|
1227
|
Tue Jul 5 22:35:52 2005 |
 | Stefan Ritt | stefan.ritt@psi.ch | Bug report | All | cvs | Re: [BUG] attach=1 and inline imgs |
| Emiliano Gabrielli wrote: | There is a little difference in the way elog treats attachment's display in list and single message view...
It has to be, but some beaviours can be seen as bugs:
- this is a real bug (see attachment).. if a file is referred inside the text (as shown in elcode docs) it is correctly not shown when in single message view, but it remains visible both inline and as attachment in the full list view
- it would be nice for the user having, as in the single message view, the possibility of show or hide a single or all the attachements of a single message ..
|
I removed attachment displays for all views if the image is referenced inline. A potential problem is that it might confuse people. During submission (and later during editing), they see an attachment at the bottom, but the link at the botton is not visible in normal display. If they want to extract an inline image into a file, they have to know that there is a "Save image as..." in their browser. So let's see how many people complain. |
|
1226
|
Tue Jul 5 11:51:14 2005 |
| Stefan Ritt | stefan.ritt@psi.ch | Bug report | All | 2.6.0beta2 | Re: [BUG] show only new entries |
| Emiliano Gabrielli wrote: | the following patch has to be applied over the one of you to complete it  |
Ok, done. |
|
1225
|
Tue Jul 5 11:32:34 2005 |
| Emiliano Gabrielli | AlberT@SuperAlberT.it | Bug report | All | 2.6.0beta2 | Re: [BUG] show only new entries |
| Stefan Ritt wrote: |
| Emiliano Gabrielli wrote: | | Just tested the rev 1.686 .. now the link is displayed, but following the "Show only last" link the "attach=1" setting in the URL I use is removed, not being able to have inline attachment in full view. They are displayed again when turning back to "Show all entries" |
I tried to fix this in the current CVS. Can you give it a try? |
the following patch has to be applied over the one of you to complete it
diff -u -r1.691 elogd.c
--- src/elogd.c 4 Jul 2005 21:12:58 -0000 1.691
+++ src/elogd.c 5 Jul 2005 09:29:57 -0000
@@ -16728,7 +16728,7 @@
/*---- apply last login cut ----*/
- if (isparam("new_entries") && isparam("unm"))
+ if (isparam("new_entries") && atoi(getparam("new_entries")) == 1 && isparam("unm"))
get_user_line(lbs, getparam("unm"), NULL, NULL, NULL, NULL, <ime_start);
/*---- assemble message list ----*/ |
|
1224
|
Mon Jul 4 22:44:03 2005 |
| Stefan Ritt | stefan.ritt@psi.ch | Bug report | All | 2.6.0beta2 | Re: [BUG] show only new entries |
| Emiliano Gabrielli wrote: | | Just tested the rev 1.686 .. now the link is displayed, but following the "Show only last" link the "attach=1" setting in the URL I use is removed, not being able to have inline attachment in full view. They are displayed again when turning back to "Show all entries" |
I tried to fix this in the current CVS. Can you give it a try? |
|
1223
|
Mon Jul 4 18:46:25 2005 |
 | Emiliano Gabrielli | AlberT@SuperAlberT.it | Bug report | All | cvs | [BUG] attach=1 and inline imgs |
There is a little difference in the way elog treats attachment's display in list and single message view...
It has to be, but some beaviours can be seen as bugs:
- this is a real bug (see attachment).. if a file is referred inside the text (as shown in elcode docs) it is correctly not shown when in single message view, but it remains visible both inline and as attachment in the full list view
- it would be nice for the user having, as in the single message view, the possibility of show or hide a single or all the attachements of a single message ..
|
| Attachment 1: elog-showattach_bug.jpg
|
|
|
1222
|
Mon Jul 4 12:16:13 2005 |
 | Emiliano Gabrielli | AlberT@SuperAlberT.it | Bug report | All | 2.6.0beta2 | Re: [BUG] show only new entries |
| Emiliano Gabrielli wrote: |
| Stefan Ritt wrote: |
I added a "Show all entries" link to go back.
|
I think you only committed the changes to elcode.js but not the ones relative to elogd.c ... the Attribute quick filter is now empty, and no "show all entries" is ever displayed |
Just tested the rev 1.686 .. now the link is displayed, but following the "Show only last" link the "attach=1" setting in the URL I use is removed, not being able to have inline attachment in full view. They are displayed again when turning back to "Show all entries" |
|
1221
|
Sun Jul 3 03:48:12 2005 |
 | John Habermann | john.habermann@wilderness.org.au | Question | Linux | 2.5.9+r167 | changing the default to plain text rather than elcode |
Hi
I just shifted our elogs to a new server and in the process upgraded to the latest debian version which is 2.5.9+r1674-1. I am just wondering how to change the default for the text body area from "elcode" to plain text? I can't see anything in the admin configuration syntax guide and the HTML default = 2 option no longer seems to work.
Also is there anything in particular that you have to do to get the elcode editor to work. Although the elcode buttons appear highlighting text and clicking on them doesn't actually do anything although it works fine in my browser when using these elog forums. I don't get any errors in mozilla but trying it in IE under cxoffice gives an "error on page" message in the bottom of the browser.
Thanks
John |
|
1220
|
Mon Jun 27 15:37:25 2005 |
 | Emiliano Gabrielli | AlberT@SuperAlberT.it | Bug fix | Linux | 2.6.0beta2 | Re: [BUG] quick filter |
| Emiliano Gabrielli wrote: |
| Stefan Ritt wrote: |
Fixed in current CVS.
|
uhm... now the drop down menu is composed of only blancs ..
|
the following patch should solve the problem 
--- src/elogd.c 24 Jun 2005 20:22:33 -0000 1.685
+++ src/elogd.c 27 Jun 2005 13:34:05 -0000
@@ -15853,7 +15853,7 @@
if (comment[0] == 0)
strcpy(comment, attr_options[i][j]);
- for (i1=i2=0 ; i1<=(int)comment ; i1++) {
+ for (i1=i2=0 ; i1<=(int)strlen(comment) ; i1++) {
if (comment[i1] == '(') {
option[i2++] = '\\';
option[i2++] = '(';
|