| ID |
Date |
Icon |
Author |
Author Email |
Category |
OS |
ELOG Version |
Subject |
|
66473
|
Tue Jul 28 16:57:39 2009 |
 | Stefan Ritt | stefan.ritt@psi.ch | Bug report | Linux | 2.7.6r2233 | Re: Odd problem (bug?) with certain attribute |
| T. Ribbrock wrote: |
|
I have the following simple test logbook:
; General
List display = Edit, Hostname, OS, Size
Entries per page = 150
Quick filter = OS
Date Format = %d/%m/%Y
Summary Lines = 0
; Attributes
Attributes = Hostname, OS, CPU,Size
Required Attributes = Hostname
Sort Attributes = Hostname
; Message part: log is text only, but elog is allowed
Default encoding = 0
Allowed encoding = 2
For some strange reasons, I'm having problems with the "Size" attribute, which I have added later. If I start adding/editing entries, at some point, the "Size" attribute will stay at "0" and will not accept any further changes. I've tried to pare down the config to maybe find which statement could be causing this, but to no avail. The only thing I can say is taht id doesn not seem to happen if the configuration consist of the sole line
Attributes = Hostname, OS, CPU,Size
I'm quite puzzled as to what is going on here (the original problems stems from a more complicated logbook) - I'm not even 100% sure whether this happens due to a bug or not.
|
That's indeed a strange bug, and thanks to your detailed explanation I could easily reproduce it. The problem was that in the ELCode toolbar there is already a "SIZE" parameter, which gets submitted instead of your "size" attribute. Therefore whatever you submit as "size", gets replaced by zero (since the SIZE drop-down box usually sits at zero). So you can either go and change your "size" attribute into someting else like "Memory Size", or you upgrade to version 2244, where I fixed this problem. |
|
66474
|
Tue Jul 28 17:10:13 2009 |
| T. Ribbrock | emgaron+elog@ribbrock.org | Bug report | Linux | 2.7.6r2233 | Re: Odd problem (bug?) with certain attribute |
| Stefan Ritt wrote: |
|
That's indeed a strange bug, and thanks to your detailed explanation I could easily reproduce it. The problem was that in the ELCode toolbar there is already a "SIZE" parameter, which gets submitted instead of your "size" attribute. Therefore whatever you submit as "size", gets replaced by zero (since the SIZE drop-down box usually sits at zero). So you can either go and change your "size" attribute into someting else like "Memory Size", or you upgrade to version 2244, where I fixed this problem.
|
Very nice, thank you! Given that I also still have to test the fix you made for the crash problem with "shared" logbooks (I assume it's also present in 2244), I'll upgrade and report back (probably tomorrow). |
|
66482
|
Wed Jul 29 13:23:41 2009 |
 | T. Ribbrock | emgaron+elog@ribbrock.org | Bug report | Linux | 2.7.6r2233 | Re: Odd problem (bug?) with certain attribute |
| T. Ribbrock wrote: |
|
Very nice, thank you! Given that I also still have to test the fix you made for the crash problem with "shared" logbooks (I assume it's also present in 2244), I'll upgrade and report back (probably tomorrow).
|
2244 is now running, and indeed, the "Size" attribute works now. Thank you!  |
|
66483
|
Wed Jul 29 14:48:34 2009 |
| T. Ribbrock | emgaron+elog@ribbrock.org | Bug report | Linux | 2.7.6r2233 | Re: Crashes when editing entries |
By now, I've installed 2244 and ran some rudimentary tests. So far, I was not able to reproduce the crash anymore. Looking good! |
|
66492
|
Wed Aug 5 01:07:04 2009 |
 | Richard Stamper | r.stamper@rl.ac.uk | Bug report | All | 2.7.7-2246 | init_resize sometimes not defined |
Under some circumstances the New/Edit entry screen can invoke the init_resize() function in the onload handler for the <body> tag, but the init_resize() function is not defined. In my case there is a log where the encoding is plain text (Default encoding = 1) and the message height is restricted (Message height = 4). Creating or editing entries in this log generates warnings in the Firefox error console and alert boxes in IE about init_resize being undefined.
I think there is some missing logic. In revision 2246 of elogd.c
- at line 9924, if enc_selected = 1 then init_resize() is included in the onload handler, but
- at line 9801, if enc_selected = 1 but at least one of the "Message height" or "Message width" attributes is set then the code defining init_resize() is not include
I think you need to duplicate the checks on the Message height and Message width attributes at lines 9924, so that the init_resize() function is only included when defined.
Richard S |
|
66493
|
Wed Aug 5 13:36:44 2009 |
| Stefan Ritt | stefan.ritt@psi.ch | Bug report | All | 2.7.7-2246 | Re: init_resize sometimes not defined |
| Richard Stamper wrote: |
|
Under some circumstances the New/Edit entry screen can invoke the init_resize() function in the onload handler for the <body> tag, but the init_resize() function is not defined. In my case there is a log where the encoding is plain text (Default encoding = 1) and the message height is restricted (Message height = 4). Creating or editing entries in this log generates warnings in the Firefox error console and alert boxes in IE about init_resize being undefined.
I think there is some missing logic. In revision 2246 of elogd.c
- at line 9924, if enc_selected = 1 then init_resize() is included in the onload handler, but
- at line 9801, if enc_selected = 1 but at least one of the "Message height" or "Message width" attributes is set then the code defining init_resize() is not include
I think you need to duplicate the checks on the Message height and Message width attributes at lines 9924, so that the init_resize() function is only included when defined.
Richard S
|
Perfect! Not only your analysis but also your suggested solution. I implemented that in revision 2249.
Stefan |
|
66496
|
Thu Aug 6 11:40:11 2009 |
 | soren poulsen | soren.poulsen@cern.ch | Bug report | Linux | 2.7.7 | HTML in attribute values |
Hi,
I am using syntax like (from the doc):
Display Telephone = <a href="http://any.company.com/telbook.cgi?search=$Name">$Name's telephone number</a>
Until yesterday this was interpreted as HTML.
After upgrading to 2.7.7, I still get a valid link but the full HTML code is also displayed: the user sees
''<a href="http://any.company.com/telbook.cgi?search=myname">myname's telephone number</a>''
where he should only see:
''myname's telephone number''
I am 99% sure this is a consequence of the upgrade. Is there a way to get the original behaviour back?
Thanks a lot
Soren Poulsen
|
|
66497
|
Thu Aug 6 11:53:29 2009 |
| soren poulsen | soren.poulsen@cern.ch | Bug report | Linux | 2.7.7 | Re: HTML in attribute values |
| soren poulsen wrote: |
|
Hi,
I am using syntax like (from the doc):
Display Telephone = <a href="http://any.company.com/telbook.cgi?search=$Name">$Name's telephone number</a>
Until yesterday this was interpreted as HTML.
After upgrading to 2.7.7, I still get a valid link but the full HTML code is also displayed: the user sees
''<a href="http://any.company.com/telbook.cgi?search=myname">myname's telephone number</a>''
where he should only see:
''myname's telephone number''
I am 99% sure this is a consequence of the upgrade. Is there a way to get the original behaviour back?
Thanks a lot
Soren Poulsen
|
I have more precise information about the nature of this issue, which concerns the display of E-logs
In the previous version 2.7.6, E-log would generate HTML like this:
td class="attribvalue">
<a href="https://edms.cern.ch/camms/plsql/d7i_report_CV_WO_VIEW.form_7?event=15403690&button=Search">15403690</a> </td>
In the latest version 2.7.7, E-log generates HTML like this (for the same attribute):
<td class="attribvalue">
<a href="<a href="https://edms.cern.ch/camms/plsql/d7i_report_CV_WO_VIEW.form_7?event=15575045&button=Search">https://edms.cern.ch/camms/plsql/d7i_report_CV_WO_VIEW.form_7?event=15575045&button=Search</a>">15575045</a> </td>
Soren Poulsen
|