Using 2.5.8, if I set "Protect Selection page" to 1, then elogd seg faults
as soon as it is accessed.

Under 2.5.7, a login page will come up, and the logbook will work, but only
if a valid username/password is given.  If an invalid login is given, then
elogd crashes.  We have a cron job that periodically restarts elogd if it is
has crashed.

Steve

[global]
logbook tabs = 0
port = 8080
Protect Selection page = 1
Password file = user.info
Admin user = saw
 

> Using 2.5.8, if I set "Protect Selection page" to 1, then elogd seg faults
> as soon as it is accessed.

Thanks for reporting this bug. I fixed it and committed the change to CVS.

- Stefan

> > Using 2.5.8, if I set "Protect Selection page" to 1, then elogd seg faults
> > as soon as it is accessed.
> 
> Thanks for reporting this bug. I fixed it and committed the change to CVS.
> 
> - Stefan

wow, who's Speedy Gonzales ?!? :-P

> > Using 2.5.8, if I set "Protect Selection page" to 1, then elogd seg faults
> > as soon as it is accessed.
> 
> Thanks for reporting this bug. I fixed it and committed the change to CVS.
> 
> - Stefan

wow, who's Speedy Gonzales ?!? :-P

> > Using 2.5.8, if I set "Protect Selection page" to 1, then elogd seg faults
> > as soon as it is accessed.
> 
> Thanks for reporting this bug. I fixed it and committed the change to CVS.
> 
> - Stefan

That was fast!  I put the elogd.c from the cvs on top of 2.5.8 and now I can run
the server with Protect Selection page=1 again.

Logins work OK if the username/password is valid.  However, if I try to login
with invalid authentication, the server crashes.  If I turn off the protect
selection page, then invalid authentication does not crash elogd.

Thanks, Steve

> Logins work OK if the username/password is valid.  However, if I try to login
> with invalid authentication, the server crashes.  If I turn off the protect
> selection page, then invalid authentication does not crash elogd.

Ok, it's me, Speedy Gonzales again (as Emiliano says... (;-))

I fixed that as well and committed the changes.

Greetings to JLab (I once worked at UVa in Charlottesville...). Is David Abbott
still there?

- Stefan

> > Logins work OK if the username/password is valid.  However, if I try to login
> > with invalid authentication, the server crashes.  If I turn off the protect
> > selection page, then invalid authentication does not crash elogd.
> 
> Ok, it's me, Speedy Gonzales again (as Emiliano says... (;-))
> 
> I fixed that as well and committed the changes.

That seems to do the trick!  Thanks, Steve

> > It seems to work nice to me.
> > Just another suggestion: I think it would be better to insert a commented out
> > example for all allowed parameters in the distributed  /etc/default/elog
> 
> Thanks for the test.  Please note that, /etc/default/elog is partially auto
> created during the installation.  All options except PIDFILE and CONFFILE are
> currently listed (as configured or commented out).  If you didn't see these
> options (after the update), there must be a problem.   Did you mean the lack of
> PIDFILE and CONFFILE in the default file?

no, my bad (it seems :-P) .. I re-installed the package now on my laptop and seems
to work fine... maybe I have swapped the diff result when installed yesterday.

Making tests I found another problem, her is the report:

####
root@emc2:/home/albert# apt-get remove elog
Lettura della lista dei pacchetti in corso... Fatto
Generazione dell'albero delle dipendenze in corso... Fatto
I seguenti pacchetti saranno RIMOSSI:
  elog
0 aggiornati, 0 installati, 1 da rimuovere e 0 non aggiornati.
È necessario prendere 0B di archivi.
Dopo l'estrazione, verranno liberati 2444kB di spazio su disco.
Continuare? [S/n]
(Lettura del database ... 152033 file e directory attualmente installati.)
Rimuovo elog ...
Stopping ELOG daemon: elogd.
root@emc2:/home/albert# rm /etc/default/elog
rm: rimuovere regular file `/etc/default/elog'? y
root@emc2:/home/albert# apt-get install elog
Lettura della lista dei pacchetti in corso... Fatto
Generazione dell'albero delle dipendenze in corso... Fatto
I seguenti pacchetti NUOVI (NEW) saranno installati:
  elog
0 aggiornati, 1 installati, 0 da rimuovere e 0 non aggiornati.
È necessario prendere 0B/530kB di archivi.
Dopo l'estrazione, verranno occupati 2444kB di spazio su disco.
Selezionato il pacchetto elog, che non lo era.
(Lettura del database ... 151926 file e directory attualmente installati.)
Spacchetto elog (da .../elog_2.5.8+r1592-1_i386.deb) ...
Configuro elog (2.5.8+r1592-1) ...
cat: /etc/default/elog: No such file or directory
Starting ELOG daemon: elogd.
####


So, removing an existing elog (not purging) and installing again raise the error.
Why installation creates the default/elog file only the first time ?  I think it
shoud do the job everytime (and everytime ask the user is there is a diff to be
checked)