> > uhm ok .. can I expect to get a release with this feature in the near future ?
> 
> I checked how I would do that and did not find a good solution. If I put a
> 
> <img width=300 ...> 
> 
> for example, this scales down a big picture to only 300 pixels width. But if you submit a small
> picture, like just an icon, it blows it up to 300 pixels as well, which does not look nice.
> Unfortunatle I don't know of any option like "maxwidth=x" which only scales pictures down if they
> are larger than x. Do you know?

the following patch should do the job:


#################################################################################
--- elogd_orig.c        2005-02-03 16:46:10.000000000 +0100
+++ elogd_imgscale.c    2005-02-08 18:58:14.000000000 +0100
@@ -13690,9 +13690,14 @@
                       ("<tr><td colspan=%d class=\"attachment\">%s %d: <a href=\"%s\">%s</a>\n",
                        colspan, loc("Attachment"), index + 1, ref, attachment[index] + 14);
                   if (show_attachments)
-                     rsprintf
-                         ("</td></tr><tr><td colspan=%d class=\"messagelist\"><img
src=\"%s\"></td></tr>",
-                          colspan, ref);
+                     if (!getcfg(lbs->name, "Attached image width", str, sizeof(str))) {
+                        rsprintf("</td></tr><tr><td colspan=%d class=\"messagelist\"><img
src=\"%s\"></td></tr>",
+                                 colspan, ref);
+                    } else {
+                        rsprintf("</td></tr><tr><td colspan=%d class=\"messagelist\">"
+                                 "<div style=\"width: %s\"><img src=\"%s\" style=\"width:
100%\"></div></td></tr>",
+                                 colspan, str, ref);
+                    }
                } else {
                   rsprintf
                       ("<tr><td colspan=%d class=\"attachment\">%s %d: <a href=\"%s\">%s</a>\n",
@@ -18090,7 +18095,10 @@
                   if (is_image(att)) {
                      rsprintf("<tr><td class=\"messageframe\">\n");
                      rsprintf("<a name=\"att%d\"></a>\n", index + 1);
-                     rsprintf("<img src=\"%s\"></td></tr>", ref);
+                     if (!getcfg(lbs->name, "Attached image width entry", str, sizeof(str)))
+                        rsprintf("<img src=\"%s\"></td></tr>", ref);
+                    else
+                        rsprintf("<div style=\"width: %s\"><img src=\"%s\" style=\"width:
100%\"></div></td></tr>", str, ref);
                      rsprintf("</td></tr>\n\n");
                   } else {
                      if (is_ascii(file_name)) {
##########################################################################################

two new elog.conf parameters are defined:
Attached image width          ; width of full view image attached
Attached image width entry    ; width of attached image in the entry list view

plz apply :-)

> > ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; 
> > Attributes = Author, Type, Category, Subject 
> > Required Attributes = Author, Type, Subject 
> > Options Type = Deposition{1}, Arc Studies{1}, Conditioning{1}, Vacuum{2}, 
> > Other{3} 
> > Preset Type = Deposition 
>  
> The "Preset xxx" option actually never was ment to be used with conditional 
> attributes. I added that functionality in rev. 1.553. Please give it a try. 
 
it works fine !!! thank you so much (btw, using Preset xxx{1} it doesn't 
works.. but it should be the correct beaviour) 

> > current version uses strstr() to check if the file has the expected ascii 
> > text extension ... this is buggy becouse this way a file named 
> > ".txt_hidden_file" or "foo.config.dat" are both seen as .txt files. 
>  
> I added your routine chkext() to the code, but actually use it differently. I 
> display now ASCII files not by their extension, but the code checks for each file 
> to contain non-printable characters. If it contains all printable letters, and does 
> not have the extension PDF, PS or EPS, it's shown inline. 
 
I totally agree with you choice :-) 

> > the following should do the job: 
> >  
> > <div style="width: 200px"> 
> > <img src="IMG_3133.jpg" style="width: 100%" /> 
> > </div> 
> >  
> > the configurable parameter should be with obviously :-) 
>  
> Unfortunately not. Please find attached the screen dump from such a try, together with the HTML code. 
> As you can see, the little elog icon is stretched to the same width as the upper (large) picture. 
 
you are right ;-( I used a different code in my test and sent you and old test code, *but* also the last 
one does not works on every browser ... the following code would do the job, but it seems to work only 
in gecko-based browsers such as mozilla, firefox and safari ... 
 
<div style="width: 200px"> 
 <img src="IMG_3133.jpg" style="max-width: 200" /> 
</div> 
 
other browsers do not scale the vertical dimention :-( 

> > as this url shows http://www.htmlhelp.com/tools/validator/problems.html#amp
> 

> > it should be used an HTML entity instead of the ampersand sign.<p>
> 
> Can you please be a bit more specific? In which URL should the ampersand be
> replaced?

uhmm...

http://midas.psi.ch/elogs/Forum/page2?mode=threaded&expand=0&last=7

the bug is also a "documentation bug", infact similar tricks are also
in FAQs (FAQ 5 for example)

I tried to substitute avery occurrence of hard coded "&" with "&amp;" but it does
not do the job at all ... infact the first time the HTML code is ok, but
following a link let the browser to automatically decode html entities .. and
everything turns wrong again ... maybe the encoding should be done in
printing-to-the-browser-time ..

> > > as this url shows http://www.htmlhelp.com/tools/validator/problems.html#amp
> > 

> > > it should be used an HTML entity instead of the ampersand sign.<p>
> > 
> > Can you please be a bit more specific? In which URL should the ampersand be
> > replaced?
> 
> uhmm...
> 
> http://midas.psi.ch/elogs/Forum/page2?mode=threaded&expand=0&last=7
> 
> the bug is also a "documentation bug", infact similar tricks are also
> in FAQs (FAQ 5 for example)
> 
> I tried to substitute avery occurrence of hard coded "&" with "&amp;" but it does
> not do the job at all ... infact the first time the HTML code is ok, but
> following a link let the browser to automatically decode html entities .. and
> everything turns wrong again ... maybe the encoding should be done in
> printing-to-the-browser-time ..

BTW, the current url (taht should be perfectly well formed makes the elog not to
display attachments ... so may be thare is a problema in the query string decoding
routine ...

http://somehost.it:8080/LBNAME/?mode=full&amp;attach=1

> > > as this url shows http://www.htmlhelp.com/tools/validator/problems.html#amp
> > 

> > > it should be used an HTML entity instead of the ampersand sign.<p>
> > 
> > Can you please be a bit more specific? In which URL should the ampersand be
> > replaced?
> 
> uhmm...
> 
> http://midas.psi.ch/elogs/Forum/page2?mode=threaded&expand=0&last=7
> 
> the bug is also a "documentation bug", infact similar tricks are also
> in FAQs (FAQ 5 for example)
> 
> I tried to substitute avery occurrence of hard coded "&" with "&amp;" but it does
> not do the job at all ... infact the first time the HTML code is ok, but
> following a link let the browser to automatically decode html entities .. and
> everything turns wrong again ... maybe the encoding should be done in
> printing-to-the-browser-time ..

BTW, the current url (taht should be perfectly well formed makes the elog not to
display attachments ... so may be thare is a problema in the query string decoding
routine ...

http://somehost.it:8080/LBNAME/?mode=full&amp;attach=1

Display subject = <b>$subject</b>

is printed to the browser encoded, so that it is diplayed as is..