ID |
Date |
Icon |
Author |
Author Email |
Category |
OS |
ELOG Version |
Subject |
67945
|
Fri May 29 09:46:11 2015 |
| Andreas Luedeke | andreas.luedeke@psi.ch | Bug report | Linux | 3.1.0-2 | ELOG Forum: drafts cannot be deleted |
I wanted to reply to the post "Three problems..." and then changed my mind.
But since this logbook does not allow to delete entries (not even my own) I was neither able to remove the draft
nor the final entry.
Another strange thing: the draft got submitted when I hit the "Back" button after reopening it.
Cheers
Andreas |
67950
|
Thu Jun 4 18:12:43 2015 |
| David Wallis | wallis@aps.anl.gov | Question | Linux | 3.1.0-2 | Re: Timstamp button in ckedit inserts an incorrect string ( elogd 3.1.0-2) |
Additional info:
"Time format = %Y" results in "2015" being pasted into the edit window when I hit the "time stamp" button.
"Time format = %m/%Y" results in the string "06/2015"
"TIme format = %m/%d/%Y" results in the string "06/04"
"Time format = %m/%d %H" results in the string "06/04 "
David Wallis wrote: |
I just updated to the latest official release (V3.1.0-2411f95) and have these problems:
- The Time Stamp button pastes the logbook name when "Time format" is not specified in elogd.cfg, and when it is set to "%m/%d/%Y %H:%M", it adds the string "5/28/."
- Drag and drop for attachments dosn't work on either Chrome 37.0.2062.94 (64-bit) or FIrefox 31.5.3 (both on Linux). D&D works on the midas.psi.ch demo page. On my logbooks, the "drop attachements here" area does not have a dashed line border
- Auto-saving does not seem to be working.
The "Syntax of elogd.cfg" help file doesn't seem to reflect some of these features... it took me a while to find the settings for LDAP authentication. Am I just missing some settings for these features?
My users are loving the new functionality added in 3.1!
|
|
67961
|
Fri Jun 5 19:08:17 2015 |
| Andreas Luedeke | andreas.luedeke@psi.ch | Question | Linux | 3.1.0-2 | Re: ckeditor "Insert Timestamp" bug (was: Three problems with elogd 3.1.0-2) |
I can confirm that there is currently a problem with the ckeditor "Insert Timestamp" button.
It apparently calls javascript code in ckeditor/plugins/timestamp/plugin.js
to catch a string from the URL "../../?cmd=gettimedate"
(I think this is one too many "../", but anyway). if you try this for the Forum:
https://midas.psi.ch/elogs/Forum/?cmd=gettimedate
it returns the wrong string. It is "Forum" instead of the date.
PS to David: The subject "Three problems ..." is not giving any indication what it is about. I would find it better in this case to post three entries to the Forum, each with a striking title :-)
David Wallis wrote: |
Additional info:
"Time format = %Y" results in "2015" being pasted into the edit window when I hit the "time stamp" button.
"Time format = %m/%Y" results in the string "06/2015"
"TIme format = %m/%d/%Y" results in the string "06/04"
"Time format = %m/%d %H" results in the string "06/04 "
David Wallis wrote: |
I just updated to the latest official release (V3.1.0-2411f95) and have these problems:
- The Time Stamp button pastes the logbook name when "Time format" is not specified in elogd.cfg, and when it is set to "%m/%d/%Y %H:%M", it adds the string "5/28/."
- Drag and drop for attachments dosn't work on either Chrome 37.0.2062.94 (64-bit) or FIrefox 31.5.3 (both on Linux). D&D works on the midas.psi.ch demo page. On my logbooks, the "drop attachements here" area does not have a dashed line border
- Auto-saving does not seem to be working.
The "Syntax of elogd.cfg" help file doesn't seem to reflect some of these features... it took me a while to find the settings for LDAP authentication. Am I just missing some settings for these features?
My users are loving the new functionality added in 3.1!
|
|
|
67963
|
Fri Jun 5 23:02:06 2015 |
| David Wallis | wallis@aps.anl.gov | Question | Linux | 3.1.0-2 | Re: ckeditor "Insert Timestamp" bug (was: Three problems with elogd 3.1.0-2) |
Andreas,
I too was able to track the problem down to the "gettimedate" function in elogd.c. It looks like the code is using a variable named "str" for several different purposes. I haven't had a chance to do any testing, but my suspsicion is that the size of the dynamically allocated variable is ending up too small for the time stamp string, so it gets truncated.
Your point about the topic title is a good one - I'll split this into separate issues, thanks!
Andreas Luedeke wrote: |
I can confirm that there is currently a problem with the ckeditor "Insert Timestamp" button.
It apparently calls javascript code in ckeditor/plugins/timestamp/plugin.js
to catch a string from the URL "../../?cmd=gettimedate"
(I think this is one too many "../", but anyway). if you try this for the Forum:
https://midas.psi.ch/elogs/Forum/?cmd=gettimedate
it returns the wrong string. It is "Forum" instead of the date.
PS to David: The subject "Three problems ..." is not giving any indication what it is about. I would find it better in this case to post three entries to the Forum, each with a striking title :-)
David Wallis wrote: |
Additional info:
"Time format = %Y" results in "2015" being pasted into the edit window when I hit the "time stamp" button.
"Time format = %m/%Y" results in the string "06/2015"
"TIme format = %m/%d/%Y" results in the string "06/04"
"Time format = %m/%d %H" results in the string "06/04 "
David Wallis wrote: |
I just updated to the latest official release (V3.1.0-2411f95) and have these problems:
- The Time Stamp button pastes the logbook name when "Time format" is not specified in elogd.cfg, and when it is set to "%m/%d/%Y %H:%M", it adds the string "5/28/."
- Drag and drop for attachments dosn't work on either Chrome 37.0.2062.94 (64-bit) or FIrefox 31.5.3 (both on Linux). D&D works on the midas.psi.ch demo page. On my logbooks, the "drop attachements here" area does not have a dashed line border
- Auto-saving does not seem to be working.
The "Syntax of elogd.cfg" help file doesn't seem to reflect some of these features... it took me a while to find the settings for LDAP authentication. Am I just missing some settings for these features?
My users are loving the new functionality added in 3.1!
|
|
|
|
67967
|
Mon Jun 8 12:02:30 2015 |
| Stefan Ritt | stefan.ritt@psi.ch | Question | Linux | 3.1.0-2 | Re: ckeditor "Insert Timestamp" bug (was: Three problems with elogd 3.1.0-2) |
Indeed the "str" variable at the gettimedate function had the wrong string size, so that all date strings got truncated at 8 characters. That's what you've seen. Also the ../../?cmd=gettimedate was wrong and it should be ./?cmd=gettimedate. I committed the fix to GIT so it will be contained in the next release ofe log.
David Wallis wrote: |
Andreas,
I too was able to track the problem down to the "gettimedate" function in elogd.c. It looks like the code is using a variable named "str" for several different purposes. I haven't had a chance to do any testing, but my suspsicion is that the size of the dynamically allocated variable is ending up too small for the time stamp string, so it gets truncated.
Your point about the topic title is a good one - I'll split this into separate issues, thanks!
Andreas Luedeke wrote: |
I can confirm that there is currently a problem with the ckeditor "Insert Timestamp" button.
It apparently calls javascript code in ckeditor/plugins/timestamp/plugin.js
to catch a string from the URL "../../?cmd=gettimedate"
(I think this is one too many "../", but anyway). if you try this for the Forum:
https://midas.psi.ch/elogs/Forum/?cmd=gettimedate
it returns the wrong string. It is "Forum" instead of the date.
PS to David: The subject "Three problems ..." is not giving any indication what it is about. I would find it better in this case to post three entries to the Forum, each with a striking title :-)
David Wallis wrote: |
Additional info:
"Time format = %Y" results in "2015" being pasted into the edit window when I hit the "time stamp" button.
"Time format = %m/%Y" results in the string "06/2015"
"TIme format = %m/%d/%Y" results in the string "06/04"
"Time format = %m/%d %H" results in the string "06/04 "
David Wallis wrote: |
I just updated to the latest official release (V3.1.0-2411f95) and have these problems:
- The Time Stamp button pastes the logbook name when "Time format" is not specified in elogd.cfg, and when it is set to "%m/%d/%Y %H:%M", it adds the string "5/28/."
- Drag and drop for attachments dosn't work on either Chrome 37.0.2062.94 (64-bit) or FIrefox 31.5.3 (both on Linux). D&D works on the midas.psi.ch demo page. On my logbooks, the "drop attachements here" area does not have a dashed line border
- Auto-saving does not seem to be working.
The "Syntax of elogd.cfg" help file doesn't seem to reflect some of these features... it took me a while to find the settings for LDAP authentication. Am I just missing some settings for these features?
My users are loving the new functionality added in 3.1!
|
|
|
|
|
67983
|
Tue Jun 9 17:09:22 2015 |
| Stefan Ritt | stefan.ritt@psi.ch | Bug report | Linux | 3.1.0-2 | ELOG Forum: drafts cannot be deleted |
> Another strange thing: the draft got submitted when I hit the "Back" button after reopening it.
Well, this is a problem indeed. When edit entries now, drafts gets saved regularly, overwriting your original entry. This is a limitation of the elog database, which cannot do full versioning. So "Back" is actually the same as "Commit without email notification". Or better "Commit some ten seconds ago". Now I
don't know what the best solution is. I'm tempted to just remove the "Back" button and replace it with a "Delete" button. So people can either submit an entry or delete it completely. Any thoughts? |
67993
|
Wed Jun 10 10:43:02 2015 |
| Andreas Luedeke | andreas.luedeke@psi.ch | Bug report | Linux | 3.1.0-2 | ELOG Forum: drafts cannot be deleted |
> > Another strange thing: the draft got submitted when I hit the "Back" button after reopening it.
>
> Well, this is a problem indeed. When edit entries now, drafts gets saved regularly, overwriting your original entry.
> This is a limitation of the elog database, which cannot do full versioning.
> So "Back" is actually the same as "Commit without email notification". Or better "Commit some ten seconds ago".
> Now I don't know what the best solution is.
> I'm tempted to just remove the "Back" button and replace it with a "Delete" button.
> So people can either submit an entry or delete it completely. Any thoughts?
I think it would be nice to have three options:
- "Submit": making the draft entry a "real" entry, with an ID
- "Abort": keeping the entry as a draft entry as it currently is (or was 10 sec ago)
- "Delete": removing the draft entry.
I understand that the draft is overwritten currently by the "Back" button, but why does it get an ID and does not stay as a "Draft"?
As a quick fix you may skip the "Abort" for now and just provide "Submit" and "Delete". |
67994
|
Wed Jun 10 10:55:00 2015 |
| Stefan Ritt | stefan.ritt@psi.ch | Bug report | Linux | 3.1.0-2 | ELOG Forum: drafts cannot be deleted |
> I think it would be nice to have three options:
> - "Submit": making the draft entry a "real" entry, with an ID
> - "Abort": keeping the entry as a draft entry as it currently is (or was 10 sec ago)
> - "Delete": removing the draft entry.
>
> I understand that the draft is overwritten currently by the "Back" button, but why does it get an ID and does not stay as a "Draft"?
> As a quick fix you may skip the "Abort" for now and just provide "Submit" and "Delete".
Any entry in elog (also drafts) need an ID in order to be stored on the server, no way around that.
The "Abort" button is exactly the same as the "Back" button, just the name is different. But I think the meaning will not be so clear
to the users. They could expect to abort the edit, and get the version as it was before they started editing (which is not possible).
So I'm tempted to just have "Submit" and "Delete". If one wants to abort, one can navigate away from the page, and confirm the "Leave page"
dialog box. So experts who know what they do can still do an abort if necessary.
Stefan |