Demo Discussion
Forum Config Examples Contributions Vulnerabilities
  Discussion forum about ELOG, Page 400 of 808  Not logged in ELOG logo
icon4.gif   Numbered lists get closed by </ul>, posted by T. Ribbrock on Mon Jan 30 16:26:08 2006 
I just ran into the following problem (and was able to reproduce it in the "demo" logbook on this site):

  • Create a new entry
  • Create a numbered list:
    [LIST=1]
    [*] 1st entry
    [*] 2nd entry
    [/LIST]
    
  • In the resulting HTML code, the closing statement of that list translates to </ul> instead of </ol>, causing the list to remain open and all following text to be intented by the list indentation. This gets worse when several such lists are used in one document. I'll include an example below.

Numbered list follows:

  1. one
  2. two
  3. three

This text is indented, as the list was not closed properly.

  1. four
  2. five
  3. six

And now we have double indention...
icon5.gif   elog allows me to create user "blahblah ", posted by Dimitrios Tsirigkas on Fri Feb 3 18:15:47 2006 
Hi,

I noticed that when I register a username that contains whitespaces (eg "boing "), elog allows me to create the user of that name and updates the password file accordingly. It doesn't log me in, but it gives me no error message either. I also found that if I repeat the process it adds yet another entry in the password file, by the same name "boing ". Is that a bug or is there something wrong with my configuration?

Cheers,
Dimitris
    icon2.gif   Re: elog allows me to create user "blahblah ", posted by Dimitrios Tsirigkas on Fri Feb 3 18:25:32 2006 
By the way, it is also possible to create a user that doesn't have a password! Shouldn't that be forbidden?

Dimitris
    icon2.gif   Re: elog allows me to create user "blahblah ", posted by Stefan Ritt on Mon Feb 6 12:54:25 2006 

Dimitrios Tsirigkas wrote:
By the way, it is also possible to create a user that doesn't have a password! Shouldn't that be forbidden?


Well, some people want that!
    icon2.gif   Re: elog allows me to create user "blahblah ", posted by Stefan Ritt on Mon Feb 6 12:58:26 2006 

Dimitrios Tsirigkas wrote:
I noticed that when I register a username that contains whitespaces (eg "boing "), elog allows me to create the user of that name and updates the password file accordingly. It doesn't log me in, but it gives me no error message either. I also found that if I repeat the process it adds yet another entry in the password file, by the same name "boing ". Is that a bug or is there something wrong with my configuration?


Well, I tell you what is wrong: The form says explicitly (name may not contain blanks) and you did not listen Tongue

I can add a simple check if the name contains blanks, but then some people will come up with other strange characters (@#$%), and I'm not sure which of those gives problems. If you test this carefully and tell me which characters to make forbidden, I will happyly add a simple check.
    icon2.gif   Re: elog allows me to create user "blahblah ", posted by Dimitrios Tsirigkas on Mon Feb 6 16:27:45 2006 

Stefan Ritt wrote:

Dimitrios Tsirigkas wrote:
By the way, it is also possible to create a user that doesn't have a password! Shouldn't that be forbidden?


Well, some people want that!


Ok, fair enough. But maybe there could be an optional flag in the configuration that disables blank passwords... I wouldn't want some imposter to start entering stuff under the username of another user, so it would be nice if I could have some way of forcing them to have a password, even if it's a one-letter password.

Thanks,

Dimitris
    icon2.gif   Re: elog allows me to create user "blahblah ", posted by Stefan Ritt on Mon Feb 6 16:53:41 2006 

Dimitrios Tsirigkas wrote:
I wouldn't want some imposter to start entering stuff under the username of another user, so it would be nice if I could have some way of forcing them to have a password, even if it's a one-letter password.


Ok, I added an empty password check. If too many people will complain, I will make it a flag.
    icon2.gif   Re: Numbered lists get closed by </ul>, posted by Stefan Ritt on Tue Feb 7 12:58:10 2006 

T. Ribbrock wrote:
I just ran into the following problem (and was able to reproduce it in the "demo" logbook on this site):

  • Create a new entry
  • Create a numbered list:
    [LIST=1]
    [*] 1st entry
    [*] 2nd entry
    [/LIST]
    
  • In the resulting HTML code, the closing statement of that list translates to </ul> instead of </ol>, causing the list to remain open and all following text to be intented by the list indentation. This gets worse when several such lists are used in one document. I'll include an example below.

Numbered list follows:

  1. one
  2. two
  3. three

This text is indented, as the list was not closed properly.

  1. four
  2. five
  3. six

And now we have double indention...


I can't see any double indention there...

But seriously Wink I fixed that problem and updated this elog server already. It's in SVN revison 1653. The code now correctly chooses the proper </ul> or </ol>. What will not work however are nested lists, like an ordered list inside an unordere list, but that's anyhow very uncommon.
ELOG V3.1.5-3fb85fa6