Yepp, you're right. I applied your change to the distribution code. 

Tried 2178 and I seem to hit some endless loop when I have big cookies. The loop seems to be in this for-loop (from gdb).

I perhaps you should have:

for (i = 0; *p && *p != ';' && *p != '\r' && *p != '\n' ; )

   if (i < (int) sizeof(cookie)-1)

      cookie[i++] = *p++;

   else
      break;

   cookie[i] = 0;

... Seems to be working for me =)

> Hi Stefan,
> 
> Must have missed it when the fixed/not fixed thread marking got implimented.
> 
> Anyhow, my main point would still apply for where the thread is not yet fixed, but is in one of a number of possible
> states  (waiting, panic, work-in-progress....).  Clearly you can label the latest entry in a thread with the latest
> status, and icon, but when in collapsed mode, you only see the initial entry.  If the latest entry were shown
> (optionally), then one can tell at a glance in the collapsed listings which entry may need direct attention.

If you always mark the whole thread with states (waiting, panic, work-in-progress,...) as described in my last posting, 
then you will see this from the thread initial entry as well. If you use icons, then even more. The only disadvantage 
is that you have to discipline yourself always modifying the whole thread and not only one entry in that thread.

Hi

I was just wondering if there was a way that the comments for a logbook could be set to be invisible on the Selection page but then displayed once a user has logged in to a particular logbook?

This is required for security purposes. I want a common login page which shows all logbooks, where the logbook names only have meaning for people who know them but then once logged in the comment provides additional information about that logbook.

Thanks

Adam

Hi Stefan,

Must have missed it when the fixed/not fixed thread marking got implimented.

Anyhow, my main point would still apply for where the thread is not yet fixed, but is in one of a number of possible
states  (waiting, panic, work-in-progress....).  Clearly you can label the latest entry in a thread with the latest
status, and icon, but when in collapsed mode, you only see the initial entry.  If the latest entry were shown
(optionally), then one can tell at a glance in the collapsed listings which entry may need direct attention.



> > In the past I have requested the "mark whole thread" feature, not yet implimented.
> 
> That's not correct, it is implemented. Just add an attribute for that. Assume you have problem reports, so you 
> add
> 
> Attributes = ..., Fixed
> Options Fixed = boolean
> Quick filter = Fixed
> 
> If you add a new entry, "Fixed" is false by default. All replies to that entry will contain then the same flag. 
> Now if you want to mark the whole thread as fixed, do the following:
> 
> - go into list display
> - display all entries in threaded mode
> - click on "Select"
> - select the thread you want to mark as fixed and click "Edit"
> - now keep all attributes, but check the "Fixed" check box
> 
> and voila, the whole thread will contain "Fixed = 1". Using the quick filter, you can now show all fixed threads 
> with one click.

 Thanks for the bug fix, we'll get our installation updated ASAP. And I will look into why some of my pdf file image sizes are interpreted incorrectly by ImageMagick, it might having something to do with how I've generated them.

Is it possible to set the default image size to always scale to fit the browser window? For example, this entry has a png attachment, but it still suffers from the fact that the text window size is set by the width of the png image.

If I'm forgetting something, sorry, I'm writing in a hurry!

Dennis

Your problem 1) is probably caused by ImageMagick. I use that package to convert PDFs to images. If this package estimates the paper size from the PDF incorrectly, you're screwed. You can go and actually locate the thumbnail pictures in the ELOG directory (should be named  xxxxxx_yyyyyy_<name>-0.png). If you check these pictures, they are probably already huge.

Problem 3) indeed is a small bug in elogd, which I fixed in revision #2178. If you can download the SVN version and recompile elogd, you should be fine:

Apologies if these are known bugs, I'm very busy at the moment but I wanted to post this before I forget:

I'm using Safari on a Mac to make Elog entries.

1) The preview of some pdf attachments in edit mode displays huge areas of white space around each page. I can send examples if you'd like - please email me directly, for some reason I never get email notifications from this forum (and they aren't being tagged as spam, so I don't know where they go).

2) When that happens, the text entry area for ELcode format expands horizontally to match the huge pdf file width. Text without line feeds then doesn't wrap until the huge window width is filled, so I have to scroll horizontally all the time while editing to see what I've written.

3) So I turned off attachment previewing as a workaround (Preview attachments = 0 ). That worked fine by not expanding the entry area, but I noticed some odd behavior. The list of attachments below the text entry area is badly formatted. Here's a screen shot:

I tried to reproduce this with a new entry but the text was formatted properly for that entry.

P.S. While editing this entry, I see that the text area width is again being set by the width of the picture I've attached - try it yourself; if you try to resize your browser window smaller while editing, the text will only wrap until the width of the attachment is reached - the text no longer wraps at smaller widths than the attachment.