ELOG Forum

Execute new|edit doesn't seem to work

3.1.1

I am trying to use the "Execute new|edit|delete" feature to track changes to an elog using git.

When a new entry is created a shell script should be executed (certain attributes of the logbook entry should be passed as arguments to it). The script will then automatically stage all changes and create an appropriate git commit message. For a "new" entry in the logbook the commit message is a bit more verbose. When editing or deleting a message only a short commit message like "Edit message 25" should be created. Therefore I really need to distinguish between "new", "edit", and "delete".

However, I experienced unreproducible behavior when creating "new" entries. Sometimes the command specified by "Execute new=" is called, sometimes the one specified by "Execute edit=" is executed. Most of the time it doesn't work as expected. Frown

What I did so far to understand what goes wrong is I looked into elogd.c and found in

void submit_elog(LOGBOOK * lbs)

that bedit is sometimes true and sometimes false, when creating a new entry, although it should be false then (right?).
This is why elogd then sometimes retrieves the wrong shell command from getcfg(lbs->name, "Execute edit"...) instead of getcfg(lbs->name, "Execute new"...) around line 23610 (not exact due to some eprintf()s inserted here and there to look at bedit and so on).

When deleting an entry, everything works fine: the shell command defined via "Execute delete=" is run, but this happens somewhere else in the code so it's not a surprise.

Do you have an idea how to fix this or can you point me in some direction to further track it down? Thank you!

68276

Mon Mar 7 13:03:13 2016

Juergen Diefenbach

diefenba@uni-mainz.de

Re: Execute new|edit doesn't seem to work

3.1.1

Andreas Luedeke wrote:

I'm just guessing, but you could try to disable the "save drafts" feature and see if the behaviour changes:
Save drafts = 0

If that is the case then Stefan will know where to look Wink

Cheers
Andreas

Alright, I tried "Save drafts = 0" in the config file and now it seems to work all the time as expected!
Thank you, Andreas!

In principle I could live with this as I don't think I need to have drafts enabled.

Cheers,
Jürgen

Draft

Wed Sep 16 01:27:20 2015

elog client overwriting attached files when editing existing log

2.9.0(elogd)

Using the elog client to upload atachments, I can successfully send attachments to an existing elog, however the existing attachments are lost.

I have tested using the elog client version 3.1.1 and elog client version 2.9.2 sending to elogd 2.9.0

elog -h localhost -p 8080 -l test -f file1.png -f file2.png -e 249 -v -x

This works great, the text contained in the elog post is retained, however all attachments are lost and replaced with those sent by this command.

Can anyone provide some tips? I am not sure if its a problem with the client or server.

Thank you in advance!

Joseph

68116

Wed Sep 16 02:47:33 2015

elog client overwriting attached files when editing existing log

2.9.0(elogd)

Using the elog client to upload atachments, I can successfully send attachments to an existing elog, however the existing attachments are lost.

I have tested using the elog client version 3.1.1 and elog client version 2.9.2 sending to elogd 2.9.0

elog -h localhost -p 8080 -l test -f file1.png -f file2.png -e 249 -v -x

This works great, the text contained in the elog post is retained, however all attachments are lost and replaced with those sent by this command.

Can anyone provide some tips? I am not sure if its a problem with the client or server.

Thank you in advance!

Joseph

68792

Fri May 4 14:43:35 2018

Elog ID entry bug at >99999 entries

2.9.2

We have a possible bug with elog that the ID for an elog entry at over 99,999 entires reads as 10,000...

68792/1 Illistrates the problem, we use this ID often to cross reference from out datalog...

Is this a know bug we can find a fix for? We are using: elogd 2.9.2 built Jul 14 2015, 18:58:06 revision

Attachment 1: sequencer_events.png

68798

Tue May 8 16:17:28 2018