> > [...]
> > > Probably it is fine to display only files ending in '.txt' per default.
> > > In addition a file that has more than say 1000 lines should probably 
> > > also not be displayed (as default, optional OK).  
> > 
> > No, '.txt' would definitely not be enough for me. I'm using elog to log all
> > administration of our network. In many cases, I simply attach a configuration
> > file. All those files are plain ASCII and none of them end in '.txt' - and I
> > would most definitely like them to be displayed inline like they are now. In
> > fact, this change was the main reason for me to upgrade to 2.5.4
> > 
> > Maybe a configuration option or a "display attachment" button would be the
> > best solution, then?
> > 
> > Cheerio,
> > 
> > Thomas
> 
> So to make everybody happy, it would probably be enough not to display inline any
> *.ps file, is that right? 

I think there should be size limit.  Imagine a multi MB text file (whatever it is;
elogd.c is already more than 1/2 MB and is likely to increase due to your
excellent support).  A client on an ISDN line would have to wait
several minutes and during this time elogd is busy and no other client can connect
(correct?).  Of course, if somebody really wants to see this file then there is
nothing to be done, but likely someone is flipping throught the messages using
to arrows on top to find the right entry....
So a configurable size limit seems appropriate, from which on 
only 'Display attachment' is displayed.  And/Or, for files
exceeding this limit, the first N (new config option) lines could be displayed.

But this should only influence ASCII files.  E.g. the behaviour for jpeg files
should not change, which is controlled by 'Hide default'.  Maybe a 'Display/Hide
defaut extension' option, where the extensions are listed that are to be displayed
is another idea, in addition to a 'Max Display ASCII inline size' option,
which can be set to zero to disable it altogether.

In any case, whatever you think is best.

Cheers, Heiko

> Is there any other ASCII format, which should not be
> displayed? PDF is binary, so it won't be displayed. What about long C files? Most
> people want to see them. In the recent version there is the "Hide attachment"
> link which can be clicked to not display an attachment inline. Mabe there should
> be a "Hide default = 0|1" config option...

> > - Use "and" and "or" operands in queries                                        
> 
> Elog supports now regular expressions. So for a "<str1> OR <str2>" one can write
> 
> <str1>|<str2>
> 
> and for a "<str1> AND <str2>" one can write
> 
> <str1>.*<str2>|<str2>.*<str1>
> 
> Looks a bit complicated, but maybe some day we will get some code which rewrites
> "AND" and "OR" as regular expressions.

It seems that the quick filter searches are now (2.5.4-6) case sensitive.
Could you add an option to specify this in the config file?  Or does it
exist already?

When compiling elogd on AMD64 (in 64 bit mode) there are many 
warnings like these:

src/regex.c:3769: warning: cast from pointer to integer of different size
src/regex.c:3769: warning: cast from pointer to integer of different size
src/regex.c:3775: warning: cast to pointer from integer of different size

The reason is the (int) cast, which (I think) is not necessary.

> > When compiling elogd on AMD64 (in 64 bit mode) there are many 
> > warnings like these:
> > 
> > src/regex.c:3769: warning: cast from pointer to integer of different size
> > src/regex.c:3769: warning: cast from pointer to integer of different size
> > src/regex.c:3775: warning: cast to pointer from integer of different size
> > 
> > The reason is the (int) cast, which (I think) is not necessary.
> 
> Unfortunately I don't have a 64-bit compiler to try. Can you please check if
> elogd.c has similar warnings or only regex.c? 

  elogd.c shows the same warnings.

> The ones in elogd.c I can fix,
> but regex.c is straight from the GNU C library, so we would have to wait intil
> they fix it. Or can you get it from the 64-bit C library? The point is that I
> need the source code, so that I can compile it under Windows as well. Can you
> try to compile elogd without regex.c, like 
> 
> gcc -g -O -W -Wall -o elogd src/elogd.c

  This works OK.
 

Could you implement a 'hide attribute' and 'sort attribute' config option?
While sort is probably not so easy to do the hide option would already 
be very useful.  What I want to do is to use elog to collect bibtex entries
which are then used to generate a bibtex file.  So, e.g. if the entry 
type 'Article' is selected I would like that all fields that do not make
sense are hidden.  Currently I just lock them.  The config looks like
this:

Attributes                  = Login, Bibtex Key, Entry Type, Address,
Annote, Author, Booktitle, Chapter, Crossref, Edition, Editor, Howpublished,
Institution, Journal, Key, Month, Note, Number, Organization, Pages,
Publisher, School, Series, Title, Type, Volume, Year, URL, Short Comment
Options Entry Type          = Article{1}, Book{2}, Booklet{3}, InBook{4},
InCollection{5}, InProceedings{6}, Manual{7}, MastersThesis{8}, Misc{9},
PhDThesis{a}, Proceedings{b}, TechReport{c}, Unpublished{d}
Required Attributes         = Entry Type
; ARTICLE
{1} Comment Author          = [required]
{1} Comment Journal         = [required]
{1} Comment Title           = [required]
{1} Comment Year            = [required]
{1} Locked Attributes       = Address, Annote, Booktitle, Chapter, Crossref,
Edition, Editor, Howpublished, Institution, Key, Organization, Publisher,
School, Series, Type


Instead of Locking the attributes, hiding them altogether would make the
entry form look much nicer.  
A further improvement would be to sort the attributes, e.g. for author I
would sort the like this, i.e. the more important entries first:

{1} Sort Attributes    = Author, Title, Journal, Volume, Pages, Year, Month,
Number, Note

Attributes not mentioned in the sort line could then be displayed 
in any order. 

I just submitted a reply to elog:847 (the reply is elog:853).
Normally the thead containing the reply should now be listed as
the top thread.  Instead only the original message of the thread
(elog:820) is listed but the remaining messages in the thread are not 
listed.  It seems the problem is that for elog:820 the 'reply to this'
header is missing.  And elog:820 and elog:824 are the same messages
except that for elog:824 the subject is missing.  Actually ALL attributes
for elog:824 are missing.

I guess you could fix things up if you:
- add 'reply to this: 823' to elog:820
- remove entry elog:824

Could you implemet and option 'admin menu' which gets displayed
when an 'admin' is logged in.  This menu could e.g. also include 'Delete'
while the normal menu would not.

> > Could you implement a 'hide attribute' and 'sort attribute' config option?
> 
> I implemented it as 'hidden attributes = <list>' and 'sort attributes'.

'sort attributes' sorts the logbook entries when they are displayed.  Or?

What I want is to rearrange the entry mask.  E.g. if 'Entry type' article is
selected then the attributes 'Author', 'Journal', 'Title', and 'Year' 
should be listed first, as they are required for this bibtex entry type.
Is it possible with the current elogd version to also sort (rearrange) the 
attributes in the entry mask?  If yes, how?  

Thanks for your time.