> > I tried to substitute avery occurrence of hard coded "&" with "&" but it does
> > not do the job at all ... infact the first time the HTML code is ok, but
> > following a link let the browser to automatically decode html entities .. and
> > everything turns wrong again ... maybe the encoding should be done in
> > printing-to-the-browser-time ..

That won't help, since the 'Start page = ...' string is used for redirection (outside
of any HTML). The '&' thing should only occur inside the HMTL text.

I changed elogd.c to encode things properly, but I'm not sure if I covered all
occurences. Can you try release 1.576 if it works correctly?

Display subject = <b>$subject</b>

is printed to the browser encoded, so that it is diplayed as is..

> 
> Display subject = <b>$subject</b>
> 
> is printed to the browser encoded, so that it is diplayed as is..

I fixed that in revision 1.587. Note however that you should do the formatting
of attributes better using the CSS functionality, since it gives you more
possibilities. See for example the subject of this forum, which has it's own
CSS class "subjname", which has a larger font size. You select your own class like

Format Subject = 0, subjname, subjvalue

in the configuration file. Then add the classes into the CSS file.

Now elog shows each attribute which contains a "<b>" encoded (as HTML). But if you
want to write a subject line like "For bold use <b> in HTML", then the "<b>"
triggers the HTML display, so it is not written as is, which is not what you want in
that case. Since there is no switch "Submit as HTML text" for the attributes, it is
hard for elog to "guess" if you want HTML encoded or not.

When an attached image name contains a space in its filename and attachment
display is enabled elog builds a wrong url to the image:

http://arcolog.roma2.infn.it:8080/ARCO/050309_170709/peeling+002.jpg

instead of the correct one:

http://arcolog.roma2.infn.it:8080/ARCO/050309_170709_peeling+002.jpg

The more annoing thing is that elogs hangs on this. a strace shows a select
on fd n°3 and 5 that loops forever (returning a timeout error):

send(4, "<141>Mar 23 11:36:25 elogd[22189"..., 35, 0) = 35
rt_sigaction(SIGPIPE, {SIG_IGN}, NULL, 8) = 0
select(1024, [3 5], NULL, NULL, {1, 0}) = 0 (Timeout)
select(1024, [3 5], NULL, NULL, {1, 0}) = 0 (Timeout)


May be the better solution is, after fixing the bug for backward
compatibility with already uploaded images, to implement a forced characters
substitution at upload time, replacing spaces and every character not in a
"allowed chars" list with an underscore

> When an attached image name contains a space in its filename and attachment
> display is enabled elog builds a wrong url to the image:
> 
> http://arcolog.roma2.infn.it:8080/ARCO/050309_170709/peeling+002.jpg
> 
> instead of the correct one:
> 
> http://arcolog.roma2.infn.it:8080/ARCO/050309_170709_peeling+002.jpg
> 
> The more annoing thing is that elogs hangs on this. a strace shows a select
> on fd n°3 and 5 that loops forever (returning a timeout error):
> 
> send(4, "<141>Mar 23 11:36:25 elogd[22189"..., 35, 0) = 35
> rt_sigaction(SIGPIPE, {SIG_IGN}, NULL, 8) = 0
> select(1024, [3 5], NULL, NULL, {1, 0}) = 0 (Timeout)
> select(1024, [3 5], NULL, NULL, {1, 0}) = 0 (Timeout)
> 
> 
> May be the better solution is, after fixing the bug for backward
> compatibility with already uploaded images, to implement a forced characters
> substitution at upload time, replacing spaces and every character not in a
> "allowed chars" list with an underscore

A correction:
the url generated is correct, infact modifing by hand the names of the files and
the "Attachment:" entry in the .log all works fine

the same problem happens if the filename is, for example foo.JPG and not foo.jpg :
http://arcolog.roma2.infn.it:8080/ARCO/050221_171508/Graph3.JPG
loops forever

http://arcolog.roma2.infn.it:8080/ARCO/050221_171508/Graph3.jpg
works correctly


so, elog does not like spaces in filename and/or uppercase extensions. the
solution is, IMHO, to sanify the uploaded filename at uploading time :-)

> When an attached image name contains a space in its filename and attachment
> display is enabled elog builds a wrong url to the image:
> 
> http://arcolog.roma2.infn.it:8080/ARCO/050309_170709/peeling+002.jpg
> 
> instead of the correct one:
> 
> http://arcolog.roma2.infn.it:8080/ARCO/050309_170709_peeling+002.jpg

This is on purpose. If you want to save an attachment locally and right click on
the attachment, and select "Save link as..." in your browser, then the default
file name is taken from the link. If your original file namw was "peeling
002.jpg", then you want again the same name, and not "050309_170709_peeling
002.jpg, because you would have to delete the date/time part of the file name
each time which would be annoying. That's why I have chosen to put an artificial
"/" between the date/time and the original file name. On the elog side, it's
converted correctly back to the file name.

The problem with blanks in attachment names I could not reproduce. See this
post, which contains an attachment with a blank in it. As you can see, this does
not crash the server. 

Using 2.5.8, if I set "Protect Selection page" to 1, then elogd seg faults
as soon as it is accessed.

Under 2.5.7, a login page will come up, and the logbook will work, but only
if a valid username/password is given.  If an invalid login is given, then
elogd crashes.  We have a cron job that periodically restarts elogd if it is
has crashed.

Steve

[global]
logbook tabs = 0
port = 8080
Protect Selection page = 1
Password file = user.info
Admin user = saw
 

> Using 2.5.8, if I set "Protect Selection page" to 1, then elogd seg faults
> as soon as it is accessed.

Thanks for reporting this bug. I fixed it and committed the change to CVS.

- Stefan