ID |
Date |
Icon |
Author |
Author Email |
Category |
OS |
ELOG Version |
Subject |
1212
|
Fri Jun 24 21:02:05 2005 |
| Stefan Ritt | stefan.ritt@psi.ch | Bug report | Linux | 2.5.9 | Re: elog crashes when admin tries to register new users |
Heiko Scheit wrote: | Not really, unless you have a fixed 2.5.9 version. Version 2.6 has
way too many new features, which I don't want at the moment. Or is
there a config option to get the old behavior?
Maybe you should consider supporting two branches, say 'stable' (2.5.9
currently) and 'experimental' (2.6 currently)? For 'stable' only
severe bugs and security issues are fixed and in 'experimental' new
features are introduced. What do you say?
|
I think elog is such a small project that supporting several branches makes no sense. You can do this if you have several developers, one taking care of each branch. But as you know I'm alone. But what I can do is the following:
- Have a default switch for the Encoding. So if "default encoding = plain", the "plain" radio button is on by default, so people tend to write plain text rather than ELCoded text.
- Have either a switch for the email notification, to revert back to the old text format, or have a multipart email message. I saw that outlook sometime does that. One email can contain a "plain" part and an "HTML" part. So you can select in your email reader which one to display. At least thunderbird supports that. But I don't know what your bash scripts say to that, please let me know.
Heiko Scheit wrote: | For me the risk of upgrading to 2.6 now seems to high, as many people
depend on the logbook. |
Well, that's why it's called "beta". I first want to make sure that the transition to the new version goes smooth, and nobody's installation gets problems. So the old logbooks should be still readable without any modification, and once I implemented the "dual plain/html" email notification, you should be fine to upgrade. Is that correct?
- Stefan |
1213
|
Fri Jun 24 21:15:14 2005 |
| Stefan Ritt | stefan.ritt@psi.ch | Bug report | Linux | 2.5.9 | email flagged as spam |
Heiko Scheit wrote: |
X-Spam-Score: 4.875 (****) ADDRESS_IN_SUBJECT, BAYES_00,HTML_40_50,
HTML_IMAGE_ONLY_24, HTML_MESSAGE, MIME_HEADER_CTYPE_ONLY,
MIME_HTML_ONLY, MSGID_FROM_MTA_HEADER, MSGID_FROM_MTA_ID,
NO_REAL_NAME, SPF_FAIL, SPF_HELO_PASS, TO_MALFORMED
Maybe you can see what the problem is. |
Apparently the problem is in the HMTL contents of the email message. I use SpamAssassin 3.0.2 and do not get more than three points, that's why I haven't seen that problem before. It looks to me like reverting back to plain text will remove most of the hits, although not all. What happens if you write an HTML email to yourself, is this then flagged as spam, too? The TO_MALFORMED I have no chance, since I send each notification just once, it contains now ~300 email destination addresses. Since I don't want that everyone sees these addresses, I put a dummy "To:" there ("Omit Email to = 1"), but this is then of course a fake "To:" and triggers the spam filter. |
1216
|
Fri Jun 24 22:44:03 2005 |
| Stefan Ritt | stefan.ritt@psi.ch | Bug report | All | 2.6.0beta2 | Re: [BUG] show only new entries |
Emiliano Gabrielli wrote: | the new link "show only new entries" is very useful but seems to still have some problems:
- I can't find any simple way to return to the "every entries" display .. may be the link has to be switched to a checkbox to be actived or not
- I found a way (at least)... following the "config" link, doing nothing and coming back restores the view .. this is a feature now, but when a less tricky mechanism will be implemented will become a bug

|
I added a "Show all entries" link to go back.
Emiliano Gabrielli wrote: | another entry for my wishlist:
writeing the above code I noticed that the elcode buttons are lacking of a "[ *]" shortcut .. it will be very usefull  |
I added that to elcode.js . So if you click on the list button, the (LIST) tag and the the first (*) are inserted.
Emiliano Gabrielli wrote: | Writeing the wish above I noticed that the [ *] is interpreted as an item also otside the LIST tag .. so .. or the LIST tag is optional, or the [ *] should not be interpreted outside of it ... it's another bug ? P |
Well, the ELCode stuff if a poor man's version of HTML. So each [ LIST] gets converted into a <UL> tag, and each [ *] gets converted into a <LI> tag. This makes the interpretation very simple, but the code does have no clue if your are inside a [ LIST] or not. Common bulletin boards have exactly the same problem. To fix it, you would really have to interprete all the ELCode, and I don't want to write my own parser. |
1217
|
Mon Jun 27 15:09:12 2005 |
| Emiliano Gabrielli | AlberT@SuperAlberT.it | Bug report | All | 2.6.0beta2 | Re: [BUG] show only new entries |
Stefan Ritt wrote: |
Emiliano Gabrielli wrote: | the new link "show only new entries" is very useful but seems to still have some problems:
- I can't find any simple way to return to the "every entries" display .. may be the link has to be switched to a checkbox to be actived or not
- I found a way (at least)... following the "config" link, doing nothing and coming back restores the view .. this is a feature now, but when a less tricky mechanism will be implemented will become a bug

|
I added a "Show all entries" link to go back.
|
I think you only committed the changes to elcode.js but not the ones relative to elogd.c ... the Attribute quick filter is now empty, and no "show all entries" is ever displayed |
1222
|
Mon Jul 4 12:16:13 2005 |
| Emiliano Gabrielli | AlberT@SuperAlberT.it | Bug report | All | 2.6.0beta2 | Re: [BUG] show only new entries |
Emiliano Gabrielli wrote: |
Stefan Ritt wrote: |
I added a "Show all entries" link to go back.
|
I think you only committed the changes to elcode.js but not the ones relative to elogd.c ... the Attribute quick filter is now empty, and no "show all entries" is ever displayed |
Just tested the rev 1.686 .. now the link is displayed, but following the "Show only last" link the "attach=1" setting in the URL I use is removed, not being able to have inline attachment in full view. They are displayed again when turning back to "Show all entries" |
1223
|
Mon Jul 4 18:46:25 2005 |
| Emiliano Gabrielli | AlberT@SuperAlberT.it | Bug report | All | cvs | [BUG] attach=1 and inline imgs | There is a little difference in the way elog treats attachment's display in list and single message view...
It has to be, but some beaviours can be seen as bugs:
- this is a real bug (see attachment).. if a file is referred inside the text (as shown in elcode docs) it is correctly not shown when in single message view, but it remains visible both inline and as attachment in the full list view
- it would be nice for the user having, as in the single message view, the possibility of show or hide a single or all the attachements of a single message ..
|
Attachment 1: elog-showattach_bug.jpg
|
|
1224
|
Mon Jul 4 22:44:03 2005 |
| Stefan Ritt | stefan.ritt@psi.ch | Bug report | All | 2.6.0beta2 | Re: [BUG] show only new entries |
Emiliano Gabrielli wrote: | Just tested the rev 1.686 .. now the link is displayed, but following the "Show only last" link the "attach=1" setting in the URL I use is removed, not being able to have inline attachment in full view. They are displayed again when turning back to "Show all entries" |
I tried to fix this in the current CVS. Can you give it a try? |
1225
|
Tue Jul 5 11:32:34 2005 |
| Emiliano Gabrielli | AlberT@SuperAlberT.it | Bug report | All | 2.6.0beta2 | Re: [BUG] show only new entries |
Stefan Ritt wrote: |
Emiliano Gabrielli wrote: | Just tested the rev 1.686 .. now the link is displayed, but following the "Show only last" link the "attach=1" setting in the URL I use is removed, not being able to have inline attachment in full view. They are displayed again when turning back to "Show all entries" |
I tried to fix this in the current CVS. Can you give it a try? |
the following patch has to be applied over the one of you to complete it 
diff -u -r1.691 elogd.c
--- src/elogd.c 4 Jul 2005 21:12:58 -0000 1.691
+++ src/elogd.c 5 Jul 2005 09:29:57 -0000
@@ -16728,7 +16728,7 @@
/*---- apply last login cut ----*/
- if (isparam("new_entries") && isparam("unm"))
+ if (isparam("new_entries") && atoi(getparam("new_entries")) == 1 && isparam("unm"))
get_user_line(lbs, getparam("unm"), NULL, NULL, NULL, NULL, <ime_start);
/*---- assemble message list ----*/ |
|