Demo Discussion
Forum Config Examples Contributions Vulnerabilities
  Discussion forum about ELOG, Page 713 of 806  Not logged in ELOG logo
ID Date Icon Author Author Email Categorydown OS ELOG Version Subject
  67878   Tue May 5 11:01:36 2015 Reply Andreas Luedekeandreas.luedeke@psi.chBug reportLinux3.1.0Re: Problem with autosave functionality when combined with no 'edit' button

Hi Thomas,

just my two cent: as a quick workaround (for now) you could restrict editing messages to a short time range, like 30 minutes. That would cover most cases of draft messages.
Restrict edit time = 0.5
 
But I agree that it probably makes no sense to limit the editing of draft messages: Stefan will probably fix this soon.
By the way Stefan: is there a way to disable the whole draft message feature?
If people are used to e.g. the lazarus addon for firefox, they might prefer their browser to keep their drafts confidential, instead of suffering from accidental premature draft postings ;-)
 
Thomas Lindner wrote:

We recently tried upgrading the ND280 elog instance to elog 3.1.0. [1] We seem to have some problems with this 'auto-save' functionality.  Specifically, it doesn't seem to play nice with the fact that we prefer to disable user's ability to edit old messages.  So we have (up to now), had the following set of commands specified in elogd.ccfg

Menu commands = List, New, Reply, Delete, Duplicate, Copy to, Move to, Find, Help

The problem is that we now get auto-saved messages, but no ability for the user to actually go back and finish the draft message.  You can see an example of this state in this test elog

http://neut17.triumf.ca:8080/demo/

Clicking on the draft message you can see that it can't be editted.  If you try to click 'new' then edit the draft, you get the message 'Error: Command "Edit" not allowed'.  So we had zombie draft messages, until we added the edit command back; but that defeats our preference that users not mess up old messages.

In general this auto-saving seems like a useful feature.  So the ideal solution for me would be to have some mode where users could edit/finish draft messages, but where we could still disable users from editting completed/finished messages.  Ie, where we can omit 'Edit' from the menu command, but still get auto-save.

A less ideal, but perhaps simpler solution would be that if an elog has omitted 'Edit' from the menu commands, then this auto-save/save functionality is disabled so that we don't get uneditable draft messages.

[1] https://midas.psi.ch/elogs/Forum/67855

 

  67879   Tue May 5 12:05:47 2015 Reply Stefan Rittstefan.ritt@psi.chBug reportLinux3.1.0Re: Problem with autosave functionality when combined with no 'edit' button

I changed the code such that editing of draft messages is always possible, even if the "edit" command is not allowed otherwise. Update is in GIT. Please check if that works at ND280.

Thomas Lindner wrote:

We recently tried upgrading the ND280 elog instance to elog 3.1.0. [1] We seem to have some problems with this 'auto-save' functionality.  Specifically, it doesn't seem to play nice with the fact that we prefer to disable user's ability to edit old messages.  So we have (up to now), had the following set of commands specified in elogd.ccfg

Menu commands = List, New, Reply, Delete, Duplicate, Copy to, Move to, Find, Help

The problem is that we now get auto-saved messages, but no ability for the user to actually go back and finish the draft message.  You can see an example of this state in this test elog

http://neut17.triumf.ca:8080/demo/

Clicking on the draft message you can see that it can't be editted.  If you try to click 'new' then edit the draft, you get the message 'Error: Command "Edit" not allowed'.  So we had zombie draft messages, until we added the edit command back; but that defeats our preference that users not mess up old messages.

In general this auto-saving seems like a useful feature.  So the ideal solution for me would be to have some mode where users could edit/finish draft messages, but where we could still disable users from editting completed/finished messages.  Ie, where we can omit 'Edit' from the menu command, but still get auto-save.

A less ideal, but perhaps simpler solution would be that if an elog has omitted 'Edit' from the menu commands, then this auto-save/save functionality is disabled so that we don't get uneditable draft messages.

[1] https://midas.psi.ch/elogs/Forum/67855

 

  67880   Tue May 5 12:09:53 2015 Reply Stefan Rittstefan.ritt@psi.chBug reportLinux3.1.0Re: Problem with autosave functionality when combined with no 'edit' button

Arghhhh! Guess how many people asked me for the autosave feature! I worked really hard on it (including an airplane flight to Japan!), not the next guy comes "can we disable that feature?". angry

I agree that this feature has many side effects, and I have to adress one by one, but in the end the community will benefit. Think of starting a draft at one computer, and finishing at another one. Lazarus won't help you there.

Nevertheless crying, I added a "Save drafts" which you can set to zero. But I would rather prefer if people tell me their problems, and I fix them, instead of siletnly just disabling this feature and keeping the bugs there unresolved.

Andreas Luedeke wrote:

By the way Stefan: is there a way to disable the whole draft message feature?

If people are used to e.g. the lazarus addon for firefox, they might prefer their browser to keep their drafts confidential, instead of suffering from accidental premature draft postings ;-)

 

  67881   Tue May 5 12:17:24 2015 Agree Andreas Luedekeandreas.luedeke@psi.chBug reportLinux3.1.0Re: Problem with autosave functionality when combined with no 'edit' button

Oups, now I feel almost a little bit sorry for asking surprise    But thank you anyway!!! wink

You should see it that way: there are millions of possible applications for a smart electronic logbook like ELOG, and most possible combinations of flags and options will make sense for some of them smiley

Stefan Ritt wrote:

Arghhhh! Guess how many people asked me for the autosave feature! I worked really hard on it (including an airplane flight to Japan!), not the next guy comes "can we disable that feature?". angry

I agree that this feature has many side effects, and I have to adress one by one, but in the end the community will benefit. Think of starting a draft at one computer, and finishing at another one. Lazarus won't help you there.

Nevertheless crying, I added a "Save drafts" which you can set to zero. But I would rather prefer if people tell me their problems, and I fix them, instead of siletnly just disabling this feature and keeping the bugs there unresolved.

Andreas Luedeke wrote:

By the way Stefan: is there a way to disable the whole draft message feature?

If people are used to e.g. the lazarus addon for firefox, they might prefer their browser to keep their drafts confidential, instead of suffering from accidental premature draft postings ;-)

 

 

  67885   Wed May 6 17:35:14 2015 Question Bruce Bushbruce_bush@sil.orgBug reportLinux3.10.2Path disclosure on unfound file

Greetings,

  Running elog 3.1.0 on CentOS 6.6.  When I try to access a nonexistent file, elog reveals a path in the 404 page.  For example:

Not Found

The requested file /usr/local/elog/themes/default/blortblortblort7854.htm was not found on this server


ELOG version 3.1.0
 
  Is there any way to use a custom 404 page with elog, or to make it stop displaying the file information?
 
Thank you,
bb
 
 

 

  67896   Tue May 12 03:25:45 2015 Reply Andreas Luedekeandreas.luedeke@psi.chBug reportLinux3.1.0-dev"Leave Page" pop-up when "Submit" entry
I have a little problem with elogd 3.1.0. The problem persists up to the latest ELOG version, even in the
development branch (V3.1.0-8196b81):

When I want to "Submit" a new entry, I get a javascript pop-up that asks me:

_This page is asking you to confirm that you want to leave - data you have entered may not be saved._

with the options:
"Stay on page" or "Leave page".

The entry is properly submitted if I agree to "Leave page".
But it is very confusing for my users: they are afraid to loose their entry text.

This problem only shows for some specific logbook configurations.
Below is a minimal logbook configuration that shows this problem:
if you select "entry = short", the pop-up is shown;
if you select "entry = long", the pop-up is not shown, the entry is created immediately.

Attributes = entry, when
Options entry = short{1}, long
Type when = datetime
{1} Show Attributes Edit = entry


(PS: it took me several hours to boil down my 120 line configuration into four lines :-) )
Attachment 1: elogd.png
elogd.png
  67897   Tue May 12 11:27:52 2015 Reply Stefan Rittstefan.ritt@psi.chBug reportLinux3.1.0-devRe: "Leave Page" pop-up when "Submit" entry
Thanks for the "boiling-down" of your config file. That helped me to reproduce the error quickly. It only occurs if you have a date/time attribute which is hidden as a conditional attribute. This is a unusual combination, that's why I haven't seen that bug before. Actually some 
JavaScript code checks the validity of the date attribute, but since it is conditionally not there, the JavaScript code crashes, which triggers the dialog box you see. It's now fixed in the repository.

/Stefan


> I have a little problem with elogd 3.1.0. The problem persists up to the latest ELOG version, even in the
> development branch (V3.1.0-8196b81):
> 
> When I want to "Submit" a new entry, I get a javascript pop-up that asks me:
> 
> _This page is asking you to confirm that you want to leave - data you have entered may not be saved._
> 
> with the options:
> "Stay on page" or "Leave page".
> 
> The entry is properly submitted if I agree to "Leave page".
> But it is very confusing for my users: they are afraid to loose their entry text.
> 
> This problem only shows for some specific logbook configurations.
> Below is a minimal logbook configuration that shows this problem:
> if you select "entry = short", the pop-up is shown;
> if you select "entry = long", the pop-up is not shown, the entry is created immediately.
> 
> Attributes = entry, when
> Options entry = short{1}, long
> Type when = datetime
> {1} Show Attributes Edit = entry
> 
> 
> (PS: it took me several hours to boil down my 120 line configuration into four lines :-) )
  67898   Wed May 13 01:40:21 2015 Agree Andreas Luedekeandreas.luedeke@psi.chBug reportLinux3.1.0-devRe: "Leave Page" pop-up when "Submit" entry
> Thanks for the "boiling-down" of your config file. That helped me to reproduce the error quickly. It only occurs if you have a date/time attribute which is hidden as a conditional attribute. This is a unusual combination, that's why I haven't seen that bug before. Actually some 
> JavaScript code checks the validity of the date attribute, but since it is conditionally not there, the JavaScript code crashes, which triggers the dialog box you see. It's now fixed in the repository.
> 
> /Stefan
> 

Thank you Stefan!
That works nicely now.
Apparently it was less work to fix than to isolate it ;-)

Andreas
ELOG V3.1.5-3fb85fa6