Demo Discussion
Forum Config Examples Contributions Vulnerabilities
  Discussion forum about ELOG, Page 773 of 806  Not logged in ELOG logo
    icon4.gif   Re: [BUG] show only new entries, posted by Emiliano Gabrielli on Mon Jun 27 15:09:12 2005 

Stefan Ritt wrote:

Emiliano Gabrielli wrote:
the new link "show only new entries" is very useful but seems to still have some problems:

  • I can't find any simple way to return to the "every entries" display .. may be the link has to be switched to a checkbox to be actived or not
  • I found a way (at least)... following the "config" link, doing nothing and coming back restores the view .. this is a feature now, but when a less tricky mechanism will be implemented will become a bug Tongue


I added a "Show all entries" link to go back.

I think you only committed the changes to elcode.js but not the ones relative to elogd.c ... the Attribute quick filter is now empty, and no "show all entries" is ever displayed
    icon2.gif   Re: [BUG] quick filter, posted by Emiliano Gabrielli on Mon Jun 27 15:16:37 2005 

Stefan Ritt wrote:

Emiliano Gabrielli wrote:
it seems that the select box of quick filters are showing also the "{n}" appended to the Attributes in order to obtain conditional Attributes ...

see the snapshot attached


Fixed in current CVS.

BTW, I would display the date selection calender in a new floating window, not to take away all the precious screen space at the top. Then I would use the same calendar as for the date attributes, not to confuse users with two different styles.


Are you sure you really committed it ? Smile
Reguarding the calendar... the picture is just one of my tests .. I started using a popup window, but it makes complicated to do all the job I want.. so my current idea is to implemnet it a a dropdown layer, it will save both the precious space and the functionality..
I don't use the existing style becouse of, in the first popup try, it was to simple .. now I can't use it directly becouse I don't need any popup anymore.. but ok, we can keep the same style of course Smile
    icon2.gif   Re: [BUG] quick filter, posted by Emiliano Gabrielli on Mon Jun 27 15:19:05 2005 

Emiliano Gabrielli wrote:

Stefan Ritt wrote:

Emiliano Gabrielli wrote:
it seems that the select box of quick filters are showing also the "{n}" appended to the Attributes in order to obtain conditional Attributes ...

see the snapshot attached


Fixed in current CVS.

BTW, I would display the date selection calender in a new floating window, not to take away all the precious screen space at the top. Then I would use the same calendar as for the date attributes, not to confuse users with two different styles.


uhm... now the drop down menu is composed of only blancs ..

Reguarding the calendar... the picture is just one of my tests .. I started using a popup window, but it makes complicated to do all the job I want.. so my current idea is to implemnet it a a dropdown layer, it will save both the precious space and the functionality..
I don't use the existing style becouse of, in the first popup try, it was to simple .. now I can't use it directly becouse I don't need any popup anymore.. but ok, we can keep the same style of course Smile
    icon14.gif   Re: [BUG] quick filter, posted by Emiliano Gabrielli on Mon Jun 27 15:37:25 2005 

Emiliano Gabrielli wrote:

Stefan Ritt wrote:


Fixed in current CVS.


uhm... now the drop down menu is composed of only blancs ..


the following patch should solve the problem Wink
--- src/elogd.c 24 Jun 2005 20:22:33 -0000      1.685
+++ src/elogd.c 27 Jun 2005 13:34:05 -0000
@@ -15853,7 +15853,7 @@
                      if (comment[0] == 0)
                         strcpy(comment, attr_options[i][j]);

-                     for (i1=i2=0 ; i1<=(int)comment ; i1++) {
+                     for (i1=i2=0 ; i1<=(int)strlen(comment) ; i1++) {
                         if (comment[i1] == '(') {
                            option[i2++] = '\\';
                            option[i2++] = '(';
    icon4.gif   Re: [BUG] show only new entries, posted by Emiliano Gabrielli on Mon Jul 4 12:16:13 2005 

Emiliano Gabrielli wrote:

Stefan Ritt wrote:


I added a "Show all entries" link to go back.

I think you only committed the changes to elcode.js but not the ones relative to elogd.c ... the Attribute quick filter is now empty, and no "show all entries" is ever displayed


Just tested the rev 1.686 .. now the link is displayed, but following the "Show only last" link the "attach=1" setting in the URL I use is removed, not being able to have inline attachment in full view. They are displayed again when turning back to "Show all entries"
icon1.gif   [BUG] attach=1 and inline imgs, posted by Emiliano Gabrielli on Mon Jul 4 18:46:25 2005 elog-showattach_bug.jpg
There is a little difference in the way elog treats attachment's display in list and single message view...
It has to be, but some beaviours can be seen as bugs:

  • this is a real bug (see attachment).. if a file is referred inside the text (as shown in elcode docs) it is correctly not shown when in single message view, but it remains visible both inline and as attachment in the full list view
  • it would be nice for the user having, as in the single message view, the possibility of show or hide a single or all the attachements of a single message ..
    icon2.gif   Re: [BUG] show only new entries, posted by Emiliano Gabrielli on Tue Jul 5 11:32:34 2005 

Stefan Ritt wrote:

Emiliano Gabrielli wrote:
Just tested the rev 1.686 .. now the link is displayed, but following the "Show only last" link the "attach=1" setting in the URL I use is removed, not being able to have inline attachment in full view. They are displayed again when turning back to "Show all entries"


I tried to fix this in the current CVS. Can you give it a try?


the following patch has to be applied over the one of you to complete it Smile
diff -u -r1.691 elogd.c
--- src/elogd.c 4 Jul 2005 21:12:58 -0000       1.691
+++ src/elogd.c 5 Jul 2005 09:29:57 -0000
@@ -16728,7 +16728,7 @@

    /*---- apply last login cut ----*/

-   if (isparam("new_entries") && isparam("unm"))
+   if (isparam("new_entries") && atoi(getparam("new_entries")) == 1 && isparam("unm"))
       get_user_line(lbs, getparam("unm"), NULL, NULL, NULL, NULL, &ltime_start);

    /*---- assemble message list ----*/
icon1.gif   Subst on Reply, posted by Emiliano Gabrielli on Fri Jul 8 10:52:36 2005 
the "subst on reply" parameter seems to correctly work only on the first reply..
since the second reply has the author locked to the one having replyed the first time.

Here is my config:
; preset author and email
Preset Author                 = $short_name
Preset Author Email           = $user_email
Subst on reply Author         = $short_name
Subst on reply Author Email   = $user_email
Subst on reply subject        = Re: $subject

; these attributes cannot be changed
Locked Attributes             = Author, Author Email
Fixed Attributes Reply        = Subject

My poor man solution is for now to allow everyone to change the author (unlock the field ..)
ELOG V3.1.5-3fb85fa6