> > uhm ok .. can I expect to get a release with this feature in the near future ?
> 
> I checked how I would do that and did not find a good solution. If I put a
> 
> <img width=300 ...> 
> 
> for example, this scales down a big picture to only 300 pixels width. But if you submit a small
> picture, like just an icon, it blows it up to 300 pixels as well, which does not look nice.
> Unfortunatle I don't know of any option like "maxwidth=x" which only scales pictures down if they
> are larger than x. Do you know?

the following patch should do the job:


#################################################################################
--- elogd_orig.c        2005-02-03 16:46:10.000000000 +0100
+++ elogd_imgscale.c    2005-02-08 18:58:14.000000000 +0100
@@ -13690,9 +13690,14 @@
                       ("<tr><td colspan=%d class=\"attachment\">%s %d: <a href=\"%s\">%s</a>\n",
                        colspan, loc("Attachment"), index + 1, ref, attachment[index] + 14);
                   if (show_attachments)
-                     rsprintf
-                         ("</td></tr><tr><td colspan=%d class=\"messagelist\"><img
src=\"%s\"></td></tr>",
-                          colspan, ref);
+                     if (!getcfg(lbs->name, "Attached image width", str, sizeof(str))) {
+                        rsprintf("</td></tr><tr><td colspan=%d class=\"messagelist\"><img
src=\"%s\"></td></tr>",
+                                 colspan, ref);
+                    } else {
+                        rsprintf("</td></tr><tr><td colspan=%d class=\"messagelist\">"
+                                 "<div style=\"width: %s\"><img src=\"%s\" style=\"width:
100%\"></div></td></tr>",
+                                 colspan, str, ref);
+                    }
                } else {
                   rsprintf
                       ("<tr><td colspan=%d class=\"attachment\">%s %d: <a href=\"%s\">%s</a>\n",
@@ -18090,7 +18095,10 @@
                   if (is_image(att)) {
                      rsprintf("<tr><td class=\"messageframe\">\n");
                      rsprintf("<a name=\"att%d\"></a>\n", index + 1);
-                     rsprintf("<img src=\"%s\"></td></tr>", ref);
+                     if (!getcfg(lbs->name, "Attached image width entry", str, sizeof(str)))
+                        rsprintf("<img src=\"%s\"></td></tr>", ref);
+                    else
+                        rsprintf("<div style=\"width: %s\"><img src=\"%s\" style=\"width:
100%\"></div></td></tr>", str, ref);
                      rsprintf("</td></tr>\n\n");
                   } else {
                      if (is_ascii(file_name)) {
##########################################################################################

two new elog.conf parameters are defined:
Attached image width          ; width of full view image attached
Attached image width entry    ; width of attached image in the entry list view

plz apply :-)

> > - Irestarted the daemon
> > - attached strace to it
> > - requested the list for a testin logbook, few entries some quite big images 
> >   (two thumbnails, the other are old images get resized my the browser)
> > - repeted previous point a couple of times
> > - press F5 (mozilla-firefox)  the browser hangs 4ever
> > - stop the load
> > - repeat point 3, all right
> > - F5 => hangs
> > - F5 => hangs
> 
> I tried to reproduce this problem, but everything was fine. This problem was never
> reported by anyone else as well.

running ethereal I found a bug, hope this is the problem hanging my firefox (I think
we have a good chance it is :-P)

when I have thuimbs enabled, elog returns for the ".thumb" (or ".whatever".. thumb's
extension should be transparent to elog .. uhm... it can't be .. this is a problem)

anyway, having attached a pdf (a big one) and aving attachment display enabled (with
my thumbnails generated by my script)  elog returns for the displayed thumb a
Content-Type for application/x-pdf, instead of the correct image/jpeg. I think this is
the problem.

The only way for elog to know what is the correc\t content type for thumbnails is to
get it from a configuration parameter, becouse it is a chioce of the external script
used to generate them to choose the type of thumbs (jpeg, png, gif ... )
One conf parameter defaulting to jpeg may be the solution

> > So I have posted a picture to explain better my question.
> > So could it be possible to have the index page always expanded ?
> > thanks for answers.
> 
> I added a new configuration option "Expand selection page" which defaults to
> one. So if nothing is changed in the configuration file, the logbook selection
> page is expanded by default. Only if one has very many logbooks and wants back
> the old behaviour, one has to add "Expand selection page = 0" in the config
> file. The new version is under CVS.

Many many Thanks for all Stefan ! :o)

> > ok, i've downgraded my request then ...
> > 
> > it will be still useful to have the possibility of expland selectively a single thread :-)
> 
> That you can do by clicking on the thread and look at the thread at the top of the page (;-))
> 
> That's exactly the same number of clicks as you would need to expand a thread (:-)))

LOL ..this way I can't see the list of other threads .. so il my goal is to inspect the thread
looking for something I have to:
- open the 3d
- return to 3d list
- open another 3d ..
[loop]

my wish would be to reduce it to
- open the 3d
- open another 3d ..
[loop]

of course I'm thinking to a big number of entries in a short number of 3ds .. making ugly to
simply expand everything .. :-)

> LOL ..this way I can't see the list of other threads .. so il my goal is to inspect the thread
> looking for something I have to:
> - open the 3d
> - return to 3d list
> - open another 3d ..
> [loop]
> 
> my wish would be to reduce it to
> - open the 3d
> - open another 3d ..
> [loop]

Well, I have the browser's back button on one of my mouse buttons, so "- return to 3d list" is one
mouse click. My policy is: If I can save someone two or more mouse clicks for am operation, I will
implement it. If it's less, it's not worth investing some hours of programming just to save 0.5s
each tim (;-).

Ok ok, I'll put it on the wish list. Just in case I'm running out of work. :-)