| ID |
Date |
Icon |
Author |
Author Email |
Category |
OS |
ELOG Version |
Subject |
|
67967
|
Mon Jun 8 12:02:30 2015 |
 | Stefan Ritt | stefan.ritt@psi.ch | Question | Linux | 3.1.0-2 | Re: ckeditor "Insert Timestamp" bug (was: Three problems with elogd 3.1.0-2) |
Indeed the "str" variable at the gettimedate function had the wrong string size, so that all date strings got truncated at 8 characters. That's what you've seen. Also the ../../?cmd=gettimedate was wrong and it should be ./?cmd=gettimedate. I committed the fix to GIT so it will be contained in the next release ofe log.
| David Wallis wrote: |
|
Andreas,
I too was able to track the problem down to the "gettimedate" function in elogd.c. It looks like the code is using a variable named "str" for several different purposes. I haven't had a chance to do any testing, but my suspsicion is that the size of the dynamically allocated variable is ending up too small for the time stamp string, so it gets truncated.
Your point about the topic title is a good one - I'll split this into separate issues, thanks!
| Andreas Luedeke wrote: |
|
I can confirm that there is currently a problem with the ckeditor "Insert Timestamp" button.
It apparently calls javascript code in ckeditor/plugins/timestamp/plugin.js
to catch a string from the URL "../../?cmd=gettimedate"
(I think this is one too many "../", but anyway). if you try this for the Forum:
https://midas.psi.ch/elogs/Forum/?cmd=gettimedate
it returns the wrong string. It is "Forum" instead of the date.
PS to David: The subject "Three problems ..." is not giving any indication what it is about. I would find it better in this case to post three entries to the Forum, each with a striking title :-)
| David Wallis wrote: |
|
Additional info:
"Time format = %Y" results in "2015" being pasted into the edit window when I hit the "time stamp" button.
"Time format = %m/%Y" results in the string "06/2015"
"TIme format = %m/%d/%Y" results in the string "06/04"
"Time format = %m/%d %H" results in the string "06/04 "
| David Wallis wrote: |
|
I just updated to the latest official release (V3.1.0-2411f95) and have these problems:
- The Time Stamp button pastes the logbook name when "Time format" is not specified in elogd.cfg, and when it is set to "%m/%d/%Y %H:%M", it adds the string "5/28/."
- Drag and drop for attachments dosn't work on either Chrome 37.0.2062.94 (64-bit) or FIrefox 31.5.3 (both on Linux). D&D works on the midas.psi.ch demo page. On my logbooks, the "drop attachements here" area does not have a dashed line border
- Auto-saving does not seem to be working.
The "Syntax of elogd.cfg" help file doesn't seem to reflect some of these features... it took me a while to find the settings for LDAP authentication. Am I just missing some settings for these features?
My users are loving the new functionality added in 3.1!
|
|
|
|
|
|
67969
|
Tue Jun 9 12:11:19 2015 |
| Stefan Ritt | stefan.ritt@psi.ch | Comment | Linux | ELOG V3.1.0-ac7 | Re: Emails generated by Elog |
I fixed both issues in the current GIT version. Please double check it.
| Stefan Ritt wrote: |
|
I acknowledge these two bugs and will fix them soon.
| David Pilgram wrote: |
|
I am one who received an email every time there is a new entry in this forum.
I have just noticed that since May 20, every email contains the message "An old ELOG entry has been updated: "
whereas before that date, the vast majority say "A new ELOG entry has been submitted: "
Is this something to do with the saving of draft messages?
Talking of which, I see my draft of this message shows up in the forum before I have submitted it.
|
|
|
|
67971
|
Tue Jun 9 12:51:07 2015 |
| Stefan Ritt | stefan.ritt@psi.ch | Question | Linux | V3.1.0-241 | Re: subject line bug on resumit elog entries as new? |
I fixed both issues, now resubmitting an entry or submitting a new entry both yields "New LEOG entry".
| Jacky Li wrote: |
|
Hi,
I updated an old elog entry and resubmit it as new by checking the box resubmit as new. Does the subject line should said it is a "New ELOG entry" instead of "Updated ELOG entry"? Thank you.
Also when some people submit a new elog, the subject line is "Updated ELOG entry". This is a bit odd. I can't reproduce that bug when I did my test.
Jacky
|
|
|
67978
|
Tue Jun 9 16:17:06 2015 |
| David Pilgram | David.Pilgram@epost.org.uk | Question | Linux | V3.1.1-2c4f838 | Re: subject line bug on resumit elog entries as new? |
Hi Stefan,
I see that you've updated the elog running this forum today, 5 versions after you reported fixing the "A new elog entry has been entered" and "An old elog entry has been updated" issue. But the emails coming out are still all of the "An old elog entry...", rather than "A new..."
David.
| Stefan Ritt wrote: |
|
I fixed both issues, now resubmitting an entry or submitting a new entry both yields "New LEOG entry".
| Jacky Li wrote: |
|
Hi,
I updated an old elog entry and resubmit it as new by checking the box resubmit as new. Does the subject line should said it is a "New ELOG entry" instead of "Updated ELOG entry"? Thank you.
Also when some people submit a new elog, the subject line is "Updated ELOG entry". This is a bit odd. I can't reproduce that bug when I did my test.
Jacky
|
|
|
|
67979
|
Tue Jun 9 16:46:48 2015 |
| Stefan Ritt | stefan.ritt@psi.ch | Question | Linux | V3.1.1-2c4f838 | Re: subject line bug on resumit elog entries as new? |
Any better now?
| David Pilgram wrote: |
|
Hi Stefan,
I see that you've updated the elog running this forum today, 5 versions after you reported fixing the "A new elog entry has been entered" and "An old elog entry has been updated" issue. But the emails coming out are still all of the "An old elog entry...", rather than "A new..."
|
|
|
67980
|
Tue Jun 9 16:51:55 2015 |
| David Pilgram | David.Pilgram@epost.org.uk | Question | Linux | V3.1.1-2c4f838 | Re: subject line bug on resumit elog entries as new? |
Hi Stefan,
The email sent from here had he expected (correct) message "A new ELOG entry..."
Thanks, David.
| Stefan Ritt wrote: |
|
Any better now?
| David Pilgram wrote: |
|
Hi Stefan,
I see that you've updated the elog running this forum today, 5 versions after you reported fixing the "A new elog entry has been entered" and "An old elog entry has been updated" issue. But the emails coming out are still all of the "An old elog entry...", rather than "A new..."
|
|
|
|
67983
|
Tue Jun 9 17:09:22 2015 |
| Stefan Ritt | stefan.ritt@psi.ch | Bug report | Linux | 3.1.0-2 | ELOG Forum: drafts cannot be deleted |
> Another strange thing: the draft got submitted when I hit the "Back" button after reopening it.
Well, this is a problem indeed. When edit entries now, drafts gets saved regularly, overwriting your original entry. This is a limitation of the elog database, which cannot do full versioning. So "Back" is actually the same as "Commit without email notification". Or better "Commit some ten seconds ago". Now I
don't know what the best solution is. I'm tempted to just remove the "Back" button and replace it with a "Delete" button. So people can either submit an entry or delete it completely. Any thoughts? |
|
67984
|
Tue Jun 9 17:17:11 2015 |
| David Pilgram | David.Pilgram@epost.org.uk | Bug report | Linux | V3.1.1-22022e6 | Problem with a draft message |
Hi Stefan,
I had started to write a completely different bug report, but then realised I had not checked a detail. I had written about one sentence. So I decided to abort the message, and hit the "back" button. Only I found that this had created a new entry in the elog listings. I immediately went in and deleted it, but I had expected the "Back" button to have aborted the entry (as it does in 2.9.x) not to submit the entry!
It doesn't seem to have created an email, though. And for the sake of all your users, I'd not want to experiment here on the matter too much! |