I think the text display of ASCII files, which is new in version
2.5.4, is not a good idea.  E.g. I had a large ps file attached
to one entry and it took a long time display this entry (over DSL).
Then I saw that the ps-file is displayed as text, which is not really 
useful.  

Probably it is fine to display only files ending in '.txt' per default.
In addition a file that has more than say 1000 lines should probably 
also not be displayed (as default, optional OK).  

Cheers, Heiko

> Noee. Here it works immediately.
> 
> Can you try with a fresh server from the distribution, with the example 
> elogd.cfg, to see if there is any difference?
> 
> The killing is handled in the funciton ctrlc_handler(), which sets _abort = 
> TRUE. This  is checked in line 16195, just after the select(), and the main 
> loop is exited. The select finishes after one second, although I believe 
> that the kill signal also terminates the select prematurely. The kill 
> command and a Ctrl-C keystroke should work the same way, they both generate 
> a SIGTERM or SIGINT signal.

elogd does not exit if there is an 'unprocessed' HUP.  So when you do 

kill -HUP <pid>
kill <pid> 

elogd will only exit after it was accessed.

> > elogd does not exit if there is an 'unprocessed' HUP.  So when you do 
> > 
> > kill -HUP <pid>
> > kill <pid> 
> > 
> > elogd will only exit after it was accessed.
> 
> Can you please tell me how to reproduce this problem?
> 
> Even if I do a
> 
> kill -HUP <pid>; kill <pid>
> 
> it works immediately when I start elogd manually in interactive mode (not as daemon).

Even though I can't test this right now, I assume you have to wait a little
so that elogd jumps out of the 'select()' statement between the kill
commands.  Try: 

kill -HUP <pid>; sleep 2; kill <pid>

(I think the 'select()' timeout was 1 second.?)

> > [...]
> > > Probably it is fine to display only files ending in '.txt' per default.
> > > In addition a file that has more than say 1000 lines should probably 
> > > also not be displayed (as default, optional OK).  
> > 
> > No, '.txt' would definitely not be enough for me. I'm using elog to log all
> > administration of our network. In many cases, I simply attach a configuration
> > file. All those files are plain ASCII and none of them end in '.txt' - and I
> > would most definitely like them to be displayed inline like they are now. In
> > fact, this change was the main reason for me to upgrade to 2.5.4
> > 
> > Maybe a configuration option or a "display attachment" button would be the
> > best solution, then?
> > 
> > Cheerio,
> > 
> > Thomas
> 
> So to make everybody happy, it would probably be enough not to display inline any
> *.ps file, is that right? 

I think there should be size limit.  Imagine a multi MB text file (whatever it is;
elogd.c is already more than 1/2 MB and is likely to increase due to your
excellent support).  A client on an ISDN line would have to wait
several minutes and during this time elogd is busy and no other client can connect
(correct?).  Of course, if somebody really wants to see this file then there is
nothing to be done, but likely someone is flipping throught the messages using
to arrows on top to find the right entry....
So a configurable size limit seems appropriate, from which on 
only 'Display attachment' is displayed.  And/Or, for files
exceeding this limit, the first N (new config option) lines could be displayed.

But this should only influence ASCII files.  E.g. the behaviour for jpeg files
should not change, which is controlled by 'Hide default'.  Maybe a 'Display/Hide
defaut extension' option, where the extensions are listed that are to be displayed
is another idea, in addition to a 'Max Display ASCII inline size' option,
which can be set to zero to disable it altogether.

In any case, whatever you think is best.

Cheers, Heiko

> Is there any other ASCII format, which should not be
> displayed? PDF is binary, so it won't be displayed. What about long C files? Most
> people want to see them. In the recent version there is the "Hide attachment"
> link which can be clicked to not display an attachment inline. Mabe there should
> be a "Hide default = 0|1" config option...

> > - Use "and" and "or" operands in queries                                        
> 
> Elog supports now regular expressions. So for a "<str1> OR <str2>" one can write
> 
> <str1>|<str2>
> 
> and for a "<str1> AND <str2>" one can write
> 
> <str1>.*<str2>|<str2>.*<str1>
> 
> Looks a bit complicated, but maybe some day we will get some code which rewrites
> "AND" and "OR" as regular expressions.

It seems that the quick filter searches are now (2.5.4-6) case sensitive.
Could you add an option to specify this in the config file?  Or does it
exist already?

When compiling elogd on AMD64 (in 64 bit mode) there are many 
warnings like these:

src/regex.c:3769: warning: cast from pointer to integer of different size
src/regex.c:3769: warning: cast from pointer to integer of different size
src/regex.c:3775: warning: cast to pointer from integer of different size

The reason is the (int) cast, which (I think) is not necessary.

> > When compiling elogd on AMD64 (in 64 bit mode) there are many 
> > warnings like these:
> > 
> > src/regex.c:3769: warning: cast from pointer to integer of different size
> > src/regex.c:3769: warning: cast from pointer to integer of different size
> > src/regex.c:3775: warning: cast to pointer from integer of different size
> > 
> > The reason is the (int) cast, which (I think) is not necessary.
> 
> Unfortunately I don't have a 64-bit compiler to try. Can you please check if
> elogd.c has similar warnings or only regex.c? 

  elogd.c shows the same warnings.

> The ones in elogd.c I can fix,
> but regex.c is straight from the GNU C library, so we would have to wait intil
> they fix it. Or can you get it from the 64-bit C library? The point is that I
> need the source code, so that I can compile it under Windows as well. Can you
> try to compile elogd without regex.c, like 
> 
> gcc -g -O -W -Wall -o elogd src/elogd.c

  This works OK.
 

Could you implement a 'hide attribute' and 'sort attribute' config option?
While sort is probably not so easy to do the hide option would already 
be very useful.  What I want to do is to use elog to collect bibtex entries
which are then used to generate a bibtex file.  So, e.g. if the entry 
type 'Article' is selected I would like that all fields that do not make
sense are hidden.  Currently I just lock them.  The config looks like
this:

Attributes                  = Login, Bibtex Key, Entry Type, Address,
Annote, Author, Booktitle, Chapter, Crossref, Edition, Editor, Howpublished,
Institution, Journal, Key, Month, Note, Number, Organization, Pages,
Publisher, School, Series, Title, Type, Volume, Year, URL, Short Comment
Options Entry Type          = Article{1}, Book{2}, Booklet{3}, InBook{4},
InCollection{5}, InProceedings{6}, Manual{7}, MastersThesis{8}, Misc{9},
PhDThesis{a}, Proceedings{b}, TechReport{c}, Unpublished{d}
Required Attributes         = Entry Type
; ARTICLE
{1} Comment Author          = [required]
{1} Comment Journal         = [required]
{1} Comment Title           = [required]
{1} Comment Year            = [required]
{1} Locked Attributes       = Address, Annote, Booktitle, Chapter, Crossref,
Edition, Editor, Howpublished, Institution, Key, Organization, Publisher,
School, Series, Type


Instead of Locking the attributes, hiding them altogether would make the
entry form look much nicer.  
A further improvement would be to sort the attributes, e.g. for author I
would sort the like this, i.e. the more important entries first:

{1} Sort Attributes    = Author, Title, Journal, Volume, Pages, Year, Month,
Number, Note

Attributes not mentioned in the sort line could then be displayed 
in any order.