Demo Discussion
Forum Config Examples Contributions Vulnerabilities
  Discussion forum about ELOG, Page 549 of 808  Not logged in ELOG logo
ID Date Icon Authordown Author Email Category OS ELOG Version Subject
  854   Sun Dec 19 16:55:03 2004 Question Heiko Scheith.scheit@mpi-hd.mpg.de Linux?forum entries not displayed in correct order
I just submitted a reply to elog:847 (the reply is elog:853).
Normally the thead containing the reply should now be listed as
the top thread.  Instead only the original message of the thread
(elog:820) is listed but the remaining messages in the thread are not 
listed.  It seems the problem is that for elog:820 the 'reply to this'
header is missing.  And elog:820 and elog:824 are the same messages
except that for elog:824 the subject is missing.  Actually ALL attributes
for elog:824 are missing.

I guess you could fix things up if you:
- add 'reply to this: 823' to elog:820
- remove entry elog:824
  855   Sun Dec 19 17:11:07 2004 Question Heiko Scheith.scheit@mpi-hd.mpg.deRequest  admin menu
Could you implemet and option 'admin menu' which gets displayed
when an 'admin' is logged in.  This menu could e.g. also include 'Delete'
while the normal menu would not.
  870   Mon Jan 10 19:44:16 2005 Reply Heiko Scheith.scheit@mpi-hd.mpg.deRequestLinux Re: implement 'hide attribute' and 'sort attribute'
> > Could you implement a 'hide attribute' and 'sort attribute' config option?
> 
> I implemented it as 'hidden attributes = <list>' and 'sort attributes'.

'sort attributes' sorts the logbook entries when they are displayed.  Or?

What I want is to rearrange the entry mask.  E.g. if 'Entry type' article is
selected then the attributes 'Author', 'Journal', 'Title', and 'Year' 
should be listed first, as they are required for this bibtex entry type.
Is it possible with the current elogd version to also sort (rearrange) the 
attributes in the entry mask?  If yes, how?  

Thanks for your time.
  873   Mon Jan 10 20:52:13 2005 Reply Heiko Scheith.scheit@mpi-hd.mpg.deRequestLinux Re: implement 'hide attribute' and 'sort attribute'
> > 'sort attributes' sorts the logbook entries when they are displayed.  Or?
> 
> Right
> 
> > What I want is to rearrange the entry mask.  E.g. if 'Entry type' article is
> > selected then the attributes 'Author', 'Journal', 'Title', and 'Year' 
> > should be listed first, as they are required for this bibtex entry type.
> > Is it possible with the current elogd version to also sort (rearrange) the 
> > attributes in the entry mask?  If yes, how?  
> 
> Attributes are shown in the order you specify them in the config file, so what about
> 
> Attributes = Entry type, Author, Journal, Title, Year     ???

Because for 'Entry type'='InProceedings' one needs:
'Author', 'Title', 'Booktitle', 'Year', 'Volume', 'Number'.
So, depending on the entry type that was chosen the entry mask should change,
with the required fields first and the not valid fields should not be shown
at all, which can nicely be done with the 'hidden attributes' config option.
Only the sorting (of the entry mask!) is missing! :)
  953   Sat Feb 19 18:39:52 2005 Entry Heiko Scheith.scheit@mpi-hd.mpg.deBug fixLinux2.5.7Problem with 'Show Attributes' option
There is a problem with the 'Show Attributes' option
causing the 'Format ...' options to be ignored.

See attachment for patch.
Attachment 1: patch
--- elogd.c_20050219    Sat Feb 19 18:15:09 2005
+++ elogd.c     Sat Feb 19 18:25:55 2005
@@ -8169,7 +8169,7 @@
       if (format_flags[index] & AFF_SAME_LINE)
          /* if attribute on same line, do nothing */
          rsprintf("");
-      else if (index < n_attr - 1 && (format_flags[index + 1] & AFF_SAME_LINE)) {
+      else if (aindex < n_disp_attr - 1 && (format_flags[attr_index[aindex + 1]] & AFF_SAME_LINE)) {
          /* if next attribute on same line, start a new subtable */
          rsprintf("<tr><td colspan=2><table width=\"100%%\" cellpadding=0 cellspacing=0><tr>");
          subtable = 1;
@@ -8469,7 +8469,7 @@
          }
       }
 
-      if (index < n_attr - 1 && (format_flags[index + 1] & AFF_SAME_LINE) == 0) {
+      if (aindex < n_disp_attr - 1 && (format_flags[attr_index[aindex + 1]] & AFF_SAME_LINE) == 0) {
          /* if next attribute not on same line, close row or subtable */
          if (subtable) {
             rsprintf("</table></td></tr>\n");
@@ -8479,7 +8479,7 @@
       }
 
       /* if last attribute, close row or subtable */
-      if (index == n_attr - 1) {
+      if (aindex == n_disp_attr - 1) {
          if (subtable) {
             rsprintf("</table></td></tr>\n");
             subtable = 0;
  1072   Mon Apr 11 13:52:29 2005 Warning Heiko Scheith.scheit@mpi-hd.mpg.deBug fixLinux2.5.7-1Segmentation fault when searching for empty regex
Segmentation fault when searching for empty regex
--------------------------------------------------

Searching for a regex like 'm*', which also includes zero 'm's, an empty
expression is found indefinitely in 'highlight_searchtext(...)', which 
eventually results in an overflow of 'pt1'.  The patch below fixes this
particular problem, but I would guess there are many other regular 
expressions that would lead to an overflow of 'pt1', so its size
should definitely be checked before every 'strcpy(pt1,...)' and
the loop be aborted accordingly.  (Or 'pt1' should be allocated 
and enlarged dynamically.)

*** 14777,14782 ****
--- 14777,14784 ----
        if (status != REG_NOMATCH) {
           size = pmatch[0].rm_so;
  
+        if (size == 0) break; /* check for zero size -> infinite loop */
+ 
           /* copy first part original text */
           memcpy(pt1, pt, size);
           pt1 += size;
***************
*** 14788,14795 ****
--- 14790,14799 ----
           /* see also rsputs2(char* ) */
  
           if (hidden)
+          /* need to check size of pt1 !!! */
              strcpy(pt1,
"\001B\004style=\003color:black;background-color:#ffff66\003\002");
           else
+          /* need to check size of pt1 !!! */
              strcpy(pt1, "<B style=\"color:black;background-color:#ffff66\">");
  
           pt1 += strlen(pt1);
***************
*** 14802,14814 ****
--- 14806,14821 ----
  
           /* add coloring 2nd part */
           if (hidden)
+          /* need to check size of pt1 !!! */
              strcpy(pt1, "\001/B\002");
           else
+          /* need to check size of pt1 !!! */
              strcpy(pt1, "</B>");
           pt1 += strlen(pt1);
        }
     } while (status != REG_NOMATCH);
  
+    /* need to check size of pt1 !!! */
     strcpy(pt1, pt);
  }
  1150   Wed May 18 14:12:02 2005 Warning Heiko Scheith.scheit@mpi-hd.mpg.deBug reportLinux2.5.9reverse sort option does not work for quick filter
The 'reverse sort' option does not work for quick filter searches. In the
URL there is always written 'reverse=0'. For normal 'Find' it works OK.
  1151   Wed May 18 14:18:07 2005 Warning Heiko Scheith.scheit@mpi-hd.mpg.deBug reportLinux2.5.9elog crashes when admin tries to register new users
When pasting the URL for the registration of new users (with 'Self register = 3') elog
crashes with segmentation fault. I don't have the time currently to give you more
debuging information but maybe you can have a look the same. It crashes after
the user is registered. The Email is sent, too.
ELOG V3.1.5-3fb85fa6