Demo Discussion
Forum Config Examples Contributions Vulnerabilities
  Discussion forum about ELOG, Page 714 of 806  Not logged in ELOG logo
icon3.gif   [patch]: fixed wrong extention check, posted by Emiliano Gabrielli on Tue Feb 8 17:40:54 2005 
current version uses strstr() to check if the file has the expected ascii
text extension ... this is buggy becouse this way a file named
".txt_hidden_file" or "foo.config.dat" are both seen as .txt files.

the following patch fixes the problem, plz apply to cvs:



#######################################################################
--- elogd_orig.c        2005-02-03 16:46:10.000000000 +0100
+++ elogd_extchk_fix.c  2005-02-08 17:32:21.000000000 +0100
@@ -1160,6 +1160,28 @@

 #define my_toupper(_c)    ( ((_c)>='a' && (_c)<='z') ? ((_c)-'a'+'A') : (_c) )

+static BOOL chkext(const char *str, const char *ext)
+{
+   int extl, strl;
+   char c1, c2;
+
+   if (ext == NULL || str == NULL)
+      return FALSE;
+
+   extl = strlen(ext);
+   strl = strlen(str);
+   if (extl >= strl)
+      return FALSE;
+   str = str+strl-extl;
+   while (*str) {
+      c1 = *str++;
+      c2 = *ext++;
+      if (my_toupper(c1) != my_toupper(c2))
+         return FALSE;
+   }
+   return TRUE;
+}
+
 BOOL strieq(const char *str1, const char *str2)
 {
    char c1, c2;
@@ -1168,6 +1190,8 @@
       return TRUE;
    if (str1 == NULL || str2 == NULL)
       return FALSE;
+   if (strlen(str1)!=strlen(str2))
+      return FALSE;

    while (*str1) {
       c1 = *str1++;
@@ -13698,8 +13722,8 @@
                       ("<tr><td colspan=%d class=\"attachment\">%s %d: <a
href=\"%s\">%s</a>\n",
                        colspan, loc("Attachment"), index + 1, ref,
attachment[index] + 14);

-                  if ((strstr(str, ".TXT") || strstr(str, ".ASC") ||
strstr(str, ".CFG")
-                       || strstr(str, ".CONF")
+                  if ((chkext(str, ".TXT") || chkext(str, ".ASC") ||
chkext(str, ".CFG")
+                       || chkext(str, ".CONF")
                        || strchr(str, '.') == NULL) && show_attachments) {
                      /* display attachment */
                      rsprintf("</td></tr><tr><td colspan=%d
class=\"messagelist\"><pre>", colspan);
@@ -14779,7 +14803,7 @@
    regex_t re_buf[MAX_N_ATTR + 1];
    regmatch_t pmatch[10];

-   /* redirect if enpty parameters */
+   /* redirect if empty parameters */
    if (strstr(_cmdline, "=&")) {
       while ((pt1 = strstr(_cmdline, "=&")) != NULL) {
          pt2 = pt1;
#######################################################################
    icon3.gif   Re: Want to change Entry time when using Copy To, posted by Stefan Ritt on Thu Mar 31 16:31:41 2005 
> What I want is to have the Entry time to be updated to the time it was
> copyed, not the original entry time. Moved To should perhaps retain its
> original time?

You can achieve that by using "Edit", and then check "Resubmit as new entry",
then click "Submit".

- Stefan
    icon3.gif   Re: Want to change Entry time when using Copy To, posted by Michael Husbyn on Thu Mar 31 21:42:58 2005 
> > What I want is to have the Entry time to be updated to the time it was
> > copyed, not the original entry time. Moved To should perhaps retain its
> > original time?
> 
> You can achieve that by using "Edit", and then check "Resubmit as new entry",
> then click "Submit".

The idea is good, but it does not work for me. What happens when I do this is
that I get a new ID, but the old ID is deleted.... It disappears from the list,
and if you try to access it manually it says that it is deleted.

Bug then? My config?

Best regards
Michael
icon3.gif   Howto subscribe to ELOG RSS feeds in Mozilla Thunderbird, posted by Stefan Ritt on Fri Apr 8 14:35:19 2005 rss.gif
So subscribe to ELOG RSS feeds, do the following:

- In Thunderbird, click "Tools/Account setting", then click "Add account",
"RSS News & Blogs", "Next", "Finish", "Ok".

- Select "News & Blogs" in the "Folders" pane, right-click and select
"Properties"

- Click on "Manage Subscriptions..."

- Click on "Add"

- Enter the Feed URL of elog. Use your logbook URL and add "elog.rdf". For
this forum for example, enter

http://midas.psi.ch/elogs/Forum/elog.rdf

- Click OK. That's all.

See how the RSS feed shows up in the attached image. Please note that you
need public read access to your logbook for this to work (via "Guest menu
commands"), since the RSS mechanism does not support authentication.
icon3.gif   Link To command..., posted by Tim Iskander on Mon Apr 18 17:57:38 2005 
Is it possible to create a Link To command (ala Copy To, Move To) that
would allow you to reference an entry in another log book without copying it?
This would be handy as the info would be kept current in both log books.
My thought is that it would create a psuedo entry in the other log
book that pointed back at the originating log book entry (similar to a 
UNIX soft link)
/Tim
icon3.gif   search and filters in a cookie !?, posted by Emiliano Gabrielli on Mon May 2 12:34:52 2005 
Is it possible to have last runtime filtering and viewing method to be
stored in a cookie in order to make them permanent across navigation ?

I mean:
- if I decide to view "all" entries in the elog and then open one of them, 
  I'd like not to select "show all entries" again and again
- same thing if I choose to view last week
- same for every runtime filter and/or viewing option 

hope this is simple to implement :-)  thanks in advance 
icon3.gif   per entry "expand" in threaded view, posted by Emiliano Gabrielli on Mon May 2 12:39:36 2005 
is it possible to make the "+" sign, indicating a thread in the threaded
view, to be clickable in order to be able to expand a single thread each time ?

of course elog should remember the choice, so it will be possible to expand
N threads over the M total ones..

thanx :-) 
    icon3.gif   Re: per entry "expand" in threaded view, posted by Stefan Ritt on Mon May 2 13:02:58 2005 
> of course elog should remember the choice, so it will be possible to expand
> N threads over the M total ones..

How should elog remember that? If you put this into the URL like

http://<elog-host>/<logbook>/?exp=12&exp=14&exp=18

to expand the entries 12, 14 and 18, it might work fine. But imagine that some uses
have very long list with thousands of entries. This would make the URL very long,
everything very slow and could even crash some browsers.

What I usually do is to not expand the list. If I click on an individual entry, I
see then the expanded thread for that entry above that entry. But you probably
realized this possibility already.
ELOG V3.1.5-3fb85fa6