Demo Discussion
Forum Config Examples Contributions Vulnerabilities
  Discussion forum about ELOG, Page 359 of 807  Not logged in ELOG logo
ID Date Icon Author Author Email Category OS ELOG Versiondown Subject
  67009   Fri Feb 4 23:48:54 2011 Warning T. Ribbrockemgaron+elog@ribbrock.orgBug reportOther2.9.0-2384Odd bug with conditional and required attributes

I just ran into an odd bug with conditional attributes: If I add a certain attribute to "Required Attributes", none of the conditionals will work anymore. I have tried to create a small logbook definition that will demonstrate the problem (the original logbook is more complex and uses two sets of conditionals, both of which will be disabled when the bug hits):

; General settings
Menu commands = List, New, Edit, Duplicate, Delete, Reply, Select, Move to, Download, Find, Logout, Help, Config,Admin
List Menu commands = New, Select, Find, Logout, Help, Config, Admin, Import, Download
Date Format = %d/%m/%Y
List conditions = 1
List display = Edit, Type, Created, StatusA, StatusB, Archived, Test Text, Public?

; Attributes
Attributes = Type, Created, StatusA, StatusB, Archived, Test Text, Public?
Required Attributes = Type

; Attribute Types
Type Created = date
Type Archived = date

; Options & Tooltips
Options Type = Type1{0}, Type2{1}
Options StatusA = Status-A-red, Status-A-orange, Status-A
Options StatusB = Status-B-red, Status-B-orange, Status-B
Options Public? = yes,no

; Conditionals
{0}Show Attributes Edit = Type, Created, StatusA, StatusB, Archived, Test Text, Public?
{1}Show Attributes Edit = Type, Created, StatusA, Archived, Test Text, Public?

The above logbook definition works. However, if I replace the Required Attributes = Type with Required Attributes = Type, Public?, the conditionals will no longer work. I can see the difference in the reactions of the browser - with the extra attribute, nothing happens when I change "Type". Without, the browser will spring into action and reload as soon as I change "Type". I've tested this with both Firefox 3.6.13 and Konqueror 4.4.5 on Kubuntu 10.04 as clients. Fortunately, this is not a showstopper for me, as it is not mandatory to have this attribute defined as required, but I find it a weird issue nonetheless.

Cheerio,

Thomas

P.S.: I'm currently running the latest SVN version of elogd on OPenBSD as I ran into the same problem as described in Message 66984. The above problem also happens with the 2.8.1 I was using before. Some feedback: The SVN version compiled and ran without any further intervention on OpenBSD - very nice!

  67011   Mon Feb 7 15:14:36 2011 Reply Stefan Rittstefan.ritt@psi.chBug reportOther2.9.0-2384Re: Odd bug with conditional and required attributes

T. Ribbrock wrote:

I just ran into an odd bug with conditional attributes: If I add a certain attribute to "Required Attributes", none of the conditionals will work anymore. I have tried to create a small logbook definition that will demonstrate the problem (the original logbook is more complex and uses two sets of conditionals, both of which will be disabled when the bug hits):

; General settings
Menu commands = List, New, Edit, Duplicate, Delete, Reply, Select, Move to, Download, Find, Logout, Help, Config,Admin
List Menu commands = New, Select, Find, Logout, Help, Config, Admin, Import, Download
Date Format = %d/%m/%Y
List conditions = 1
List display = Edit, Type, Created, StatusA, StatusB, Archived, Test Text, Public?

; Attributes
Attributes = Type, Created, StatusA, StatusB, Archived, Test Text, Public?
Required Attributes = Type

; Attribute Types
Type Created = date
Type Archived = date

; Options & Tooltips
Options Type = Type1{0}, Type2{1}
Options StatusA = Status-A-red, Status-A-orange, Status-A
Options StatusB = Status-B-red, Status-B-orange, Status-B
Options Public? = yes,no

; Conditionals
{0}Show Attributes Edit = Type, Created, StatusA, StatusB, Archived, Test Text, Public?
{1}Show Attributes Edit = Type, Created, StatusA, Archived, Test Text, Public?

The above logbook definition works. However, if I replace the Required Attributes = Type with Required Attributes = Type, Public?, the conditionals will no longer work. I can see the difference in the reactions of the browser - with the extra attribute, nothing happens when I change "Type". Without, the browser will spring into action and reload as soon as I change "Type". I've tested this with both Firefox 3.6.13 and Konqueror 4.4.5 on Kubuntu 10.04 as clients. Fortunately, this is not a showstopper for me, as it is not mandatory to have this attribute defined as required, but I find it a weird issue nonetheless.

Cheerio,

Thomas

P.S.: I'm currently running the latest SVN version of elogd on OPenBSD as I ran into the same problem as described in Message 66984. The above problem also happens with the 2.8.1 I was using before. Some feedback: The SVN version compiled and ran without any further intervention on OpenBSD - very nice!

Your problem is the "?" in the attribute Public?.  Attributes may only contain ordinary characters. Unfortunately I did not document this so far. Therefore I put some fix in SVN revision 2387 which allows your attribute Public?, but I'm not 100% sure if this works in all places. The safest is just to remove the question mark.

  67013   Mon Feb 7 17:26:26 2011 Reply T. Ribbrockemgaron+elog@ribbrock.orgBug reportOther2.9.0-2384Re: Odd bug with conditional and required attributes

Stefan Ritt wrote:

 

Your problem is the "?" in the attribute Public?.  Attributes may only contain ordinary characters. Unfortunately I did not document this so far. Therefore I put some fix in SVN revision 2387 which allows your attribute Public?, but I'm not 100% sure if this works in all places. The safest is just to remove the question mark.

 Thanks Stefan, I'll try that. It's strange, though: At work, we're running 2.7.6 (and have used older versions in the past) and we have several logbooks with each at least one or two attributes with '?' and never had a problem with conditionals. Hence my surprise when this suddenly hit me with 2.8.1+ at home. Removing the '?' would be quite some work, as I'd have to change all logbooks and the associated data (the latter could probably be done with "rpl", I hope). I'll think about it.

  Draft   Wed Sep 16 01:27:20 2015  Joseph McKennajoseph.mckenna@cern.chBug reportLinux2.9.0(elogd)elog client overwriting attached files when editing existing log

Using the elog client to upload atachments, I can successfully send attachments to an existing elog, however the existing attachments are lost.

I have tested using the elog client version 3.1.1 and elog client version 2.9.2 sending to elogd 2.9.0

elog -h localhost -p 8080 -l test -f  file1.png -f file2.png -e 249 -v -x

This works great, the text contained in the elog post is retained, however all attachments are lost and replaced with those sent by this command.

Can anyone provide some tips? I am not sure if its a problem with the client or server.

Thank you in advance!

Joseph


            

  68116   Wed Sep 16 02:47:33 2015 Question Joseph McKennajoseph.mckenna@cern.chBug reportLinux2.9.0(elogd)elog client overwriting attached files when editing existing log

Using the elog client to upload atachments, I can successfully send attachments to an existing elog, however the existing attachments are lost.

I have tested using the elog client version 3.1.1 and elog client version 2.9.2 sending to elogd 2.9.0

elog -h localhost -p 8080 -l test -f  file1.png -f file2.png -e 249 -v -x

This works great, the text contained in the elog post is retained, however all attachments are lost and replaced with those sent by this command.

Can anyone provide some tips? I am not sure if its a problem with the client or server.

Thank you in advance!

Joseph


            

  Draft   Mon Sep 21 10:14:50 2015 Reply Edmund Hertleedmund.hertle@kit.eduBug reportLinux2.9.0(elogd)Re: elog client overwriting attached files when editing existing log

Hey,

I think this is a "problem" of the elog client, since it simply replaces the data. In most cases this is what you want, but since I wanted to have the option to append to the acutal message I built a function to first read-back the entry and add to the message instead of replacing it.

I just played around a bit and found that the attachments will be even disconnected, if you do not specify the -f parameter but just edit a different part of this entry.

A work-around for this is tricky. I tried to write to the "Attachment" attribute directly (-a "Attachment=Filename'), since then you coud read back the data first and manually add the filenames again. But this does not work.

Since the attachments are not actually removed, the only option I see is to modify the logbook file entry on the server by manually re-adding the filenames to the "Attachment: " line. But 

Joseph McKenna wrote:

Using the elog client to upload atachments, I can successfully send attachments to an existing elog, however the existing attachments are lost.

I have tested using the elog client version 3.1.1 and elog client version 2.9.2 sending to elogd 2.9.0

elog -h localhost -p 8080 -l test -f  file1.png -f file2.png -e 249 -v -x

This works great, the text contained in the elog post is retained, however all attachments are lost and replaced with those sent by this command.

Can anyone provide some tips? I am not sure if its a problem with the client or server.

Thank you in advance!

Joseph


            

 

  68118   Mon Sep 21 10:48:31 2015 Reply Edmund Hertleedmund.hertle@kit.eduBug reportLinux2.9.0(elogd)Re: elog client overwriting attached files when editing existing log

Hey,

I think this is a "problem" of the elog client, since it simply replaces the data. In most cases this is what you want, but since I wanted to have the option to append to the acutal message I built a function to first read-back the entry and add to the message instead of replacing it.

I just played around a bit and found that the attachments will be even disconnected, if you do not specify the -f parameter but just edit a different part of this entry.

A work-around for this is tricky. I tried to write to the "Attachment" attribute directly (-a "Attachment=Filename'), since then you coud read back the data first and manually add the filenames again. But this does not work.

Since the attachments are not actually removed, the only option I see is to modify the logbook file entry on the server by manually re-adding the filenames to the "Attachment: " line.

Joseph McKenna wrote:

Using the elog client to upload atachments, I can successfully send attachments to an existing elog, however the existing attachments are lost.

I have tested using the elog client version 3.1.1 and elog client version 2.9.2 sending to elogd 2.9.0

elog -h localhost -p 8080 -l test -f  file1.png -f file2.png -e 249 -v -x

This works great, the text contained in the elog post is retained, however all attachments are lost and replaced with those sent by this command.

Can anyone provide some tips? I am not sure if its a problem with the client or server.

Thank you in advance!

Joseph


            

 

  68130   Mon Sep 28 06:45:03 2015 Reply Andreas Luedekeandreas.luedeke@psi.chRequestAll2.9.0(elogd)Re: elog client overwriting attached files when editing existing log

The "elog" command has no "append" feature. You can either create a new entry, or you can overwrite an old entry. Therefore this is not a bug but the intended bahaviour.

I admit that the documentation is misleading, since overwriting an existing entry is called "editing":

[-e <id>]                Edit existing message

I interprete your posts that you would like to have two new features for the "elog" command:

  • to append text to the body of an existing entry
  • to add additional attachments to an existing entry

Without a specific application in mind I would like to add a request (for consistency):

  • to modify a specific attribute of an existing entry.

Cheers, Andreas

Edmund Hertle wrote:

Hey,

I think this is a "problem" of the elog client, since it simply replaces the data. In most cases this is what you want, but since I wanted to have the option to append to the acutal message I built a function to first read-back the entry and add to the message instead of replacing it.

I just played around a bit and found that the attachments will be even disconnected, if you do not specify the -f parameter but just edit a different part of this entry.

A work-around for this is tricky. I tried to write to the "Attachment" attribute directly (-a "Attachment=Filename'), since then you coud read back the data first and manually add the filenames again. But this does not work.

Since the attachments are not actually removed, the only option I see is to modify the logbook file entry on the server by manually re-adding the filenames to the "Attachment: " line.

Joseph McKenna wrote:

Using the elog client to upload atachments, I can successfully send attachments to an existing elog, however the existing attachments are lost.

I have tested using the elog client version 3.1.1 and elog client version 2.9.2 sending to elogd 2.9.0

elog -h localhost -p 8080 -l test -f  file1.png -f file2.png -e 249 -v -x

This works great, the text contained in the elog post is retained, however all attachments are lost and replaced with those sent by this command.

Can anyone provide some tips? I am not sure if its a problem with the client or server.

Thank you in advance!

Joseph


            

 

 

ELOG V3.1.5-3fb85fa6