HTML-File as attachement, posted by Becher on Tue Apr 5 22:39:20 2005
|
When I upload a HTML-File as attachement the file is shown as the
HTML-source and not as the formatted text. Is there a possibility to see the
HTML-attachements as formatted text like images are shown as images? |
Re: HTML-File as attachement, posted by Stefan Ritt on Tue Apr 5 22:45:22 2005
|
> When I upload a HTML-File as attachement the file is shown as the
> HTML-source and not as the formatted text. Is there a possibility to see the
> HTML-attachements as formatted text like images are shown as images?
I could turn the ASCII display off, but the result is not always what you want.
If you have a HTML file without the <html>, <header> and <body> tags, it's ok.
But if you have these tags in your HTML (and this is the normal case), the
resulting page has these tags twice, once from the ELOG page and once from the
attachment. This confuses some browsers, so the resulting page might look
strange. A solution would be to strip these tags from the attachment, but for
that I would have to interprete the HTML attachment completely, which is too
much work.
So I will turn the ASCII display off in the next release, but be prepared to see
some nonexpected results. |
|
Re: HTML-File as attachement, posted by Becher on Wed Apr 6 14:45:22 2005
|
Yesterday I mad a little experiment:
I copied in OpenOffice the content from my HTML file, which was not shown correctly
in ELOG, to a new HTML file, uploaded it in ELOG, and now my file was shown
correctly formatted. The only one problem is that not all lines are shown, in the
last line is written ...1753 more lines... . How can I show all lines? Do I have to
recompile ELOG? |
|
Re: HTML-File as attachement, posted by Stefan Ritt on Wed Apr 6 14:56:09 2005
|
> Yesterday I mad a little experiment:
> I copied in OpenOffice the content from my HTML file, which was not shown correctly
> in ELOG, to a new HTML file, uploaded it in ELOG, and now my file was shown
> correctly formatted. The only one problem is that not all lines are shown, in the
> last line is written ...1753 more lines... . How can I show all lines? Do I have to
> recompile ELOG?
The reason for the "...1753 more lines..." is the following: Sometimes people upload
really huge files (10 MB or so). If they are displayed as ASCII attachments, each time
you access the entry you have to DOWNLOAD 10 MB. Sometimes even the browser crashes.
That's why I limited the display of the ASCII attachments to the first 1000 lines. To
see the complete file, just lick on the attachment name.
Concerning the inline display of HTML documents, I'm currently thinking of checking if
there is an <HTML> or <BODY> statement inside the file. If not, it might be just some
HTML fraction in which case it could be shown. If yes, it cannot be shown inline, but
if you click on it's name a new browser windows is opened containing the full document.
Does that sound reasonable to you? |
|
Re: HTML-File as attachement, posted by Stefan Ritt on Wed Apr 6 21:26:19 2005
|
Ok, I turned display of HTML attachments completely off in 2.5.8-3. So if one wants to see
it, on has to click on it. Otherwise there is no way to ensure a correct web page, so
people would complain again that the page does not pass the HTML validator if someone
attached an invalid HTML file. |
Re: HTML-File as attachement, posted by Becher on Wed Apr 6 23:02:47 2005
|
I think this is reasonable. All the HTML-files which I want insert (created with the software
INCA) are not shown correctly. My testfiles made with OpenOffice are shown correctly. Maybe
you have the time to program an option for the attachement "Show inside/Show in new window or
tab", so that the user can choose, how his HTML file is shown. Similiar to the option "Submit
as HTML text". |
|
Re: HTML-File as attachement, posted by Stefan Ritt on Thu Apr 7 22:18:04 2005
|
> I think this is reasonable. All the HTML-files which I want insert (created with the software
> INCA) are not shown correctly. My testfiles made with OpenOffice are shown correctly. Maybe
> you have the time to program an option for the attachement "Show inside/Show in new window or
> tab", so that the user can choose, how his HTML file is shown. Similiar to the option "Submit
> as HTML text".
I changed it such that all attachment are shown in a separate browser window if clicked. Hope
this satisfies most people. I believe an extra switch in the config file is too much for this
little thing, unless someone absolutely wants back the old behaviour. |
Conditional Attributes/Preset Text, posted by David Brody on Wed Apr 6 01:51:42 2005 
|
I upgraded from ver 2.5.5-2 to 2.5.8-2 and found that none of my preset text
worked any longer. I struggled with it for several hours and then reverted
back to 2.5.5-2 and the preset text worked again. I have attached my
elgd.cfg file for review. Thanks in advance for your help... |
|
Re: Conditional Attributes/Preset Text, posted by Stefan Ritt on Wed Apr 6 21:15:03 2005
|
> I upgraded from ver 2.5.5-2 to 2.5.8-2 and found that none of my preset text
> worked any longer. I struggled with it for several hours and then reverted
> back to 2.5.5-2 and the preset text worked again. I have attached my
> elgd.cfg file for review. Thanks in advance for your help...
Your config file really helped. You found a bug which happens only if one uses
conditions with lowercase letters, so that's why nobody else saw it before. I
fixed it and released V2.5.8-3 |
|
Re: Conditional Attributes/Preset Text, posted by David Brody on Thu Apr 7 00:51:05 2005
|
> > I upgraded from ver 2.5.5-2 to 2.5.8-2 and found that none of my preset text
> > worked any longer. I struggled with it for several hours and then reverted
> > back to 2.5.5-2 and the preset text worked again. I have attached my
> > elgd.cfg file for review. Thanks in advance for your help...
>
> Your config file really helped. You found a bug which happens only if one uses
> conditions with lowercase letters, so that's why nobody else saw it before. I
> fixed it and released V2.5.8-3
Thanks for the information.
ELOG is terrific! |
Want to change Entry time when using Copy To, posted by Michael Husbyn on Thu Mar 31 16:29:07 2005
|
Hello,
Tried to use the copy to version, just to create a new copy of a old case in
the same logbook
(e.g, support logbook, user with an old problem, to copy it to a new entry)
What I want is to have the Entry time to be updated to the time it was
copyed, not the original entry time. Moved To should perhaps retain its
original time?
Somethings that is possible or a new feature that has to be implemented?
Thanks for this great software Stefan!
Best regards
Michael Husbyn |
Re: Want to change Entry time when using Copy To, posted by Stefan Ritt on Thu Mar 31 16:31:41 2005
|
> What I want is to have the Entry time to be updated to the time it was
> copyed, not the original entry time. Moved To should perhaps retain its
> original time?
You can achieve that by using "Edit", and then check "Resubmit as new entry",
then click "Submit".
- Stefan |
|
Re: Want to change Entry time when using Copy To, posted by Michael Husbyn on Thu Mar 31 21:42:58 2005
|
> > What I want is to have the Entry time to be updated to the time it was
> > copyed, not the original entry time. Moved To should perhaps retain its
> > original time?
>
> You can achieve that by using "Edit", and then check "Resubmit as new entry",
> then click "Submit".
The idea is good, but it does not work for me. What happens when I do this is
that I get a new ID, but the old ID is deleted.... It disappears from the list,
and if you try to access it manually it says that it is deleted.
Bug then? My config?
Best regards
Michael |
|
Re: Want to change Entry time when using Copy To, posted by Stefan Ritt on Thu Mar 31 21:59:21 2005
|
> The idea is good, but it does not work for me. What happens when I do this is
> that I get a new ID, but the old ID is deleted.... It disappears from the list,
> and if you try to access it manually it says that it is deleted.
Right, that how it's supposed to be. Same would happen if you move the entry. It's
deleted from the old place and resubmitted as a new entry. Otherwise you would have
your entry twice, and that is certainly not what you want. How come you access it
manually? If you access it through the list, everything should be fine. I even
update the references if there are replies to this entry, so the replies still
point to the right entry. |
|
Re: Want to change Entry time when using Copy To, posted by Michael Husbyn on Thu Mar 31 22:06:37 2005
|
> > The idea is good, but it does not work for me. What happens when I do this is
> > that I get a new ID, but the old ID is deleted.... It disappears from the list,
> > and if you try to access it manually it says that it is deleted.
>
> Right, that how it's supposed to be. Same would happen if you move the entry. It's
> deleted from the old place and resubmitted as a new entry. Otherwise you would have
> your entry twice, and that is certainly not what you want. How come you access it
> manually? If you access it through the list, everything should be fine. I even
> update the references if there are replies to this entry, so the replies still
> point to the right entry.
But I want a duplicate entry of the entry.... so that I can reuse the text and other
items and just change the entrys that need to be changed.
E.g, you have a work request from one user with some kind of solution on it, then you
get a similar request from another user and you want to have almost the same
information in a new entry. Then you just want to create a copy of the old case and
change whatever needs to be changed.
I'm not sure if you understand what I tries to do?
Best regards
Michael |
|
Re: Want to change Entry time when using Copy To, posted by Stefan Ritt on Thu Mar 31 22:15:34 2005
|
> But I want a duplicate entry of the entry.... so that I can reuse the text and other
> items and just change the entrys that need to be changed.
>
> E.g, you have a work request from one user with some kind of solution on it, then you
> get a similar request from another user and you want to have almost the same
> information in a new entry. Then you just want to create a copy of the old case and
> change whatever needs to be changed.
>
> I'm not sure if you understand what I tries to do?
Now I understand. What you ask for is not possible right now, but I put it on the
wishlist. The best would be to add a new command "Duplicate" to the menu, which lets you
do exactly what you want. |
|
Re: Want to change Entry time when using Copy To, posted by Michael Husbyn on Thu Mar 31 22:22:40 2005
|
> > But I want a duplicate entry of the entry.... so that I can reuse the text and other
> > items and just change the entrys that need to be changed.
> >
> > E.g, you have a work request from one user with some kind of solution on it, then you
> > get a similar request from another user and you want to have almost the same
> > information in a new entry. Then you just want to create a copy of the old case and
> > change whatever needs to be changed.
> >
> > I'm not sure if you understand what I tries to do?
>
> Now I understand. What you ask for is not possible right now, but I put it on the
> wishlist. The best would be to add a new command "Duplicate" to the menu, which lets you
> do exactly what you want.
Thank you!
Or what I understand with "Resubmit as new entry", keep the old and create a new entry.
Perhaps you can trigger behavior of resubmit with a switch?
Duplicate Resubmit = 1
(default to 0 - old behavior)
or your idea is good as well.
Or just update the Entrytime if you are using Copy To:
EntryUpdate Copy To = 1
with also solves my case.
(and switch for Move To as well?)
Have a nice evening,
Best regards
Michael |
|
Re: Want to change Entry time when using Copy To, posted by Stefan Ritt on Thu Mar 31 22:40:43 2005
|
> or your idea is good as well.
Ok, I implemented a 'Duplicate' command (see this forum for example). I guess this is clearer
than modifying some of the existing functionality like 'resubmit' or 'copy to'. With 'copy to'
you probably want to keep all information from the original entry, including the submission
time, when you move it from one logbook into an other. So if we put an 'EntryUpdate Copy To',
this would not be possible any more. The new version is under CVS.
- Stefan |
|
Re: Want to change Entry time when using Copy To, posted by Michael Husbyn on Thu Mar 31 22:49:08 2005
|
> > or your idea is good as well.
>
> Ok, I implemented a 'Duplicate' command (see this forum for example). I guess this is clearer
> than modifying some of the existing functionality like 'resubmit' or 'copy to'. With 'copy to'
> you probably want to keep all information from the original entry, including the submission
> time, when you move it from one logbook into an other. So if we put an 'EntryUpdate Copy To',
> this would not be possible any more. The new version is under CVS.
Wow! You are really fast!
I'm going to try it now!
This works for me :)
Thanks for quick response Stefan!
Best regards
Michael |
Preset text Dont work more!, posted by Alex H on Fri Mar 25 16:00:55 2005
|
Hi,
I'am using Elog V2.5.8-1 and the "Preset Text" option don't work more since
I've updated Elog. could you fix it?
Thanks.
Alex |
|
Re: Preset text Dont work more!, posted by Stefan Ritt on Tue Mar 29 11:30:25 2005
|
> I'am using Elog V2.5.8-1 and the "Preset Text" option don't work more since
> I've updated Elog. could you fix it?
I tried with the example elogd.cfg and it worked there, so it must have to do
with your special configuration. Can you send me your elogd.cfg so that I could
reproduce your problem?
- Stefan |
|
Re: Preset text Dont work more!, posted by Alex H on Tue Mar 29 13:29:56 2005
|
> > I'am using Elog V2.5.8-1 and the "Preset Text" option don't work more
since
> > I've updated Elog. could you fix it?
>
> I tried with the example elogd.cfg and it worked there, so it must have
to do
> with your special configuration. Can you send me your elogd.cfg so that I
could
> reproduce your problem?
>
> - Stefan
Hello Stefan,
Here is my elogd.cfg.
I hope this will help you :)
when we be released the next elog version who correct the crash of Protect
Selection page = 1 ?
thanks for all |
|
Re: Preset text Dont work more!, posted by Stefan Ritt on Tue Mar 29 13:55:58 2005
|
> Here is my elogd.cfg.
> I hope this will help you :)
Yes it did. You were the first one using an attribute containing a dot inside a
required attribute ("Maint."). This crashed JavaScript. I found a workaround and
implemented it.
> when we be released the next elog version who correct the crash of Protect
> Selection page = 1 ?
I just release 2.5.8-2 which contains both fixes. |
|
Re: Preset text Dont work more!, posted by Alex H on Wed Mar 30 17:09:27 2005
|
> > Here is my elogd.cfg.
> > I hope this will help you :)
>
> Yes it did. You were the first one using an attribute containing a dot inside a
> required attribute ("Maint."). This crashed JavaScript. I found a workaround and
> implemented it.
>
> > when we be released the next elog version who correct the crash of Protect
> > Selection page = 1 ?
>
> I just release 2.5.8-2 which contains both fixes.
Hi,
I've change my Attribute "Maint." to "Maint" in my elogd.cfg and in my Logbook too
but the problem is the same, I have restarted the service but the problem is still
here. Any idea? o_O |
|
Re: Preset text Dont work more!, posted by Stefan Ritt on Wed Mar 30 17:11:33 2005
|
> I've change my Attribute "Maint." to "Maint" in my elogd.cfg and in my Logbook too
> but the problem is the same, I have restarted the service but the problem is still
> here. Any idea? o_O
Have you upgraded to 2.5.8-2 ? After the upgrade, "Maint." (with the dot) should also work. |
|
Re: Preset text Dont work more!, posted by Alex H on Thu Mar 31 09:37:12 2005
|
> > I've change my Attribute "Maint." to "Maint" in my elogd.cfg and in my
Logbook too
> > but the problem is the same, I have restarted the service but the
problem is still
> > here. Any idea? o_O
>
> Have you upgraded to 2.5.8-2 ? After the upgrade, "Maint." (with the dot)
should also work.
Yes I have upgraded Elog to 2.5.8-2.
I submit my new elogd.cfg file maybe it will help you.
I have try the preset text under Firefox (the last), avant browser 10.0
(build 165) and IE 6 SP1.
Thanks for help :o) |
|
Re: Preset text Dont work more!, posted by Stefan Ritt on Thu Mar 31 09:46:21 2005
|
> Yes I have upgraded Elog to 2.5.8-2.
> I submit my new elogd.cfg file maybe it will help you.
> I have try the preset text under Firefox (the last), avant browser 10.0
> (build 165) and IE 6 SP1.
I tested your config file under Firefox (the last) and it worked fine. On the
"Liste Routeurs & Firewall", I click "New", then select FWL1, then see the text
"FLW1.txt" in the main body. I don't have that file, so elog by default just
shows the file name.
I also realized that you have double entries in your config file (like two
"Attributes = " and "Options Type = " lines. However this should not be a
problem, elog just chooses the first one.
If your preset text does not work, it could be that you have switched off
JavaScript. In Firefow, you can open the JavaScript console (Tools/JavaScript
console). Maybe you see any error there.
- Stefan |
|
Re: Preset text Dont work more!, posted by Alex H on Thu Mar 31 10:33:10 2005
|
> > Yes I have upgraded Elog to 2.5.8-2.
> > I submit my new elogd.cfg file maybe it will help you.
> > I have try the preset text under Firefox (the last), avant browser 10.0
> > (build 165) and IE 6 SP1.
>
> I tested your config file under Firefox (the last) and it worked fine. On the
> "Liste Routeurs & Firewall", I click "New", then select FWL1, then see the text
> "FLW1.txt" in the main body. I don't have that file, so elog by default just
> shows the file name.
>
> I also realized that you have double entries in your config file (like two
> "Attributes = " and "Options Type = " lines. However this should not be a
> problem, elog just chooses the first one.
>
> If your preset text does not work, it could be that you have switched off
> JavaScript. In Firefow, you can open the JavaScript console (Tools/JavaScript
> console). Maybe you see any error there.
>
> - Stefan
Ok I have fix the problem :)
Options Type = FWL1{1}, FWL2{2}, FWL4{3}, VPN1{4},VPN2{5}
{1} Preset text = FWL1.txt
{2} Preset text = FWL2.txt
{3} Preset text = FWL4.txt
{4} Preset text = VPN1.txt
{5} Preset text = VPN2.txt
I have delete the "" for example FWL1.txt instead of "FWL1.txt" and I've delete
the double entries too. In fact I don't know why, ELOG has take the second Options
Type instead of the one :)! Now It work fine :)
Thanks a lot Stefan ;) |
|
Logfiles, posted by becher on Tue Mar 29 23:03:35 2005
|
Is there an option that elog creates one logfile for one entry in the
database? It seems that there elog is creating one logfile for one day. |
|
Re: Logfiles, posted by Stefan Ritt on Tue Mar 29 23:05:56 2005
|
> Is there an option that elog creates one logfile for one entry in the
> database? It seems that there elog is creating one logfile for one day.
No. One file per day was chosen in order to keep the number of files small.
For which purpose would you need such an option? |
|
Re: Logfiles, posted by Becher on Wed Mar 30 16:05:34 2005
|
I want exchange the logs as files and not with the mirroring function. My
collegue and me are already exchanging all our project files, so the logs from
ELOG could be included in this exchange. |
|
Re: Logfiles, posted by Stefan Ritt on Wed Mar 30 16:31:36 2005
|
> I want exchange the logs as files and not with the mirroring function. My
> collegue and me are already exchanging all our project files, so the logs from
> ELOG could be included in this exchange.
If you do not want to use the mirroring, then you can extract a single entry with
the "hidden" download command. Like for this entry:
http://midas.psi.ch/elogs/Forum/1039?cmd=Download
Tell your browser to save the result locally and you have a file with just this
message. Note however that if you ship these files around, and combine them with an
existing logbook by copying them to the logbook directory, you could have two
entries with the same ID, in which case elogd would produce unpredictable results. |
|
Expand all at elog home, posted by Alex H on Wed Mar 16 16:13:15 2005
|
Hi,
Is there a command line in the configuration files to show all of sub logs
on the main page of elog instead of clicking on "Expand All" on the top of
ELOG ?
Thanks |
|
Re: Expand all at elog home, posted by Alex H on Fri Mar 25 12:49:13 2005
|
> Hi,
>
> Is there a command line in the configuration files to show all of sub
logs
> on the main page of elog instead of clicking on "Expand All" on the top
of
> ELOG ?
>
> Thanks
Up ! :o)
So I have posted a picture to explain better my question.
So could it be possible to have the index page always expanded ?
thanks for answers.
Alex. |
|
Re: Expand all at elog home, posted by Stefan Ritt on Tue Mar 29 09:57:29 2005
|
> So I have posted a picture to explain better my question.
> So could it be possible to have the index page always expanded ?
> thanks for answers.
I added a new configuration option "Expand selection page" which defaults to
one. So if nothing is changed in the configuration file, the logbook selection
page is expanded by default. Only if one has very many logbooks and wants back
the old behaviour, one has to add "Expand selection page = 0" in the config
file. The new version is under CVS. |
Re: Expand all at elog home, posted by Alex H on Wed Mar 30 15:12:54 2005
|
> > So I have posted a picture to explain better my question.
> > So could it be possible to have the index page always expanded ?
> > thanks for answers.
>
> I added a new configuration option "Expand selection page" which defaults to
> one. So if nothing is changed in the configuration file, the logbook selection
> page is expanded by default. Only if one has very many logbooks and wants back
> the old behaviour, one has to add "Expand selection page = 0" in the config
> file. The new version is under CVS.
Many many Thanks for all Stefan ! :o) |
|
Unable to enter/edit time in user defined $date field?, posted by mark james on Tue Mar 22 12:03:04 2005
|
I have defined a new field called "Record Date" to accept the dates from a
previous logging system. I am not too concerned with the timestamp
associated with these old imported entries. But for new entries...
There is no way I am able enter/edit the time into my new field. They all
show as having a time of 12:00. What am I doing wrong? Here is a portion of
my config
-----------------------------------------------------------
Attributes = Record Date, Spacecraft, Author, SubSystem, Title
Required Attributes = Record Date, Spacecraft, Author, SubSystem, Title
Type Record Date = date
Time format = %A, %d %B, %Y, %H:%M
Date format = %A, %d %B, %Y, %H:%M
Preset Record date = $date
List Display = Record date, Spacecraft, Author, SubSystem, Title
Start page = ?rsort=Record date
Entries per page = 100
Message Height = 15
Page Title = ELOG - $title
Reverse sort = 1
Quick filter = Date, Spacecraft, SubSystem, Author
message comment = "Please make your log entry in the box BELOW."
Attachment Comment = "Please upload your attachment in the box BELOW."
Menu commands = List, New, Edit, Delete, Reply, Find, Help, Download, Last
Day, Move to, Copy to
Subst Author = $long_name from $remote_host
Subst Email = $user_email
RSS Title = $Title, by $author on $Record Date
Guest menu commands = Find, Last 10, Login, Help
Guest Find Menu commands = Find, Last 10, Login, Help |
|
Re: Unable to enter/edit time in user defined $date field?, posted by Stefan Ritt on Tue Mar 22 13:46:57 2005
|
> I have defined a new field called "Record Date" to accept the dates from a
> previous logging system. I am not too concerned with the timestamp
> associated with these old imported entries. But for new entries...
> There is no way I am able enter/edit the time into my new field. They all
> show as having a time of 12:00. What am I doing wrong? Here is a portion of
> my config
Date is "date", and not "date-time" unfortunately. There is no way right now to
enter a time. I plan however to add a new format "datetime", which allows that
option. So stay tuned.
- Stefan |
|
Re: Unable to enter/edit time in user defined $date field?, posted by mark james on Tue Mar 22 23:27:21 2005
|
Stefan,
Oh. OK. I will keep tuned. It would be quite useful to have.
Mark
> > I have defined a new field called "Record Date" to accept the dates from a
> > previous logging system. I am not too concerned with the timestamp
> > associated with these old imported entries. But for new entries...
> > There is no way I am able enter/edit the time into my new field. They all
> > show as having a time of 12:00. What am I doing wrong? Here is a portion of
> > my config
>
> Date is "date", and not "date-time" unfortunately. There is no way right now to
> enter a time. I plan however to add a new format "datetime", which allows that
> option. So stay tuned.
>
> - Stefan |
|
Re: Unable to enter/edit time in user defined $date field?, posted by Stefan Ritt on Wed Mar 30 11:07:08 2005
|
I implemented a "datetime" option which does exactly what you want. All you
need is a
Type Record Date = datetime
in your config file. The new option is present in version 2.5.8-2 and ready to
download. |
wrong handling of attachment names, posted by Emiliano Gabrielli on Wed Mar 23 11:29:51 2005
|
When an attached image name contains a space in its filename and attachment
display is enabled elog builds a wrong url to the image:
http://arcolog.roma2.infn.it:8080/ARCO/050309_170709/peeling+002.jpg
instead of the correct one:
http://arcolog.roma2.infn.it:8080/ARCO/050309_170709_peeling+002.jpg
The more annoing thing is that elogs hangs on this. a strace shows a select
on fd n°3 and 5 that loops forever (returning a timeout error):
send(4, "<141>Mar 23 11:36:25 elogd[22189"..., 35, 0) = 35
rt_sigaction(SIGPIPE, {SIG_IGN}, NULL, 8) = 0
select(1024, [3 5], NULL, NULL, {1, 0}) = 0 (Timeout)
select(1024, [3 5], NULL, NULL, {1, 0}) = 0 (Timeout)
May be the better solution is, after fixing the bug for backward
compatibility with already uploaded images, to implement a forced characters
substitution at upload time, replacing spaces and every character not in a
"allowed chars" list with an underscore |
|
Re: wrong handling of attachment names, posted by Emiliano Gabrielli on Wed Mar 23 12:54:51 2005
|
> When an attached image name contains a space in its filename and attachment
> display is enabled elog builds a wrong url to the image:
>
> http://arcolog.roma2.infn.it:8080/ARCO/050309_170709/peeling+002.jpg
>
> instead of the correct one:
>
> http://arcolog.roma2.infn.it:8080/ARCO/050309_170709_peeling+002.jpg
>
> The more annoing thing is that elogs hangs on this. a strace shows a select
> on fd n°3 and 5 that loops forever (returning a timeout error):
>
> send(4, "<141>Mar 23 11:36:25 elogd[22189"..., 35, 0) = 35
> rt_sigaction(SIGPIPE, {SIG_IGN}, NULL, 8) = 0
> select(1024, [3 5], NULL, NULL, {1, 0}) = 0 (Timeout)
> select(1024, [3 5], NULL, NULL, {1, 0}) = 0 (Timeout)
>
>
> May be the better solution is, after fixing the bug for backward
> compatibility with already uploaded images, to implement a forced characters
> substitution at upload time, replacing spaces and every character not in a
> "allowed chars" list with an underscore
A correction:
the url generated is correct, infact modifing by hand the names of the files and
the "Attachment:" entry in the .log all works fine
the same problem happens if the filename is, for example foo.JPG and not foo.jpg :
http://arcolog.roma2.infn.it:8080/ARCO/050221_171508/Graph3.JPG
loops forever
http://arcolog.roma2.infn.it:8080/ARCO/050221_171508/Graph3.jpg
works correctly
so, elog does not like spaces in filename and/or uppercase extensions. the
solution is, IMHO, to sanify the uploaded filename at uploading time :-) |
|
Re: wrong handling of attachment names, posted by Stefan Ritt on Wed Mar 23 20:35:55 2005
|
> When an attached image name contains a space in its filename and attachment
> display is enabled elog builds a wrong url to the image:
>
> http://arcolog.roma2.infn.it:8080/ARCO/050309_170709/peeling+002.jpg
>
> instead of the correct one:
>
> http://arcolog.roma2.infn.it:8080/ARCO/050309_170709_peeling+002.jpg
This is on purpose. If you want to save an attachment locally and right click on
the attachment, and select "Save link as..." in your browser, then the default
file name is taken from the link. If your original file namw was "peeling
002.jpg", then you want again the same name, and not "050309_170709_peeling
002.jpg, because you would have to delete the date/time part of the file name
each time which would be annoying. That's why I have chosen to put an artificial
"/" between the date/time and the original file name. On the elog side, it's
converted correctly back to the file name.
The problem with blanks in attachment names I could not reproduce. See this
post, which contains an attachment with a blank in it. As you can see, this does
not crash the server. |
|
Re: wrong handling of attachment names, posted by Emiliano Gabrielli on Thu Mar 24 10:51:10 2005
|
> > When an attached image name contains a space in its filename and attachment
> > display is enabled elog builds a wrong url to the image:
> >
> > http://arcolog.roma2.infn.it:8080/ARCO/050309_170709/peeling+002.jpg
> >
> > instead of the correct one:
> >
> > http://arcolog.roma2.infn.it:8080/ARCO/050309_170709_peeling+002.jpg
>
> This is on purpose. If you want to save an attachment locally and right click on
> the attachment, and select "Save link as..." in your browser, then the default
> file name is taken from the link. If your original file namw was "peeling
> 002.jpg", then you want again the same name, and not "050309_170709_peeling
> 002.jpg, because you would have to delete the date/time part of the file name
> each time which would be annoying. That's why I have chosen to put an artificial
> "/" between the date/time and the original file name. On the elog side, it's
> converted correctly back to the file name.
>
yes I notice this after posting :-) sorry
> The problem with blanks in attachment names I could not reproduce. See this
> post, which contains an attachment with a blank in it. As you can see, this does
> not crash the server.
Ok I can confirm this.
The problem arises, for me, when upgrading to the new version of elog having yes
some old entries with attached filenames containing spaces and/or uppercase extensions.
It seems that uploading files with spaces in the name *now* works well... so the
problem should be somewhere in the handling of existing attachments, not rised when
the attachment is uploaded with the current version of elog ... it's quite strange |
|
Re: wrong handling of attachment names, posted by Stefan Ritt on Fri Mar 25 00:33:51 2005
|
> It seems that uploading files with spaces in the name *now* works well... so the
> problem should be somewhere in the handling of existing attachments, not rised when
> the attachment is uploaded with the current version of elog ... it's quite strange
Can you send me one of this old xxxxxxa.log files which causes that crash, I can then fix
it in elogd.c ... |
|
Re: wrong handling of attachment names, posted by Emiliano Gabrielli on Thu Mar 24 13:40:27 2005
|
> When an attached image name contains a space in its filename and attachment
> display is enabled elog builds a wrong url to the image:
>
> http://arcolog.roma2.infn.it:8080/ARCO/050309_170709/peeling+002.jpg
>
> instead of the correct one:
>
> http://arcolog.roma2.infn.it:8080/ARCO/050309_170709_peeling+002.jpg
>
> The more annoing thing is that elogs hangs on this. a strace shows a select
> on fd n°3 and 5 that loops forever (returning a timeout error):
>
> send(4, "<141>Mar 23 11:36:25 elogd[22189"..., 35, 0) = 35
> rt_sigaction(SIGPIPE, {SIG_IGN}, NULL, 8) = 0
> select(1024, [3 5], NULL, NULL, {1, 0}) = 0 (Timeout)
> select(1024, [3 5], NULL, NULL, {1, 0}) = 0 (Timeout)
>
>
> May be the better solution is, after fixing the bug for backward
> compatibility with already uploaded images, to implement a forced characters
> substitution at upload time, replacing spaces and every character not in a
> "allowed chars" list with an underscore
donno if the following is correlated, otherwise there is another problem I
guess :-)
I attached a strace of elog, hope you'll find it useful.
- Irestarted the daemon
- attached strace to it
- requested the list for a testin logbook, few entries some quite big images
(two thumbnails, the other are old images get resized my the browser)
- repeted previous point a couple of times
- press F5 (mozilla-firefox) the browser hangs 4ever
- stop the load
- repeat point 3, all right
- F5 => hangs
- F5 => hangs
there should be some problem, may be in the socket ? |
|
Re: wrong handling of attachment names, posted by Stefan Ritt on Fri Mar 25 00:30:57 2005
|
> - Irestarted the daemon
> - attached strace to it
> - requested the list for a testin logbook, few entries some quite big images
> (two thumbnails, the other are old images get resized my the browser)
> - repeted previous point a couple of times
> - press F5 (mozilla-firefox) the browser hangs 4ever
> - stop the load
> - repeat point 3, all right
> - F5 => hangs
> - F5 => hangs
I tried to reproduce this problem, but everything was fine. This problem was never
reported by anyone else as well. |
|
Re: wrong handling of attachment names, posted by Emiliano Gabrielli on Tue Mar 29 11:49:29 2005
|
> > - Irestarted the daemon
> > - attached strace to it
> > - requested the list for a testin logbook, few entries some quite big images
> > (two thumbnails, the other are old images get resized my the browser)
> > - repeted previous point a couple of times
> > - press F5 (mozilla-firefox) the browser hangs 4ever
> > - stop the load
> > - repeat point 3, all right
> > - F5 => hangs
> > - F5 => hangs
>
> I tried to reproduce this problem, but everything was fine. This problem was never
> reported by anyone else as well.
I tried to rise the problem with konqueror, and all works nice... running
mozilla-firefox gives the problem instead (also running the test at the same time), so
there should be something in firefox or in the interaction between firefox and elog.
I'll send you one of the elog giving the problems so you can test by yourself as you
asked.
btw:
http://midas.psi.ch/elogs/Forum/?mode=full&attach=1 does not gives any problem to me
even running firefox. so the problem may be in some my elog.cong parameter ... |
|
Re: wrong handling of attachment names, posted by Emiliano Gabrielli on Tue Mar 29 16:21:32 2005
|
> > - Irestarted the daemon
> > - attached strace to it
> > - requested the list for a testin logbook, few entries some quite big images
> > (two thumbnails, the other are old images get resized my the browser)
> > - repeted previous point a couple of times
> > - press F5 (mozilla-firefox) the browser hangs 4ever
> > - stop the load
> > - repeat point 3, all right
> > - F5 => hangs
> > - F5 => hangs
>
> I tried to reproduce this problem, but everything was fine. This problem was never
> reported by anyone else as well.
running ethereal I found a bug, hope this is the problem hanging my firefox (I think
we have a good chance it is :-P)
when I have thuimbs enabled, elog returns for the ".thumb" (or ".whatever".. thumb's
extension should be transparent to elog .. uhm... it can't be .. this is a problem)
anyway, having attached a pdf (a big one) and aving attachment display enabled (with
my thumbnails generated by my script) elog returns for the displayed thumb a
Content-Type for application/x-pdf, instead of the correct image/jpeg. I think this is
the problem.
The only way for elog to know what is the correc\t content type for thumbnails is to
get it from a configuration parameter, becouse it is a chioce of the external script
used to generate them to choose the type of thumbs (jpeg, png, gif ... )
One conf parameter defaulting to jpeg may be the solution |